encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use Chromium's dcheck_always_on when available. 

This will make GPU tests running on Chromium-based builders respect this
configuration, which is important to have the same code run in Release
and Debug builds on the GPU FYI waterfall.

BUG=chromium:901830

Change-Id: Ia2f6f3585c4b6213fe7f55203c69d0ef4a620a67
Reviewed-on: https://dawn-review.googlesource.com/c/2708
Reviewed-by: Stephen White <senorblanco@chromium.org>
Reviewed-by: Kenneth Russell <kbr@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Corentin Wallez 2018-11-30 12:17:29 +00:00 committed by Commit Bot service account
parent df72914a60
commit 58017e91ad
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
BUILD.gn
View File

@ -18,6 +18,14 @@ import("//build_overrides/build.gni")
import("//testing/test.gni")
# Use Chromium's dcheck_always_on when available so that we respect it when
# running tests on the GPU builders
if (build_with_chromium) {
import("//build/config/dcheck_always_on.gni")
} else {
dcheck_always_on = false
}
###############################################################################
# Template to wrap the Dawn code generator
###############################################################################
@ -153,7 +161,7 @@ config("dawn_internal") {
include_dirs = [ "src" ]
defines = []
if (dawn_always_assert || is_debug) {
if (dawn_always_assert || dcheck_always_on || is_debug) {
defines += [ "DAWN_ENABLE_ASSERTS" ]
}