encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-17 17:05:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

ShaderModule: Don't use Format::Type for reflection.

Browse Source 
Previously Format::Type was used instead of wgpu::TextureComponentType
so that ::Other could server as a tag value. This was confusing and
almost the single use of ::Other.

In a follow-up CL the format baseType is changed to be a per-aspect
value, and Format::Type. This CL is a self-contained step in that
direction.

Bug: dawn:527

Change-Id: Ida834087f45a8fca17670ffe8ebd4d5c4f1cd423
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/30102
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
This commit is contained in:
Corentin Wallez
2020-10-15 13:51:33 +00:00
committed by Commit Bot service account
parent 49c30a70e8
commit 5931c0ac3b
12 changed files with 34 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/dawn_native/opengl/PipelineGL.cpp
View File

@@ -193,9 +193,8 @@ namespace dawn_native { namespace opengl {
GLuint textureIndex = indices[combined.textureLocation.group][bindingIndex];
mUnitsForTextures[textureIndex].push_back(textureUnit);
Format::Type componentType =
bgl->GetBindingInfo(bindingIndex).textureComponentType;
shouldUseFiltering = componentType == Format::Type::Float;
shouldUseFiltering = bgl->GetBindingInfo(bindingIndex).textureComponentType ==
wgpu::TextureComponentType::Float;
}
{
const BindGroupLayoutBase* bgl =