encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add proper data_deps to dawn_perf_tests. 

Currently the Chromium build defines a wrapper build target
for Dawn (//chrome/test:dawn_perf_tests) that seems to exist
only to specify some extra data dependencies. By moving this
data dependencies onto the Dawn dawn_perf_tests itself, this
removes a problematic target in Chromium that would otherwise
block my planned changes for crbug.com/816629.

Bug: chromium:816629
Change-Id: I428698fe164bd1aad09c8dba14e57a4b7acebb1c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/24302
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Dirk Pranke 2020-07-03 05:47:07 +00:00 committed by Commit Bot service account
parent f695264d30
commit 59ccb1f6de
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/tests/BUILD.gn
View File

@ -470,10 +470,11 @@ test("dawn_perf_tests") {
libs = []
# When building inside Chromium, use their gtest main function because it is
# needed to run in swarming correctly.
# When building inside Chromium, use their gtest main function and the
# other perf test scaffolding in order to run in swarming correctly.
if (build_with_chromium) {
deps += [ ":dawn_perf_tests_main" ]
data_deps = [ "//testing:run_perf_test" ]
} else {
sources += [ "PerfTestsMain.cpp" ]
}