Remove all unnecessary includes

All includes from .cc to .h are preserved, even when transitively included.

It's clear that there are far too many includes in header files, and we should be more aggressive with forward declarations. tint:532 will continue to track this work.

There are, however, plenty of includes that have accumulated over time which are no longer required directly or transitively, so this change starts with a clean slate of *required* includes.

Bug: tint:532
Change-Id: Ie1718dad565f8309fa180ef91bcf3920e76dba18
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44042
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>

src/transform/bound_array_accessors.cc

@@ -15,40 +15,10 @@
 #include "src/transform/bound_array_accessors.h"
 
 #include <algorithm>
-#include <memory>
 #include <utility>
 
-#include "src/ast/assignment_statement.h"
-#include "src/ast/binary_expression.h"
-#include "src/ast/bitcast_expression.h"
-#include "src/ast/block_statement.h"
-#include "src/ast/break_statement.h"
-#include "src/ast/call_expression.h"
-#include "src/ast/call_statement.h"
-#include "src/ast/case_statement.h"
-#include "src/ast/continue_statement.h"
-#include "src/ast/discard_statement.h"
-#include "src/ast/else_statement.h"
-#include "src/ast/fallthrough_statement.h"
-#include "src/ast/if_statement.h"
-#include "src/ast/loop_statement.h"
-#include "src/ast/member_accessor_expression.h"
-#include "src/ast/return_statement.h"
-#include "src/ast/scalar_constructor_expression.h"
-#include "src/ast/sint_literal.h"
-#include "src/ast/switch_statement.h"
-#include "src/ast/type_constructor_expression.h"
-#include "src/ast/uint_literal.h"
-#include "src/ast/unary_op_expression.h"
-#include "src/ast/variable.h"
-#include "src/ast/variable_decl_statement.h"
-#include "src/clone_context.h"
 #include "src/program_builder.h"
 #include "src/semantic/expression.h"
-#include "src/type/array_type.h"
-#include "src/type/matrix_type.h"
-#include "src/type/u32_type.h"
-#include "src/type/vector_type.h"
 
 namespace tint {
 namespace transform {

src/transform/bound_array_accessors.h

@@ -15,13 +15,7 @@
 #ifndef SRC_TRANSFORM_BOUND_ARRAY_ACCESSORS_H_
 #define SRC_TRANSFORM_BOUND_ARRAY_ACCESSORS_H_
 
-#include <string>
-
 #include "src/ast/array_accessor_expression.h"
-#include "src/ast/expression.h"
-#include "src/ast/statement.h"
-#include "src/program.h"
-#include "src/scope_stack.h"
 #include "src/transform/transform.h"
 
 namespace tint {

src/transform/emit_vertex_point_size.cc

@@ -14,20 +14,10 @@
 
 #include "src/transform/emit_vertex_point_size.h"
 
-#include <memory>
 #include <utility>
 
 #include "src/ast/assignment_statement.h"
-#include "src/ast/block_statement.h"
-#include "src/ast/float_literal.h"
-#include "src/ast/identifier_expression.h"
-#include "src/ast/scalar_constructor_expression.h"
-#include "src/ast/variable.h"
-#include "src/clone_context.h"
-#include "src/program.h"
 #include "src/program_builder.h"
-#include "src/type/f32_type.h"
-#include "src/type/type_manager.h"
 
 namespace tint {
 namespace transform {

src/transform/first_index_offset.cc

@@ -14,45 +14,12 @@
 
 #include "src/transform/first_index_offset.h"
 
-#include <cassert>
 #include <memory>
 #include <utility>
 
-#include "src/ast/array_accessor_expression.h"
-#include "src/ast/assignment_statement.h"
-#include "src/ast/binary_expression.h"
-#include "src/ast/bitcast_expression.h"
-#include "src/ast/break_statement.h"
-#include "src/ast/builtin_decoration.h"
-#include "src/ast/call_statement.h"
-#include "src/ast/case_statement.h"
-#include "src/ast/constructor_expression.h"
-#include "src/ast/else_statement.h"
-#include "src/ast/expression.h"
-#include "src/ast/fallthrough_statement.h"
-#include "src/ast/identifier_expression.h"
-#include "src/ast/if_statement.h"
-#include "src/ast/loop_statement.h"
-#include "src/ast/member_accessor_expression.h"
-#include "src/ast/return_statement.h"
-#include "src/ast/scalar_constructor_expression.h"
-#include "src/ast/struct.h"
 #include "src/ast/struct_block_decoration.h"
-#include "src/ast/struct_decoration.h"
-#include "src/ast/struct_member.h"
-#include "src/ast/struct_member_offset_decoration.h"
-#include "src/ast/switch_statement.h"
-#include "src/ast/type_constructor_expression.h"
-#include "src/ast/unary_op_expression.h"
-#include "src/ast/variable.h"
-#include "src/ast/variable_decl_statement.h"
-#include "src/ast/variable_decoration.h"
-#include "src/clone_context.h"
-#include "src/program.h"
 #include "src/program_builder.h"
 #include "src/semantic/function.h"
-#include "src/type/struct_type.h"
-#include "src/type/u32_type.h"
 
 TINT_INSTANTIATE_TYPEINFO(tint::transform::FirstIndexOffset::Data);
 

src/transform/first_index_offset.h

@@ -18,8 +18,6 @@
 #include <string>
 
 #include "src/ast/variable_decl_statement.h"
-#include "src/program.h"
-#include "src/symbol.h"
 #include "src/transform/transform.h"
 
 namespace tint {

src/transform/hlsl.cc

@@ -20,7 +20,6 @@
 #include "src/program_builder.h"
 #include "src/semantic/expression.h"
 #include "src/semantic/statement.h"
-#include "src/type/array_type.h"
 
 namespace tint {
 namespace transform {

src/transform/hlsl_test.cc

@@ -14,10 +14,6 @@
 
 #include "src/transform/hlsl.h"
 
-#include <memory>
-#include <utility>
-#include <vector>
-
 #include "src/transform/test_helper.h"
 
 namespace tint {

src/transform/manager.cc

@@ -14,8 +14,6 @@
 
 #include "src/transform/manager.h"
 
-#include "src/program_builder.h"
-
 namespace tint {
 namespace transform {
 

src/transform/manager.h

@@ -16,11 +16,9 @@
 #define SRC_TRANSFORM_MANAGER_H_
 
 #include <memory>
-#include <string>
 #include <utility>
 #include <vector>
 
-#include "src/diagnostic/diagnostic.h"
 #include "src/transform/transform.h"
 
 namespace tint {

src/transform/msl_test.cc

@@ -14,10 +14,7 @@
 
 #include "src/transform/msl.h"
 
-#include <memory>
 #include <string>
-#include <utility>
-#include <vector>
 
 #include "src/transform/test_helper.h"
 

src/transform/renamer.cc

@@ -18,10 +18,8 @@
 #include <unordered_set>
 #include <utility>
 
-#include "src/ast/member_accessor_expression.h"
 #include "src/program_builder.h"
 #include "src/semantic/call.h"
-#include "src/semantic/intrinsic.h"
 #include "src/semantic/member_accessor_expression.h"
 
 TINT_INSTANTIATE_TYPEINFO(tint::transform::Renamer::Data);

src/transform/spirv.cc

@@ -17,9 +17,7 @@
 #include <string>
 #include <utility>
 
-#include "src/ast/variable.h"
 #include "src/program_builder.h"
-#include "src/semantic/expression.h"
 #include "src/semantic/variable.h"
 
 namespace tint {

src/transform/spirv_test.cc

@@ -14,10 +14,6 @@
 
 #include "src/transform/spirv.h"
 
-#include <memory>
-#include <utility>
-#include <vector>
-
 #include "src/transform/test_helper.h"
 
 namespace tint {

src/transform/test_helper.h

@@ -21,8 +21,6 @@
 #include <vector>
 
 #include "gtest/gtest.h"
-#include "src/program.h"
-#include "src/program_builder.h"
 #include "src/reader/wgsl/parser.h"
 #include "src/transform/manager.h"
 #include "src/writer/wgsl/generator.h"

src/transform/transform.cc

@@ -16,9 +16,6 @@
 
 #include <algorithm>
 
-#include "src/ast/block_statement.h"
-#include "src/ast/function.h"
-#include "src/clone_context.h"
 #include "src/program_builder.h"
 
 TINT_INSTANTIATE_TYPEINFO(tint::transform::Data);

src/transform/transform.h

@@ -16,12 +16,9 @@
 #define SRC_TRANSFORM_TRANSFORM_H_
 
 #include <memory>
-#include <string>
-#include <type_traits>
 #include <unordered_map>
 #include <utility>
 
-#include "src/diagnostic/diagnostic.h"
 #include "src/program.h"
 
 namespace tint {

src/transform/vertex_pulling.cc

@@ -16,32 +16,12 @@
 
 #include <utility>
 
-#include "src/ast/array_accessor_expression.h"
 #include "src/ast/assignment_statement.h"
-#include "src/ast/binary_expression.h"
 #include "src/ast/bitcast_expression.h"
-#include "src/ast/member_accessor_expression.h"
-#include "src/ast/scalar_constructor_expression.h"
-#include "src/ast/stride_decoration.h"
-#include "src/ast/struct.h"
 #include "src/ast/struct_block_decoration.h"
-#include "src/ast/struct_decoration.h"
-#include "src/ast/struct_member.h"
-#include "src/ast/struct_member_offset_decoration.h"
-#include "src/ast/type_constructor_expression.h"
-#include "src/ast/uint_literal.h"
-#include "src/ast/variable.h"
 #include "src/ast/variable_decl_statement.h"
-#include "src/clone_context.h"
-#include "src/program.h"
 #include "src/program_builder.h"
 #include "src/semantic/variable.h"
-#include "src/type/array_type.h"
-#include "src/type/f32_type.h"
-#include "src/type/i32_type.h"
-#include "src/type/struct_type.h"
-#include "src/type/u32_type.h"
-#include "src/type/vector_type.h"
 
 namespace tint {
 namespace transform {

src/transform/vertex_pulling.h

@@ -20,11 +20,6 @@
 #include <unordered_map>
 #include <vector>
 
-#include "src/ast/expression.h"
-#include "src/ast/function.h"
-#include "src/ast/statement.h"
-#include "src/ast/variable.h"
-#include "src/program.h"
 #include "src/transform/transform.h"
 
 namespace tint {