Remove all unnecessary includes

All includes from .cc to .h are preserved, even when transitively included.

It's clear that there are far too many includes in header files, and we should be more aggressive with forward declarations. tint:532 will continue to track this work.

There are, however, plenty of includes that have accumulated over time which are no longer required directly or transitively, so this change starts with a clean slate of *required* includes.

Bug: tint:532
Change-Id: Ie1718dad565f8309fa180ef91bcf3920e76dba18
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44042
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>

src/validator/validator.h

@@ -15,14 +15,8 @@
 #ifndef SRC_VALIDATOR_VALIDATOR_H_
 #define SRC_VALIDATOR_VALIDATOR_H_
 
-#include <memory>
 #include <string>
 
-#include "src/ast/assignment_statement.h"
-#include "src/ast/expression.h"
-#include "src/ast/statement.h"
-#include "src/diagnostic/diagnostic.h"
-#include "src/diagnostic/formatter.h"
 #include "src/program.h"
 
 namespace tint {

src/validator/validator_builtins_test.cc

@@ -12,20 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#include "gtest/gtest.h"
-#include "src/ast/array_accessor_expression.h"
-#include "src/ast/struct.h"
-#include "src/ast/struct_block_decoration.h"
-#include "src/ast/struct_member.h"
-#include "src/ast/struct_member_decoration.h"
-#include "src/ast/type_constructor_expression.h"
-#include "src/ast/variable_decl_statement.h"
-#include "src/type/alias_type.h"
-#include "src/type/array_type.h"
-#include "src/type/f32_type.h"
-#include "src/type/i32_type.h"
-#include "src/type/struct_type.h"
-#include "src/validator/validator_impl.h"
 #include "src/validator/validator_test_helper.h"
 
 namespace tint {

src/validator/validator_control_block_test.cc

@@ -12,22 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#include "gtest/gtest.h"
-#include "spirv/unified1/GLSL.std.450.h"
-#include "src/ast/case_statement.h"
 #include "src/ast/fallthrough_statement.h"
-#include "src/ast/return_statement.h"
-#include "src/ast/scalar_constructor_expression.h"
-#include "src/ast/sint_literal.h"
-#include "src/ast/switch_statement.h"
-#include "src/ast/uint_literal.h"
-#include "src/ast/variable.h"
-#include "src/ast/variable_decl_statement.h"
-#include "src/type/alias_type.h"
-#include "src/type/f32_type.h"
-#include "src/type/i32_type.h"
-#include "src/type/u32_type.h"
-#include "src/validator/validator_impl.h"
 #include "src/validator/validator_test_helper.h"
 
 namespace tint {

src/validator/validator_function_test.cc

@@ -12,20 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#include "gtest/gtest.h"
-#include "spirv/unified1/GLSL.std.450.h"
-#include "src/ast/call_statement.h"
-#include "src/ast/pipeline_stage.h"
-#include "src/ast/return_statement.h"
-#include "src/ast/scalar_constructor_expression.h"
-#include "src/ast/sint_literal.h"
 #include "src/ast/stage_decoration.h"
-#include "src/ast/variable.h"
-#include "src/ast/variable_decl_statement.h"
-#include "src/type/f32_type.h"
-#include "src/type/i32_type.h"
-#include "src/type/void_type.h"
-#include "src/validator/validator_impl.h"
 #include "src/validator/validator_test_helper.h"
 
 namespace tint {

src/validator/validator_impl.cc

@@ -14,32 +14,18 @@
 
 #include "src/validator/validator_impl.h"
 
-#include <cassert>
-#include <unordered_set>
 #include <utility>
 
 #include "src/ast/call_statement.h"
 #include "src/ast/fallthrough_statement.h"
-#include "src/ast/function.h"
-#include "src/ast/int_literal.h"
-#include "src/ast/module.h"
 #include "src/ast/sint_literal.h"
 #include "src/ast/stage_decoration.h"
-#include "src/ast/struct.h"
-#include "src/ast/switch_statement.h"
 #include "src/ast/uint_literal.h"
-#include "src/ast/variable_decl_statement.h"
-#include "src/debug.h"
 #include "src/semantic/call.h"
-#include "src/semantic/expression.h"
 #include "src/semantic/function.h"
-#include "src/semantic/intrinsic.h"
 #include "src/semantic/variable.h"
 #include "src/type/alias_type.h"
 #include "src/type/array_type.h"
-#include "src/type/bool_type.h"
-#include "src/type/f32_type.h"
-#include "src/type/i32_type.h"
 #include "src/type/matrix_type.h"
 #include "src/type/pointer_type.h"
 #include "src/type/struct_type.h"

src/validator/validator_impl.h

@@ -16,22 +16,14 @@
 #define SRC_VALIDATOR_VALIDATOR_IMPL_H_
 
 #include <string>
-#include <unordered_map>
 #include <unordered_set>
-#include <vector>
 
 #include "src/ast/assignment_statement.h"
-#include "src/ast/call_expression.h"
-#include "src/ast/expression.h"
 #include "src/ast/identifier_expression.h"
 #include "src/ast/module.h"
 #include "src/ast/return_statement.h"
-#include "src/ast/statement.h"
 #include "src/ast/switch_statement.h"
-#include "src/ast/variable.h"
 #include "src/ast/variable_decl_statement.h"
-#include "src/diagnostic/diagnostic.h"
-#include "src/diagnostic/formatter.h"
 #include "src/program.h"
 #include "src/scope_stack.h"
 

src/validator/validator_test.cc

@@ -12,46 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#include "gtest/gtest.h"
-#include "spirv/unified1/GLSL.std.450.h"
-#include "src/ast/array_accessor_expression.h"
-#include "src/ast/assignment_statement.h"
-#include "src/ast/binary_expression.h"
-#include "src/ast/bool_literal.h"
-#include "src/ast/break_statement.h"
-#include "src/ast/call_expression.h"
-#include "src/ast/call_statement.h"
-#include "src/ast/case_statement.h"
-#include "src/ast/continue_statement.h"
-#include "src/ast/else_statement.h"
-#include "src/ast/float_literal.h"
-#include "src/ast/identifier_expression.h"
 #include "src/ast/if_statement.h"
-#include "src/ast/int_literal.h"
-#include "src/ast/loop_statement.h"
-#include "src/ast/member_accessor_expression.h"
-#include "src/ast/pipeline_stage.h"
-#include "src/ast/return_statement.h"
-#include "src/ast/scalar_constructor_expression.h"
-#include "src/ast/sint_literal.h"
 #include "src/ast/stage_decoration.h"
-#include "src/ast/struct.h"
-#include "src/ast/struct_member.h"
-#include "src/ast/switch_statement.h"
-#include "src/ast/type_constructor_expression.h"
-#include "src/ast/variable.h"
-#include "src/ast/variable_decl_statement.h"
-#include "src/type/alias_type.h"
-#include "src/type/array_type.h"
-#include "src/type/bool_type.h"
-#include "src/type/f32_type.h"
-#include "src/type/i32_type.h"
-#include "src/type/matrix_type.h"
-#include "src/type/pointer_type.h"
-#include "src/type/struct_type.h"
-#include "src/type/vector_type.h"
-#include "src/type/void_type.h"
-#include "src/validator/validator_impl.h"
 #include "src/validator/validator_test_helper.h"
 
 namespace tint {

src/validator/validator_test_helper.cc

@@ -14,8 +14,6 @@
 
 #include "src/validator/validator_test_helper.h"
 
-#include <memory>
-
 namespace tint {
 
 ValidatorTestHelper::ValidatorTestHelper() = default;

src/validator/validator_test_helper.h

@@ -15,7 +15,6 @@
 #ifndef SRC_VALIDATOR_VALIDATOR_TEST_HELPER_H_
 #define SRC_VALIDATOR_VALIDATOR_TEST_HELPER_H_
 
-#include <functional>
 #include <memory>
 #include <utility>
 #include <vector>
@@ -23,7 +22,6 @@
 #include "gtest/gtest.h"
 #include "src/program_builder.h"
 #include "src/semantic/expression.h"
-#include "src/type/void_type.h"
 #include "src/validator/validator_impl.h"
 
 namespace tint {

src/validator/validator_type_test.cc

@@ -12,23 +12,9 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#include "gtest/gtest.h"
-#include "src/ast/array_accessor_expression.h"
-#include "src/ast/struct.h"
 #include "src/ast/struct_block_decoration.h"
-#include "src/ast/struct_member.h"
-#include "src/ast/struct_member_decoration.h"
-#include "src/ast/type_constructor_expression.h"
-#include "src/ast/variable_decl_statement.h"
-#include "src/type/alias_type.h"
-#include "src/type/array_type.h"
-#include "src/type/f32_type.h"
-#include "src/type/i32_type.h"
-#include "src/type/struct_type.h"
-#include "src/validator/validator_impl.h"
 #include "src/validator/validator_test_helper.h"
 
-#include "src/ast/pipeline_stage.h"
 #include "src/ast/stage_decoration.h"
 namespace tint {
 namespace {