Replace VariableDecoration::(Is|As)Binding with Castable

Change-Id: Ia13ce42054e5f514eb34f6549da10b22129f9026
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34306
Reviewed-by: dan sinclair <dsinclair@chromium.org>
This commit is contained in:
Ben Clayton
2020-11-30 23:30:58 +00:00
parent 864579db3d
commit 62d81485dd
14 changed files with 53 additions and 70 deletions

View File

@@ -104,7 +104,7 @@ TEST_F(ParserImplTest, GlobalVariableDecl_WithDecoration) {
auto& decorations = v->decorations();
ASSERT_EQ(decorations.size(), 2u);
ASSERT_TRUE(decorations[0]->IsBinding());
ASSERT_TRUE(decorations[0]->Is<ast::BindingDecoration>());
ASSERT_TRUE(decorations[1]->IsSet());
}
@@ -138,7 +138,7 @@ TEST_F(ParserImplTest, GlobalVariableDecl_WithDecoration_MulitpleGroups) {
auto& decorations = v->decorations();
ASSERT_EQ(decorations.size(), 2u);
ASSERT_TRUE(decorations[0]->IsBinding());
ASSERT_TRUE(decorations[0]->Is<ast::BindingDecoration>());
ASSERT_TRUE(decorations[1]->IsSet());
}

View File

@@ -183,9 +183,9 @@ TEST_F(ParserImplTest, VariableDecoration_Binding) {
auto* var_deco = deco.value->As<ast::VariableDecoration>();
ASSERT_NE(var_deco, nullptr);
ASSERT_FALSE(p->has_error());
ASSERT_TRUE(var_deco->IsBinding());
ASSERT_TRUE(var_deco->Is<ast::BindingDecoration>());
auto* binding = var_deco->AsBinding();
auto* binding = var_deco->As<ast::BindingDecoration>();
EXPECT_EQ(binding->value(), 4u);
}