encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix AttemptTintPadSymbolCollision test 

This test landed simultaneously with a change that checks that storage buffers have an access qualifier, leading to broken tests.

Also fix lint issues that have crept in.

Change-Id: I4a7f0bc67d8d3e7170ddea117342a510741a495c
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48040
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Ben Clayton 2021-04-16 10:37:34 +00:00 committed by Commit Bot service account
parent 8cb5a23afb
commit 648b05e4e2
3 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/resolver/decoration_validation_test.cc
View File

@ -418,9 +418,7 @@ INSTANTIATE_TEST_SUITE_P(
Params{ty_vec4<f32>, (default_vec4.align - 1) * 7, false}, Params{ty_vec4<f32>, (default_vec4.align - 1) * 7, false},
Params{ty_mat2x2<f32>, (default_mat2x2.align - 1) * 7, false}, Params{ty_mat2x2<f32>, (default_mat2x2.align - 1) * 7, false},
Params{ty_mat3x3<f32>, (default_mat3x3.align - 1) * 7, false}, Params{ty_mat3x3<f32>, (default_mat3x3.align - 1) * 7, false},
Params{ty_mat4x4<f32>, (default_mat4x4.align - 1) * 7, false} Params{ty_mat4x4<f32>, (default_mat4x4.align - 1) * 7, false}));
));
} // namespace } // namespace
} // namespace ArrayStrideTests } // namespace ArrayStrideTests

2
src/transform/hlsl_test.cc
View File

@ -289,8 +289,8 @@ fn tint_unused_entry_point() {
auto got = Run<Hlsl>(src); auto got = Run<Hlsl>(src);
EXPECT_EQ(expect, str(got)); EXPECT_EQ(expect, str(got));
} }
} // namespace } // namespace
} // namespace transform } // namespace transform
} // namespace tint } // namespace tint

3
src/writer/msl/generator_impl_type_test.cc
View File

@ -525,7 +525,8 @@ TEST_F(MslGeneratorImplTest, AttemptTintPadSymbolCollision) {
Member("tint_pad_21", ty.f32()), Member("tint_pad_21", ty.f32()),
}); });
Global("G", s, ast::StorageClass::kStorage); Global("G", ty.access(ast::AccessControl::kReadOnly, s),
ast::StorageClass::kStorage);
GeneratorImpl& gen = Build(); GeneratorImpl& gen = Build();