Fix AttemptTintPadSymbolCollision test

This test landed simultaneously with a change that checks that storage buffers have an access qualifier, leading to broken tests.

Also fix lint issues that have crept in.

Change-Id: I4a7f0bc67d8d3e7170ddea117342a510741a495c
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48040
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

src/resolver/decoration_validation_test.cc

@@ -418,9 +418,7 @@ INSTANTIATE_TEST_SUITE_P(
         Params{ty_vec4<f32>, (default_vec4.align - 1) * 7, false},
         Params{ty_mat2x2<f32>, (default_mat2x2.align - 1) * 7, false},
         Params{ty_mat3x3<f32>, (default_mat3x3.align - 1) * 7, false},
-        Params{ty_mat4x4<f32>, (default_mat4x4.align - 1) * 7, false}
-
-        ));
+        Params{ty_mat4x4<f32>, (default_mat4x4.align - 1) * 7, false}));
 
 }  // namespace
 }  // namespace ArrayStrideTests

src/transform/hlsl_test.cc

@@ -289,8 +289,8 @@ fn tint_unused_entry_point() {
   auto got = Run<Hlsl>(src);
 
   EXPECT_EQ(expect, str(got));
-
 }
+
 }  // namespace
 }  // namespace transform
 }  // namespace tint

src/writer/msl/generator_impl_type_test.cc

@@ -525,7 +525,8 @@ TEST_F(MslGeneratorImplTest, AttemptTintPadSymbolCollision) {
           Member("tint_pad_21", ty.f32()),
       });
 
-  Global("G", s, ast::StorageClass::kStorage);
+  Global("G", ty.access(ast::AccessControl::kReadOnly, s),
+         ast::StorageClass::kStorage);
 
   GeneratorImpl& gen = Build();