mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-12-16 08:27:05 +00:00
resolver: Reenable VS validation for returning position
Fixed: tint:730 Change-Id: I7d5ebeffe2d522182d07f554a671bebab1cce2e6 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/54420 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: James Price <jrprice@google.com>
This commit is contained in:
@@ -530,9 +530,7 @@ TEST_F(ResolverEntryPointValidationTest, Parameter_Struct_DuplicateLocation) {
|
||||
12:34 note: while analysing entry point main)");
|
||||
}
|
||||
|
||||
// TODO(bclayton): Reenable after CTS is updated
|
||||
TEST_F(ResolverEntryPointValidationTest,
|
||||
DISABLED_VertexShaderMustReturnPosition) {
|
||||
TEST_F(ResolverEntryPointValidationTest, VertexShaderMustReturnPosition) {
|
||||
// [[stage(vertex)]]
|
||||
// fn main() {}
|
||||
Func(Source{{12, 34}}, "main", {}, ty.void_(), {},
|
||||
|
||||
@@ -1119,8 +1119,7 @@ bool Resolver::ValidateEntryPoint(const ast::Function* func,
|
||||
}
|
||||
}
|
||||
}
|
||||
// TODO(bclayton): Reenable after CTS is updated
|
||||
if (((false)) && !found) {
|
||||
if (!found) {
|
||||
diagnostics_.add_error(
|
||||
"a vertex shader must include the 'position' builtin in its return "
|
||||
"type",
|
||||
|
||||
Reference in New Issue
Block a user