Validate that mapped buffers aren't used in submits.

Likewise "presented" textures won't be available for use in submits so
this sets up state-tracking and validation for textures too.

Command buffer resource usage is now stored in the frontend instead of
done per-backend because it is used to validate resources are allowed in
the submits.

Also adds a test.

BUG=dawn:9

Change-Id: I0537c5113bb33a089509b4f2af4ddf4eff8051ea
Reviewed-on: https://dawn-review.googlesource.com/c/2142
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

src/tests/unittests/validation/QueueSubmitValidationTests.cpp

@@ -0,0 +1,69 @@
+// Copyright 2018 The Dawn Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "tests/unittests/validation/ValidationTest.h"
+
+#include "utils/DawnHelpers.h"
+
+namespace {
+
+class QueueSubmitValidationTest : public ValidationTest {
+};
+
+static void StoreTrueMapWriteCallback(dawnBufferMapAsyncStatus status, void*, dawnCallbackUserdata userdata) {
+    bool* userdataPtr = reinterpret_cast<bool*>(static_cast<intptr_t>(userdata));
+    *userdataPtr = true;
+}
+
+// Test submitting with a mapped buffer is disallowed
+TEST_F(QueueSubmitValidationTest, SubmitWithMappedBuffer) {
+    // Create a map-write buffer.
+    dawn::BufferDescriptor descriptor;
+    descriptor.usage = dawn::BufferUsageBit::MapWrite | dawn::BufferUsageBit::TransferSrc;
+    descriptor.size = 4;
+    dawn::Buffer buffer = device.CreateBuffer(&descriptor);
+
+    // Create a fake copy destination buffer
+    descriptor.usage = dawn::BufferUsageBit::TransferDst;
+    dawn::Buffer targetBuffer = device.CreateBuffer(&descriptor);
+
+    // Create a command buffer that reads from the mappable buffer.
+    dawn::CommandBuffer commands;
+    {
+        dawn::RenderPassDescriptor renderpass = CreateSimpleRenderPass();
+        dawn::CommandBufferBuilder builder = device.CreateCommandBufferBuilder();
+        builder.CopyBufferToBuffer(buffer, 0, targetBuffer, 0, 4);
+        commands = builder.GetResult();
+    }
+
+    dawn::Queue queue = device.CreateQueue();
+
+    // Submitting when the buffer has never been mapped should succeed
+    queue.Submit(1, &commands);
+
+    // Map the buffer, submitting when the buffer is mapped should fail
+    bool mapWriteFinished = false;
+    dawnCallbackUserdata userdata = static_cast<dawnCallbackUserdata>(reinterpret_cast<intptr_t>(&mapWriteFinished));
+    buffer.MapWriteAsync(0, 4, StoreTrueMapWriteCallback, userdata);
+    queue.Submit(0, nullptr);
+    ASSERT_TRUE(mapWriteFinished);
+
+    ASSERT_DEVICE_ERROR(queue.Submit(1, &commands));
+
+    // Unmap the buffer, queue submit should succeed
+    buffer.Unmap();
+    queue.Submit(1, &commands);
+}
+
+}  // anonymous namespace