encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add missing robustness tests. 

A few of the robustness tests were missing due to lack of shadow and
override support when robustness was implemented.

This CL adds and enables the missing tests.

Change-Id: I3e4526a21b2d0106d0756e67de258c5441c6f8b8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104468
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
This commit is contained in:
dan sinclair 2022-10-03 20:22:47 +00:00 committed by Dawn LUCI CQ
parent d4fa2a022e
commit 68124ab7d1
1 changed files with 107 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

149
src/tint/transform/robustness_test.cc
View File

@ -701,44 +701,95 @@ var<private> a : mat3x2<f32>;
)"; )";
auto got = Run<Robustness>(src); auto got = Run<Robustness>(src);
EXPECT_EQ(expect, str(got)); EXPECT_EQ(expect, str(got));
} }
// TODO(dsinclair): Implement when constant_id exists TEST_F(RobustnessTest, Vector_Constant_Id_Clamps) {
TEST_F(RobustnessTest, DISABLED_Vector_Constant_Id_Clamps) { auto* src = R"(
// @id(1300) override idx : i32; @id(1300) override idx : i32;
// var a : vec3<f32> fn f() {
// var b : f32 = a[idx] var a : vec3<f32>;
// var b : f32 = a[idx];
// ->var b : f32 = a[min(u32(idx), 2)] }
)";
auto* expect = R"(
@id(1300) override idx : i32;
fn f() {
var a : vec3<f32>;
var b : f32 = a[min(u32(idx), 2u)];
}
)";
auto got = Run<Robustness>(src);
EXPECT_EQ(expect, str(got));
} }
// TODO(dsinclair): Implement when constant_id exists TEST_F(RobustnessTest, Array_Constant_Id_Clamps) {
TEST_F(RobustnessTest, DISABLED_Array_Constant_Id_Clamps) { auto* src = R"(
// @id(1300) override idx : i32; @id(1300) override idx : i32;
// var a : array<f32, 4> fn f() {
// var b : f32 = a[idx] var a : array<f32, 4>;
// var b : f32 = a[idx];
// -> var b : f32 = a[min(u32(idx), 3)] }
)";
auto* expect = R"(
@id(1300) override idx : i32;
fn f() {
var a : array<f32, 4>;
var b : f32 = a[min(u32(idx), 3u)];
}
)";
auto got = Run<Robustness>(src);
EXPECT_EQ(expect, str(got));
} }
// TODO(dsinclair): Implement when constant_id exists TEST_F(RobustnessTest, Matrix_Column_Constant_Id_Clamps) {
TEST_F(RobustnessTest, DISABLED_Matrix_Column_Constant_Id_Clamps) { auto* src = R"(
// @id(1300) override idx : i32; @id(1300) override idx : i32;
// var a : mat3x2<f32> fn f() {
// var b : f32 = a[idx][1] var a : mat3x2<f32>;
// var b : f32 = a[idx][1];
// -> var b : f32 = a[min(u32(idx), 2)][1] }
)";
auto* expect = R"(
@id(1300) override idx : i32;
fn f() {
var a : mat3x2<f32>;
var b : f32 = a[min(u32(idx), 2u)][1];
}
)";
auto got = Run<Robustness>(src);
EXPECT_EQ(expect, str(got));
} }
// TODO(dsinclair): Implement when constant_id exists TEST_F(RobustnessTest, Matrix_Row_Constant_Id_Clamps) {
TEST_F(RobustnessTest, DISABLED_Matrix_Row_Constant_Id_Clamps) { auto* src = R"(
// @id(1300) override idx : i32; @id(1300) override idx : i32;
// var a : mat3x2<f32> fn f() {
// var b : f32 = a[1][idx] var a : mat3x2<f32>;
// var b : f32 = a[1][idx];
// -> var b : f32 = a[1][min(u32(idx), 0, 1)] }
)";
auto* expect = R"(
@id(1300) override idx : i32;
fn f() {
var a : mat3x2<f32>;
var b : f32 = a[1][min(u32(idx), 1u)];
}
)";
auto got = Run<Robustness>(src);
EXPECT_EQ(expect, str(got));
} }
TEST_F(RobustnessTest, RuntimeArray_Clamps) { TEST_F(RobustnessTest, RuntimeArray_Clamps) {
@ -1019,19 +1070,33 @@ fn f() {
EXPECT_EQ(expect, str(got)); EXPECT_EQ(expect, str(got));
} }
// TODO(dsinclair): Test for scoped variables when shadowing is implemented TEST_F(RobustnessTest, Shadowed_Variable) {
TEST_F(RobustnessTest, DISABLED_Shadowed_Variable) { auto* src = R"(
// var a : array<f32, 3>; fn f() {
// var i : u32; var a : array<f32, 3>;
// { var i : u32;
// var a : array<f32, 5>; {
// var b : f32 = a[i]; var a : array<f32, 5>;
// } var b : f32 = a[i];
// var c : f32 = a[i]; }
// var c : f32 = a[i];
// -> var b : f32 = a[min(u32(i), 4)]; }
// var c : f32 = a[min(u32(i), 2)]; )";
FAIL();
auto* expect = R"(
fn f() {
var a : array<f32, 3>;
var i : u32;
{
var a : array<f32, 5>;
var b : f32 = a[min(i, 4u)];
}
var c : f32 = a[min(i, 2u)];
}
)";
auto got = Run<Robustness>(src);
EXPECT_EQ(expect, str(got));
} }
// Check that existing use of min() and arrayLength() do not get renamed. // Check that existing use of min() and arrayLength() do not get renamed.