tint: Use PascalCase for builtin enum names

Nicer names if we add some "_tint_*" builtins

Change-Id: I7574f5cfeeeb04ec5910b20068aa0dd12a460bd5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104821
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>

src/tint/sem/builtin.cc

@@ -77,15 +77,15 @@ bool IsImageQueryBuiltin(BuiltinType i) {
 }
 
 bool IsDataPackingBuiltin(BuiltinType i) {
-    return i == BuiltinType::kPack4x8snorm || i == BuiltinType::kPack4x8unorm ||
-           i == BuiltinType::kPack2x16snorm || i == BuiltinType::kPack2x16unorm ||
-           i == BuiltinType::kPack2x16float;
+    return i == BuiltinType::kPack4X8Snorm || i == BuiltinType::kPack4X8Unorm ||
+           i == BuiltinType::kPack2X16Snorm || i == BuiltinType::kPack2X16Unorm ||
+           i == BuiltinType::kPack2X16Float;
 }
 
 bool IsDataUnpackingBuiltin(BuiltinType i) {
-    return i == BuiltinType::kUnpack4x8snorm || i == BuiltinType::kUnpack4x8unorm ||
-           i == BuiltinType::kUnpack2x16snorm || i == BuiltinType::kUnpack2x16unorm ||
-           i == BuiltinType::kUnpack2x16float;
+    return i == BuiltinType::kUnpack4X8Snorm || i == BuiltinType::kUnpack4X8Unorm ||
+           i == BuiltinType::kUnpack2X16Snorm || i == BuiltinType::kUnpack2X16Unorm ||
+           i == BuiltinType::kUnpack2X16Float;
 }
 
 bool IsBarrierBuiltin(BuiltinType i) {

src/tint/sem/builtin_test.cc

@@ -111,11 +111,11 @@ INSTANTIATE_TEST_SUITE_P(
                     BuiltinData{"textureSampleGrad", BuiltinType::kTextureSampleGrad},
                     BuiltinData{"textureSampleLevel", BuiltinType::kTextureSampleLevel},
                     BuiltinData{"trunc", BuiltinType::kTrunc},
-                    BuiltinData{"unpack2x16float", BuiltinType::kUnpack2x16float},
-                    BuiltinData{"unpack2x16snorm", BuiltinType::kUnpack2x16snorm},
-                    BuiltinData{"unpack2x16unorm", BuiltinType::kUnpack2x16unorm},
-                    BuiltinData{"unpack4x8snorm", BuiltinType::kUnpack4x8snorm},
-                    BuiltinData{"unpack4x8unorm", BuiltinType::kUnpack4x8unorm},
+                    BuiltinData{"unpack2x16float", BuiltinType::kUnpack2X16Float},
+                    BuiltinData{"unpack2x16snorm", BuiltinType::kUnpack2X16Snorm},
+                    BuiltinData{"unpack2x16unorm", BuiltinType::kUnpack2X16Unorm},
+                    BuiltinData{"unpack4x8snorm", BuiltinType::kUnpack4X8Snorm},
+                    BuiltinData{"unpack4x8unorm", BuiltinType::kUnpack4X8Unorm},
                     BuiltinData{"workgroupBarrier", BuiltinType::kWorkgroupBarrier}));
 
 TEST_F(BuiltinTypeTest, ParseNoMatch) {

src/tint/sem/builtin_type.cc

@@ -193,19 +193,19 @@ BuiltinType ParseBuiltinType(const std::string& name) {
         return BuiltinType::kNormalize;
     }
     if (name == "pack2x16float") {
-        return BuiltinType::kPack2x16float;
+        return BuiltinType::kPack2X16Float;
     }
     if (name == "pack2x16snorm") {
-        return BuiltinType::kPack2x16snorm;
+        return BuiltinType::kPack2X16Snorm;
     }
     if (name == "pack2x16unorm") {
-        return BuiltinType::kPack2x16unorm;
+        return BuiltinType::kPack2X16Unorm;
     }
     if (name == "pack4x8snorm") {
-        return BuiltinType::kPack4x8snorm;
+        return BuiltinType::kPack4X8Snorm;
     }
     if (name == "pack4x8unorm") {
-        return BuiltinType::kPack4x8unorm;
+        return BuiltinType::kPack4X8Unorm;
     }
     if (name == "pow") {
         return BuiltinType::kPow;
@@ -265,19 +265,19 @@ BuiltinType ParseBuiltinType(const std::string& name) {
         return BuiltinType::kTrunc;
     }
     if (name == "unpack2x16float") {
-        return BuiltinType::kUnpack2x16float;
+        return BuiltinType::kUnpack2X16Float;
     }
     if (name == "unpack2x16snorm") {
-        return BuiltinType::kUnpack2x16snorm;
+        return BuiltinType::kUnpack2X16Snorm;
     }
     if (name == "unpack2x16unorm") {
-        return BuiltinType::kUnpack2x16unorm;
+        return BuiltinType::kUnpack2X16Unorm;
     }
     if (name == "unpack4x8snorm") {
-        return BuiltinType::kUnpack4x8snorm;
+        return BuiltinType::kUnpack4X8Snorm;
     }
     if (name == "unpack4x8unorm") {
-        return BuiltinType::kUnpack4x8unorm;
+        return BuiltinType::kUnpack4X8Unorm;
     }
     if (name == "workgroupBarrier") {
         return BuiltinType::kWorkgroupBarrier;
@@ -477,15 +477,15 @@ const char* str(BuiltinType i) {
             return "modf";
         case BuiltinType::kNormalize:
             return "normalize";
-        case BuiltinType::kPack2x16float:
+        case BuiltinType::kPack2X16Float:
             return "pack2x16float";
-        case BuiltinType::kPack2x16snorm:
+        case BuiltinType::kPack2X16Snorm:
             return "pack2x16snorm";
-        case BuiltinType::kPack2x16unorm:
+        case BuiltinType::kPack2X16Unorm:
             return "pack2x16unorm";
-        case BuiltinType::kPack4x8snorm:
+        case BuiltinType::kPack4X8Snorm:
             return "pack4x8snorm";
-        case BuiltinType::kPack4x8unorm:
+        case BuiltinType::kPack4X8Unorm:
             return "pack4x8unorm";
         case BuiltinType::kPow:
             return "pow";
@@ -525,15 +525,15 @@ const char* str(BuiltinType i) {
             return "transpose";
         case BuiltinType::kTrunc:
             return "trunc";
-        case BuiltinType::kUnpack2x16float:
+        case BuiltinType::kUnpack2X16Float:
             return "unpack2x16float";
-        case BuiltinType::kUnpack2x16snorm:
+        case BuiltinType::kUnpack2X16Snorm:
             return "unpack2x16snorm";
-        case BuiltinType::kUnpack2x16unorm:
+        case BuiltinType::kUnpack2X16Unorm:
             return "unpack2x16unorm";
-        case BuiltinType::kUnpack4x8snorm:
+        case BuiltinType::kUnpack4X8Snorm:
             return "unpack4x8snorm";
-        case BuiltinType::kUnpack4x8unorm:
+        case BuiltinType::kUnpack4X8Unorm:
             return "unpack4x8unorm";
         case BuiltinType::kWorkgroupBarrier:
             return "workgroupBarrier";

src/tint/sem/builtin_type.cc.tmpl

@@ -20,7 +20,7 @@ namespace tint::sem {
 BuiltinType ParseBuiltinType(const std::string& name) {
 {{- range Sem.Builtins  }}
     if (name == "{{.Name}}") {
-        return BuiltinType::k{{Title .Name}};
+        return BuiltinType::k{{PascalCase .Name}};
     }
 {{- end  }}
     return BuiltinType::kNone;
@@ -31,7 +31,7 @@ const char* str(BuiltinType i) {
         case BuiltinType::kNone:
             return "<none>";
 {{- range Sem.Builtins  }}
-        case BuiltinType::k{{Title .Name}}:
+        case BuiltinType::k{{PascalCase .Name}}:
             return "{{.Name}}";
 {{- end  }}
     }

src/tint/sem/builtin_type.h

@@ -86,11 +86,11 @@ enum class BuiltinType {
     kMix,
     kModf,
     kNormalize,
-    kPack2x16float,
-    kPack2x16snorm,
-    kPack2x16unorm,
-    kPack4x8snorm,
-    kPack4x8unorm,
+    kPack2X16Float,
+    kPack2X16Snorm,
+    kPack2X16Unorm,
+    kPack4X8Snorm,
+    kPack4X8Unorm,
     kPow,
     kRadians,
     kReflect,
@@ -110,11 +110,11 @@ enum class BuiltinType {
     kTanh,
     kTranspose,
     kTrunc,
-    kUnpack2x16float,
-    kUnpack2x16snorm,
-    kUnpack2x16unorm,
-    kUnpack4x8snorm,
-    kUnpack4x8unorm,
+    kUnpack2X16Float,
+    kUnpack2X16Snorm,
+    kUnpack2X16Unorm,
+    kUnpack4X8Snorm,
+    kUnpack4X8Unorm,
     kWorkgroupBarrier,
     kTextureDimensions,
     kTextureGather,

src/tint/sem/builtin_type.h.tmpl

@@ -23,7 +23,7 @@ namespace tint::sem {
 enum class BuiltinType {
     kNone = -1,
 {{- range Sem.Builtins }}
-    k{{Title .Name}},
+    k{{PascalCase .Name}},
 {{- end }}
 };