tint: Use "demote-to-helper" semantics for discard

Discard statements no longer affect the behavior or uniformity
analysis. Update the resolver, validator, and several tests to reflect
this.

Some E2E tests were removed as they had loops that are now considered
to be infinite.

Use the DemoteToHelper transform to emulate the correct semantics on
platforms where discard is (or may) terminate the invocation in a
manner that would affect derivative operations.

We no longer need the UnwindDiscardFunctions transform for HLSL, which
already implements the correct semantics. However, we still run the
DemoteToHelper transform for the HLSL backend due to issues with FXC's
handling of discard statements (see crbug.com/tint/1118).

Fixed: tint:1723
Change-Id: Ib49ff187919ae81c4af8675e1b66acd57e2ff7d2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/109003
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: James Price <jrprice@google.com>
This commit is contained in:
James Price
2022-11-09 19:58:59 +00:00
committed by Dawn LUCI CQ
parent 78ae4c243b
commit 744d0eb4aa
89 changed files with 1944 additions and 5513 deletions

View File

@@ -20,8 +20,6 @@ std::ostream& operator<<(std::ostream& out, Behavior behavior) {
switch (behavior) {
case Behavior::kReturn:
return out << "Return";
case Behavior::kDiscard:
return out << "Discard";
case Behavior::kBreak:
return out << "Break";
case Behavior::kContinue:

View File

@@ -23,7 +23,6 @@ namespace tint::sem {
/// @see https://www.w3.org/TR/WGSL/#behaviors
enum class Behavior {
kReturn,
kDiscard,
kBreak,
kContinue,
kFallthrough,