encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-17 00:47:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Assigning nullptr to descriptor's nextInChain in C++ is unneeded

Browse Source 
It has already been initialized to nullptr by C++ autogen code.

BUG=dawn:82

Change-Id: I2c1cad003a7a12227cb3d17a90e12c16739ee9a0
Reviewed-on: https://dawn-review.googlesource.com/c/3600
Commit-Queue: Yunchao He <yunchao.he@intel.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Yunchao He
2019-01-03 10:33:55 +00:00
committed by Commit Bot service account
parent 2b9d702c09
commit 74ec15010f
5 changed files with 1 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/tests/unittests/validation/BindGroupValidationTests.cpp
View File

@@ -141,7 +141,6 @@ TEST_F(BindGroupValidationTest, SamplerBindingType) {
binding.size = 0;
dawn::BindGroupDescriptor descriptor;
descriptor.nextInChain = nullptr;
descriptor.layout = layout;
descriptor.numBindings = 1;
descriptor.bindings = &binding;
@@ -179,7 +178,6 @@ TEST_F(BindGroupValidationTest, TextureBindingType) {
binding.size = 0;
dawn::BindGroupDescriptor descriptor;
descriptor.nextInChain = nullptr;
descriptor.layout = layout;
descriptor.numBindings = 1;
descriptor.bindings = &binding;
@@ -217,7 +215,6 @@ TEST_F(BindGroupValidationTest, BufferBindingType) {
binding.size = 0;
dawn::BindGroupDescriptor descriptor;
descriptor.nextInChain = nullptr;
descriptor.layout = layout;
descriptor.numBindings = 1;
descriptor.bindings = &binding;

3
src/tests/unittests/validation/TextureValidationTests.cpp
View File

@@ -32,7 +32,6 @@ constexpr dawn::TextureFormat kDefaultTextureFormat = dawn::TextureFormat::R8G8B
dawn::TextureDescriptor CreateDefaultTextureDescriptor() {
dawn::TextureDescriptor descriptor;
descriptor.nextInChain = nullptr;
descriptor.size.width = kWidth;
descriptor.size.height = kHeight;
descriptor.size.depth = 1;
@@ -65,4 +64,4 @@ TEST_F(TextureValidationTest, SampleCount) {
ASSERT_DEVICE_ERROR(device.CreateTexture(&descriptor));
}
}
}
} // namespace