encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "CTS: Lift expectations for passing tests ComputeDispatchTests." 

This reverts commit f42c4c7e5b.

Reason for revert: Tests are still failing. Win x86 bot doesn't run by
default on Dawn CQ.

Original change's description:
> CTS: Lift expectations for passing tests ComputeDispatchTests.
>
> Bug: dawn:1196
>
> Change-Id: I566f6171b6783fb51c3727aab64bd1488afa933f
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/111800
> Commit-Queue: Austin Eng <enga@chromium.org>
> Reviewed-by: Austin Eng <enga@chromium.org>
> Kokoro: Kokoro <noreply+kokoro@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: dawn:1196
Change-Id: I27799d6bcbc9e32079a3a39b94c1d42ec517e233
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112240
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Austin Eng <enga@chromium.org>
This commit is contained in:
Austin Eng 2022-11-29 16:39:52 +00:00 committed by Dawn LUCI CQ
parent 775dfbf7a8
commit 75759ac273
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/dawn/tests/end2end/ComputeDispatchTests.cpp
View File

@ -214,6 +214,10 @@ TEST_P(ComputeDispatchTests, DirectNoop) {
// Test basic indirect // Test basic indirect
TEST_P(ComputeDispatchTests, IndirectBasic) { TEST_P(ComputeDispatchTests, IndirectBasic) {
#if DAWN_PLATFORM_IS(32_BIT)
// TODO(crbug.com/dawn/1196): Fails on Chromium's Quadro P400 bots
DAWN_SUPPRESS_TEST_IF(IsD3D12() && IsNvidia());
#endif
// TODO(crbug.com/dawn/1262): Fails with the full validation turned on. // TODO(crbug.com/dawn/1262): Fails with the full validation turned on.
DAWN_SUPPRESS_TEST_IF(IsD3D12() && IsFullBackendValidationEnabled()); DAWN_SUPPRESS_TEST_IF(IsD3D12() && IsFullBackendValidationEnabled());
@ -242,6 +246,10 @@ TEST_P(ComputeDispatchTests, IndirectNoop) {
// Test indirect with buffer offset // Test indirect with buffer offset
TEST_P(ComputeDispatchTests, IndirectOffset) { TEST_P(ComputeDispatchTests, IndirectOffset) {
#if DAWN_PLATFORM_IS(32_BIT)
// TODO(crbug.com/dawn/1196): Fails on Chromium's Quadro P400 bots
DAWN_SUPPRESS_TEST_IF(IsD3D12() && IsNvidia());
#endif
// TODO(crbug.com/dawn/1262): Fails with the full validation turned on. // TODO(crbug.com/dawn/1262): Fails with the full validation turned on.
DAWN_SUPPRESS_TEST_IF(IsD3D12() && IsFullBackendValidationEnabled()); DAWN_SUPPRESS_TEST_IF(IsD3D12() && IsFullBackendValidationEnabled());
@ -255,6 +263,10 @@ TEST_P(ComputeDispatchTests, IndirectOffsetWithoutNumWorkgroups) {
// Test indirect dispatches at max limit. // Test indirect dispatches at max limit.
TEST_P(ComputeDispatchTests, MaxWorkgroups) { TEST_P(ComputeDispatchTests, MaxWorkgroups) {
#if DAWN_PLATFORM_IS(32_BIT)
// TODO(crbug.com/dawn/1196): Fails on Chromium's Quadro P400 bots
DAWN_SUPPRESS_TEST_IF(IsD3D12() && IsNvidia());
#endif
// TODO(crbug.com/dawn/1262): Fails with the full validation turned on. // TODO(crbug.com/dawn/1262): Fails with the full validation turned on.
DAWN_SUPPRESS_TEST_IF(IsD3D12() && IsFullBackendValidationEnabled()); DAWN_SUPPRESS_TEST_IF(IsD3D12() && IsFullBackendValidationEnabled());