encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Suppress MultithreadTests.Device_Dropped*OnAnotherThread 

These tests seem to cause flakiness in other sampling tests on NVIDIA.

Bug: dawn:1779
Change-Id: Ide341033a4f13d8294021752ad3d18850a7369d6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/129400
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
This commit is contained in:
Le Hoang Quyen 2023-04-26 17:18:13 +00:00 committed by Dawn LUCI CQ
parent dcf3080dee
commit 759238b962
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/dawn/tests/end2end/MultithreadTests.cpp
View File

@ -101,6 +101,10 @@ class MultithreadTests : public DawnTest {
// Test that dropping a device's last ref on another thread won't crash Instance::ProcessEvents. // Test that dropping a device's last ref on another thread won't crash Instance::ProcessEvents.
TEST_P(MultithreadTests, Device_DroppedOnAnotherThread) { TEST_P(MultithreadTests, Device_DroppedOnAnotherThread) {
// TODO(crbug.com/dawn/1779): This test seems to cause flakiness in other sampling tests on
// NVIDIA.
DAWN_SUPPRESS_TEST_IF(IsD3D12() && IsNvidia());
std::vector<wgpu::Device> devices(5); std::vector<wgpu::Device> devices(5);
// Create devices. // Create devices.
@ -132,6 +136,10 @@ TEST_P(MultithreadTests, Device_DroppedOnAnotherThread) {
// Test that dropping a device's last ref inside a callback on another thread won't crash // Test that dropping a device's last ref inside a callback on another thread won't crash
// Instance::ProcessEvents. // Instance::ProcessEvents.
TEST_P(MultithreadTests, Device_DroppedInCallback_OnAnotherThread) { TEST_P(MultithreadTests, Device_DroppedInCallback_OnAnotherThread) {
// TODO(crbug.com/dawn/1779): This test seems to cause flakiness in other sampling tests on
// NVIDIA.
DAWN_SUPPRESS_TEST_IF(IsD3D12() && IsNvidia());
std::vector<wgpu::Device> devices(10); std::vector<wgpu::Device> devices(10);
// Create devices. // Create devices.