Fix Dawn's proxy groups to use public_deps instead of deps
To do perfect forwarding of GN targets, the proper method is to make a group with public_deps. For example in the following: - Config C - Target T with a public_deps including C - Group G that proxies B - Target T2 that depends on G If G uses deps = [ T ] then T2 won't see C, whereas if G uses public_deps = [ T ] then T2 will dep on T, which will make it dep on C. Bug: chromium:1064305 Change-Id: Iae236150c119b1a4003b957dcacf42e7759a936c Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/18965 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
This commit is contained in:
parent
ce100347eb
commit
7dbfc91d30
12
BUILD.gn
12
BUILD.gn
|
@ -639,19 +639,19 @@ group("dawn_fuzzers") {
|
|||
###############################################################################
|
||||
|
||||
group("libdawn_native") {
|
||||
deps = [
|
||||
public_deps = [
|
||||
"src/dawn_native",
|
||||
]
|
||||
}
|
||||
|
||||
group("libdawn_native_sources") {
|
||||
deps = [
|
||||
public_deps = [
|
||||
"src/dawn_native:dawn_native_sources",
|
||||
]
|
||||
}
|
||||
|
||||
group("libdawn_wire") {
|
||||
deps = [
|
||||
public_deps = [
|
||||
"src/dawn_wire",
|
||||
]
|
||||
}
|
||||
|
@ -659,21 +659,21 @@ group("libdawn_wire") {
|
|||
# Temporary groups to make a 5-way patch to fix crbug.com/913171
|
||||
group("dawn_unittests_temp_group") {
|
||||
testonly = true
|
||||
deps = [
|
||||
public_deps = [
|
||||
":dawn_unittests",
|
||||
]
|
||||
}
|
||||
|
||||
group("dawn_end2end_tests_temp_group") {
|
||||
testonly = true
|
||||
deps = [
|
||||
public_deps = [
|
||||
":dawn_end2end_tests",
|
||||
]
|
||||
}
|
||||
|
||||
group("dawn_perf_tests_temp_group") {
|
||||
testonly = true
|
||||
deps = [
|
||||
public_deps = [
|
||||
":dawn_perf_tests",
|
||||
]
|
||||
data_deps = [
|
||||
|
|
|
@ -604,7 +604,7 @@ dawn_component("dawn_native") {
|
|||
|
||||
# Temporary group for a 3-way patch with Chromium
|
||||
group("libdawn_native_headers") {
|
||||
deps = [
|
||||
public_deps = [
|
||||
":dawn_native_headers",
|
||||
]
|
||||
}
|
||||
|
|
|
@ -96,7 +96,7 @@ dawn_component("dawn_wire") {
|
|||
|
||||
# Temporary group for a 3-way patch with Chromium
|
||||
group("libdawn_wire_headers") {
|
||||
deps = [
|
||||
public_deps = [
|
||||
":dawn_wire_headers",
|
||||
]
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue