encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Enable disabled const eval tests. 

The const evaluation of `<` has been implemented so the DISABLED const
evaluation tests can now be enabled.

Bug: tint:1581
Change-Id: I0cddad12aa637da6ae4cf8299517be723e410692
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104463
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
This commit is contained in:
dan sinclair 2022-10-04 18:35:20 +00:00 committed by Dawn LUCI CQ
parent d883c0b168
commit 82023d6980
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/tint/resolver/static_assert_test.cc
View File

@ -48,14 +48,12 @@ TEST_F(ResolverStaticAssertTest, Global_Const_Fail) {
EXPECT_EQ(r()->error(), "12:34 error: static assertion failed"); EXPECT_EQ(r()->error(), "12:34 error: static assertion failed");
} }
// TODO(crbug.com/tint/1581): Enable once the '<' operator is implemented for constant evaluation. TEST_F(ResolverStaticAssertTest, Global_LessThan_Pass) {
TEST_F(ResolverStaticAssertTest, DISABLED_Global_LessThan_Pass) {
GlobalStaticAssert(LessThan(2_i, 3_i)); GlobalStaticAssert(LessThan(2_i, 3_i));
ASSERT_TRUE(r()->Resolve()) << r()->error(); ASSERT_TRUE(r()->Resolve()) << r()->error();
} }
// TODO(crbug.com/tint/1581): Enable once the '<' operator is implemented for constant evaluation. TEST_F(ResolverStaticAssertTest, Global_LessThan_Fail) {
TEST_F(ResolverStaticAssertTest, DISABLED_Global_LessThan_Fail) {
GlobalStaticAssert(Source{{12, 34}}, LessThan(4_i, 3_i)); GlobalStaticAssert(Source{{12, 34}}, LessThan(4_i, 3_i));
EXPECT_FALSE(r()->Resolve()); EXPECT_FALSE(r()->Resolve());
EXPECT_EQ(r()->error(), "12:34 error: static assertion failed"); EXPECT_EQ(r()->error(), "12:34 error: static assertion failed");
@ -93,14 +91,12 @@ TEST_F(ResolverStaticAssertTest, Local_NonConst) {
"12:34 error: static assertion condition must be a constant expression"); "12:34 error: static assertion condition must be a constant expression");
} }
// TODO(crbug.com/tint/1581): Enable once the '<' operator is implemented for constant evaluation. TEST_F(ResolverStaticAssertTest, Local_LessThan_Pass) {
TEST_F(ResolverStaticAssertTest, DISABLED_Local_LessThan_Pass) {
WrapInFunction(StaticAssert(LessThan(2_i, 3_i))); WrapInFunction(StaticAssert(LessThan(2_i, 3_i)));
ASSERT_TRUE(r()->Resolve()) << r()->error(); ASSERT_TRUE(r()->Resolve()) << r()->error();
} }
// TODO(crbug.com/tint/1581): Enable once the '<' operator is implemented for constant evaluation. TEST_F(ResolverStaticAssertTest, Local_LessThan_Fail) {
TEST_F(ResolverStaticAssertTest, DISABLED_Local_LessThan_Fail) {
WrapInFunction(StaticAssert(Source{{12, 34}}, LessThan(4_i, 3_i))); WrapInFunction(StaticAssert(Source{{12, 34}}, LessThan(4_i, 3_i)));
EXPECT_FALSE(r()->Resolve()); EXPECT_FALSE(r()->Resolve());
EXPECT_EQ(r()->error(), "12:34 error: static assertion failed"); EXPECT_EQ(r()->error(), "12:34 error: static assertion failed");