encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-16 00:17:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

ast: Rename UnaryOp::kDereference to kIndirection

Browse Source 
This is what it is (currently) called in the spec

Bug: tint:727
Change-Id: Ie24f42499ed20c0c45ef4e9474bc6bb6a19bfa36
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/51181
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: David Neto <dneto@google.com>
This commit is contained in:
Ben Clayton
2021-05-17 14:48:37 +00:00
committed by Commit Bot service account
parent ac90829e1c
commit 85bdf1753e
14 changed files with 20 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/reader/wgsl/parser_impl.cc
View File

@@ -2325,7 +2325,7 @@ Maybe<ast::Expression*> ParserImpl::unary_expression() {
} else if (match(Token::Type::kBang)) {
op = ast::UnaryOp::kNot;
} else if (match(Token::Type::kStar)) {
op = ast::UnaryOp::kDereference;
op = ast::UnaryOp::kIndirection;
} else if (match(Token::Type::kAnd)) {
op = ast::UnaryOp::kAddressOf;
} else {

4
src/reader/wgsl/parser_impl_unary_expression_test.cc
View File

@@ -85,7 +85,7 @@ TEST_F(ParserImplTest, UnaryExpression_Dereference) {
ASSERT_TRUE(e->Is<ast::UnaryOpExpression>());
auto* u = e->As<ast::UnaryOpExpression>();
EXPECT_EQ(u->op(), ast::UnaryOp::kDereference);
EXPECT_EQ(u->op(), ast::UnaryOp::kIndirection);
EXPECT_TRUE(u->expr()->Is<ast::IdentifierExpression>());
}
@@ -113,7 +113,7 @@ TEST_F(ParserImplTest, UnaryExpression_Dereference_Precedence) {
ASSERT_TRUE(e->Is<ast::UnaryOpExpression>());
auto* u = e->As<ast::UnaryOpExpression>();
EXPECT_EQ(u->op(), ast::UnaryOp::kDereference);
EXPECT_EQ(u->op(), ast::UnaryOp::kIndirection);
EXPECT_TRUE(u->expr()->Is<ast::MemberAccessorExpression>());
}