encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

spirv-reader: disable Clspv-related test 

The grammar of the NonSemantic.ClspvReflection.1 instruction
set has changed but the corresponding feature in Clspv has not
yet landed.
Disable the Clspv-related test until upstream has settled.

Bug: tint:1789
Change-Id: I1cd9e9d15fc41338704e6e4b487cb6f099581aa0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116320
Commit-Queue: David Neto <dneto@google.com>
Reviewed-by: Alan Baker <alanbaker@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: David Neto <dneto@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
This commit is contained in:
David Neto 2023-01-04 18:40:08 +00:00 committed by Dawn LUCI CQ
parent 9b6e9313c8
commit 8937ec4e72
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/tint/reader/spirv/parser_impl_import_test.cc
View File

@ -54,7 +54,15 @@ TEST_F(SpvParserImportTest, Import_NonSemantic_IgnoredImport) {
p->DeliberatelyInvalidSpirv(); p->DeliberatelyInvalidSpirv();
} }
TEST_F(SpvParserImportTest, Import_NonSemantic_IgnoredExtInsts) { TEST_F(SpvParserImportTest, DISABLED_Import_NonSemantic_IgnoredExtInsts) {
// TODO(crbug.com/tint/1789): The NonSemantic.ClspvReflection.1 instruction
// set grammar has changed
// but the corresponding feature in Clspv has not yet landed.
// See:
// https://github.com/KhronosGroup/SPIRV-Headers/pull/308
// https://github.com/google/clspv/pull/925
// Disable this test until upstream has settled.
// This is the clspv-compiled output of this OpenCL C: // This is the clspv-compiled output of this OpenCL C:
// kernel void foo(global int*A) { A=A; } // kernel void foo(global int*A) { A=A; }
// It emits NonSemantic.ClspvReflection.1 extended instructions. // It emits NonSemantic.ClspvReflection.1 extended instructions.