tint/writer/wgsl: Emit 'f' suffix on FloatLiteralExpressions

If the literal was constructed with an 'f', make sure we print it.

Bug: tint:1504
Change-Id: I6f04e31a166919c07574db56b0a2063ce5b8ca5c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/91965
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>

src/tint/transform/canonicalize_entry_point_io_test.cc

@@ -3173,7 +3173,7 @@ fn vert_main_inner() -> vec4<f32> {
 fn vert_main() {
   let inner_result = vert_main_inner();
   value = inner_result;
-  vertex_point_size = 1.0;
+  vertex_point_size = 1.0f;
 }
 )";
 
@@ -3210,7 +3210,7 @@ fn vert_main() -> tint_symbol {
   let inner_result = vert_main_inner();
   var wrapper_result : tint_symbol;
   wrapper_result.value = inner_result;
-  wrapper_result.vertex_point_size = 1.0;
+  wrapper_result.vertex_point_size = 1.0f;
   return wrapper_result;
 }
 )";
@@ -3252,7 +3252,7 @@ fn vert_main_inner() -> VertOut {
 fn vert_main() {
   let inner_result = vert_main_inner();
   pos_1 = inner_result.pos;
-  vertex_point_size = 1.0;
+  vertex_point_size = 1.0f;
 }
 )";
 
@@ -3289,7 +3289,7 @@ fn vert_main_inner() -> VertOut {
 fn vert_main() {
   let inner_result = vert_main_inner();
   pos_1 = inner_result.pos;
-  vertex_point_size = 1.0;
+  vertex_point_size = 1.0f;
 }
 
 struct VertOut {
@@ -3338,7 +3338,7 @@ fn vert_main() -> tint_symbol {
   let inner_result = vert_main_inner();
   var wrapper_result : tint_symbol;
   wrapper_result.pos = inner_result.pos;
-  wrapper_result.vertex_point_size = 1.0;
+  wrapper_result.vertex_point_size = 1.0f;
   return wrapper_result;
 }
 )";
@@ -3380,7 +3380,7 @@ fn vert_main() -> tint_symbol {
   let inner_result = vert_main_inner();
   var wrapper_result : tint_symbol;
   wrapper_result.pos = inner_result.pos;
-  wrapper_result.vertex_point_size = 1.0;
+  wrapper_result.vertex_point_size = 1.0f;
   return wrapper_result;
 }
 
@@ -3463,7 +3463,7 @@ fn vert_main() {
   let inner_result = vert_main_inner(VertIn1(collide_2), VertIn2(collide_3));
   vertex_point_size_3 = inner_result.vertex_point_size;
   vertex_point_size_1_1 = inner_result.vertex_point_size_1;
-  vertex_point_size_4 = 1.0;
+  vertex_point_size_4 = 1.0f;
 }
 )";
 
@@ -3522,7 +3522,7 @@ fn vert_main() {
   let inner_result = vert_main_inner(VertIn1(collide_2), VertIn2(collide_3));
   vertex_point_size_3 = inner_result.vertex_point_size;
   vertex_point_size_1_1 = inner_result.vertex_point_size_1;
-  vertex_point_size_4 = 1.0;
+  vertex_point_size_4 = 1.0f;
 }
 
 struct VertIn1 {
@@ -3616,7 +3616,7 @@ fn vert_main(tint_symbol : tint_symbol_1) -> tint_symbol_2 {
   var wrapper_result : tint_symbol_2;
   wrapper_result.vertex_point_size = inner_result.vertex_point_size;
   wrapper_result.vertex_point_size_1 = inner_result.vertex_point_size_1;
-  wrapper_result.vertex_point_size_2 = 1.0;
+  wrapper_result.vertex_point_size_2 = 1.0f;
   return wrapper_result;
 }
 )";
@@ -3679,7 +3679,7 @@ fn vert_main(tint_symbol : tint_symbol_1) -> tint_symbol_2 {
   var wrapper_result : tint_symbol_2;
   wrapper_result.vertex_point_size = inner_result.vertex_point_size;
   wrapper_result.vertex_point_size_1 = inner_result.vertex_point_size_1;
-  wrapper_result.vertex_point_size_2 = 1.0;
+  wrapper_result.vertex_point_size_2 = 1.0f;
   return wrapper_result;
 }
 
@@ -3768,7 +3768,7 @@ fn vert_main(tint_symbol : tint_symbol_1) -> tint_symbol_2 {
   var wrapper_result : tint_symbol_2;
   wrapper_result.vertex_point_size = inner_result.vertex_point_size;
   wrapper_result.vertex_point_size_1 = inner_result.vertex_point_size_1;
-  wrapper_result.vertex_point_size_2 = 1.0;
+  wrapper_result.vertex_point_size_2 = 1.0f;
   return wrapper_result;
 }
 )";
@@ -3831,7 +3831,7 @@ fn vert_main(tint_symbol : tint_symbol_1) -> tint_symbol_2 {
   var wrapper_result : tint_symbol_2;
   wrapper_result.vertex_point_size = inner_result.vertex_point_size;
   wrapper_result.vertex_point_size_1 = inner_result.vertex_point_size_1;
-  wrapper_result.vertex_point_size_2 = 1.0;
+  wrapper_result.vertex_point_size_2 = 1.0f;
   return wrapper_result;
 }
 
@@ -3953,7 +3953,7 @@ fn main() {
   let inner_result = vertex_main(bitcast<u32>(gl_VertexID), bitcast<u32>(gl_InstanceID));
   gl_Position = inner_result;
   gl_Position.y = -(gl_Position.y);
-  gl_Position.z = ((2.0 * gl_Position.z) - gl_Position.w);
+  gl_Position.z = ((2.0f * gl_Position.z) - gl_Position.w);
 }
 )";
 

src/tint/transform/combine_samplers_test.cc

@@ -872,7 +872,7 @@ fn main() -> vec4<f32> {
 @group(0) @binding(0) @internal(disable_validation__binding_point_collision) var placeholder_comparison_sampler : sampler_comparison;
 
 fn f(t_s : texture_depth_2d, coords : vec2<f32>) -> f32 {
-  return textureSampleCompare(t_s, placeholder_comparison_sampler, coords, 5.0);
+  return textureSampleCompare(t_s, placeholder_comparison_sampler, coords, 5.0f);
 }
 
 @group(0) @binding(0) @internal(disable_validation__binding_point_collision) var tex_samp : texture_depth_2d;
@@ -912,7 +912,7 @@ fn main() -> vec4<f32> {
 @group(0) @binding(0) @internal(disable_validation__binding_point_collision) var placeholder_comparison_sampler : sampler_comparison;
 
 fn f(t_s : texture_depth_2d, coords : vec2<f32>) -> f32 {
-  return textureSampleCompare(t_s, placeholder_comparison_sampler, coords, 5.0);
+  return textureSampleCompare(t_s, placeholder_comparison_sampler, coords, 5.0f);
 }
 )";
 

src/tint/transform/decompose_strided_array_test.cc

@@ -374,8 +374,8 @@ struct S {
 @stage(compute) @workgroup_size(1i)
 fn f() {
   s.a = array<strided_arr, 4u>();
-  s.a = array<strided_arr, 4u>(strided_arr(1.0), strided_arr(2.0), strided_arr(3.0), strided_arr(4.0));
-  s.a[1i].el = 5.0;
+  s.a = array<strided_arr, 4u>(strided_arr(1.0f), strided_arr(2.0f), strided_arr(3.0f), strided_arr(4.0f));
+  s.a[1i].el = 5.0f;
 }
 )";
 
@@ -423,8 +423,8 @@ struct S {
 @stage(compute) @workgroup_size(1i)
 fn f() {
   s.a = array<f32, 4u>();
-  s.a = array<f32, 4u>(1.0, 2.0, 3.0, 4.0);
-  s.a[1i] = 5.0;
+  s.a = array<f32, 4u>(1.0f, 2.0f, 3.0f, 4.0f);
+  s.a[1i] = 5.0f;
 }
 )";
 
@@ -483,8 +483,8 @@ struct S {
 fn f() {
   let c = s.a;
   let d = s.a[1i].el;
-  s.a = array<strided_arr, 4u>(strided_arr(1.0), strided_arr(2.0), strided_arr(3.0), strided_arr(4.0));
-  s.a[1i].el = 5.0;
+  s.a = array<strided_arr, 4u>(strided_arr(1.0f), strided_arr(2.0f), strided_arr(3.0f), strided_arr(4.0f));
+  s.a[1i].el = 5.0f;
 }
 )";
 
@@ -546,8 +546,8 @@ fn f() {
   let a : ARR = s.a;
   let b : f32 = s.a[1i].el;
   s.a = ARR();
-  s.a = ARR(strided_arr(1.0), strided_arr(2.0), strided_arr(3.0), strided_arr(4.0));
-  s.a[1i].el = 5.0;
+  s.a = ARR(strided_arr(1.0f), strided_arr(2.0f), strided_arr(3.0f), strided_arr(4.0f));
+  s.a[1i].el = 5.0f;
 }
 )";
 
@@ -648,7 +648,7 @@ fn f() {
   let c : ARR_A = s.a[3i].el[2i];
   let d : f32 = s.a[3i].el[2i][1i].el;
   s.a = ARR_B();
-  s.a[3i].el[2i][1i].el = 5.0;
+  s.a[3i].el[2i][1i].el = 5.0f;
 }
 )";
 

src/tint/transform/decompose_strided_matrix_test.cc

@@ -376,7 +376,7 @@ fn mat2x2_stride_32_to_arr(m : mat2x2<f32>) -> @stride(32) array<vec2<f32>, 2u>
 
 @stage(compute) @workgroup_size(1i)
 fn f() {
-  s.m = mat2x2_stride_32_to_arr(mat2x2<f32>(vec2<f32>(1.0, 2.0), vec2<f32>(3.0, 4.0)));
+  s.m = mat2x2_stride_32_to_arr(mat2x2<f32>(vec2<f32>(1.0f, 2.0f), vec2<f32>(3.0f, 4.0f)));
 }
 )";
 
@@ -429,7 +429,7 @@ struct S {
 
 @stage(compute) @workgroup_size(1i)
 fn f() {
-  s.m[1i] = vec2<f32>(1.0, 2.0);
+  s.m[1i] = vec2<f32>(1.0f, 2.0f);
 }
 )";
 
@@ -505,8 +505,8 @@ fn f() {
   let x = arr_to_mat2x2_stride_32(s.m);
   let y = s.m[1i];
   let z = x[1i];
-  s.m = mat2x2_stride_32_to_arr(mat2x2<f32>(vec2<f32>(1.0, 2.0), vec2<f32>(3.0, 4.0)));
-  s.m[1i] = vec2<f32>(5.0, 6.0);
+  s.m = mat2x2_stride_32_to_arr(mat2x2<f32>(vec2<f32>(1.0f, 2.0f), vec2<f32>(3.0f, 4.0f)));
+  s.m[1i] = vec2<f32>(5.0f, 6.0f);
 }
 )";
 
@@ -613,7 +613,7 @@ var<private> s : S;
 
 @stage(compute) @workgroup_size(1i)
 fn f() {
-  s.m = mat2x2<f32>(vec2<f32>(1.0, 2.0), vec2<f32>(3.0, 4.0));
+  s.m = mat2x2<f32>(vec2<f32>(1.0f, 2.0f), vec2<f32>(3.0f, 4.0f));
 }
 )";
 

src/tint/transform/fold_constants_test.cc

@@ -41,7 +41,7 @@ var<private> a : i32 = 123i;
 
 var<private> b : u32 = 123u;
 
-var<private> c : f32 = 123.0;
+var<private> c : f32 = 123.0f;
 
 var<private> d : bool = true;
 
@@ -70,7 +70,7 @@ var<private> a : i32 = 123i;
 
 var<private> b : u32 = 123u;
 
-var<private> c : f32 = 123.0;
+var<private> c : f32 = 123.0f;
 
 var<private> d : bool = true;
 
@@ -99,7 +99,7 @@ var<private> a : i32 = 123i;
 
 var<private> b : u32 = 123u;
 
-var<private> c : f32 = 123.0;
+var<private> c : f32 = 123.0f;
 
 var<private> d : bool = true;
 
@@ -128,7 +128,7 @@ var<private> a : vec3<i32> = vec3<i32>(123i);
 
 var<private> b : vec3<u32> = vec3<u32>(123u);
 
-var<private> c : vec3<f32> = vec3<f32>(123.0);
+var<private> c : vec3<f32> = vec3<f32>(123.0f);
 
 var<private> d : vec3<bool> = vec3<bool>(true);
 
@@ -157,7 +157,7 @@ var<private> a : vec3<i32> = vec3<i32>(123i);
 
 var<private> b : vec3<u32> = vec3<u32>(123u);
 
-var<private> c : vec3<f32> = vec3<f32>(123.0);
+var<private> c : vec3<f32> = vec3<f32>(123.0f);
 
 var<private> d : vec3<bool> = vec3<bool>(true);
 
@@ -186,7 +186,7 @@ var<private> a : vec3<i32> = vec3<i32>(123i);
 
 var<private> b : vec3<u32> = vec3<u32>(123u);
 
-var<private> c : vec3<f32> = vec3<f32>(123.0);
+var<private> c : vec3<f32> = vec3<f32>(123.0f);
 
 var<private> d : vec3<bool> = vec3<bool>(true);
 
@@ -245,7 +245,7 @@ fn f() {
 fn f() {
   var a : i32 = 123i;
   var b : u32 = 123u;
-  var c : f32 = 123.0;
+  var c : f32 = 123.0f;
   var d : bool = true;
 }
 )";
@@ -269,7 +269,7 @@ fn f() {
 fn f() {
   var a : i32 = 123i;
   var b : u32 = 123u;
-  var c : f32 = 123.0;
+  var c : f32 = 123.0f;
   var d : bool = true;
 }
 )";
@@ -293,7 +293,7 @@ fn f() {
 fn f() {
   var a : i32 = 123i;
   var b : u32 = 123u;
-  var c : f32 = 123.0;
+  var c : f32 = 123.0f;
   var d : bool = true;
 }
 )";
@@ -308,7 +308,7 @@ TEST_F(FoldConstantsTest, Function_Vector_NoConversion) {
 fn f() {
   var a : vec3<i32> = vec3<i32>(123i);
   var b : vec3<u32> = vec3<u32>(123u);
-  var c : vec3<f32> = vec3<f32>(123.0);
+  var c : vec3<f32> = vec3<f32>(123.0f);
   var d : vec3<bool> = vec3<bool>(true);
 }
 )";
@@ -317,7 +317,7 @@ fn f() {
 fn f() {
   var a : vec3<i32> = vec3<i32>(123i);
   var b : vec3<u32> = vec3<u32>(123u);
-  var c : vec3<f32> = vec3<f32>(123.0);
+  var c : vec3<f32> = vec3<f32>(123.0f);
   var d : vec3<bool> = vec3<bool>(true);
 }
 )";
@@ -341,7 +341,7 @@ fn f() {
 fn f() {
   var a : vec3<i32> = vec3<i32>(123i);
   var b : vec3<u32> = vec3<u32>(123u);
-  var c : vec3<f32> = vec3<f32>(123.0);
+  var c : vec3<f32> = vec3<f32>(123.0f);
   var d : vec3<bool> = vec3<bool>(true);
 }
 )";
@@ -365,7 +365,7 @@ fn f() {
 fn f() {
   var a : vec3<i32> = vec3<i32>(123i);
   var b : vec3<u32> = vec3<u32>(123u);
-  var c : vec3<f32> = vec3<f32>(123.0);
+  var c : vec3<f32> = vec3<f32>(123.0f);
   var d : vec3<bool> = vec3<bool>(true);
 }
 )";
@@ -412,7 +412,7 @@ fn f() {
     auto* expect = R"(
 fn f() {
   var a : f32 = f32();
-  var b : vec2<f32> = vec2<f32>(1.0, a);
+  var b : vec2<f32> = vec2<f32>(1.0f, a);
 }
 )";
 

src/tint/transform/multiplanar_external_texture_test.cc

@@ -249,14 +249,14 @@ fn gammaCorrection(v : vec3<f32>, params : GammaTransferParams) -> vec3<f32> {
 fn textureSampleExternal(plane0 : texture_2d<f32>, plane1 : texture_2d<f32>, smp : sampler, coord : vec2<f32>, params : ExternalTextureParams) -> vec4<f32> {
   var color : vec3<f32>;
   if ((params.numPlanes == 1u)) {
-    color = textureSampleLevel(plane0, smp, coord, 0.0).rgb;
+    color = textureSampleLevel(plane0, smp, coord, 0.0f).rgb;
   } else {
-    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0).r, textureSampleLevel(plane1, smp, coord, 0.0).rg, 1.0) * params.yuvToRgbConversionMatrix);
+    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0f).r, textureSampleLevel(plane1, smp, coord, 0.0f).rg, 1.0f) * params.yuvToRgbConversionMatrix);
   }
   color = gammaCorrection(color, params.gammaDecodeParams);
   color = (params.gamutConversionMatrix * color);
   color = gammaCorrection(color, params.gammaEncodeParams);
-  return vec4<f32>(color, 1.0);
+  return vec4<f32>(color, 1.0f);
 }
 
 @stage(fragment)
@@ -318,14 +318,14 @@ fn gammaCorrection(v : vec3<f32>, params : GammaTransferParams) -> vec3<f32> {
 fn textureSampleExternal(plane0 : texture_2d<f32>, plane1 : texture_2d<f32>, smp : sampler, coord : vec2<f32>, params : ExternalTextureParams) -> vec4<f32> {
   var color : vec3<f32>;
   if ((params.numPlanes == 1u)) {
-    color = textureSampleLevel(plane0, smp, coord, 0.0).rgb;
+    color = textureSampleLevel(plane0, smp, coord, 0.0f).rgb;
   } else {
-    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0).r, textureSampleLevel(plane1, smp, coord, 0.0).rg, 1.0) * params.yuvToRgbConversionMatrix);
+    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0f).r, textureSampleLevel(plane1, smp, coord, 0.0f).rg, 1.0f) * params.yuvToRgbConversionMatrix);
   }
   color = gammaCorrection(color, params.gammaDecodeParams);
   color = (params.gamutConversionMatrix * color);
   color = gammaCorrection(color, params.gammaEncodeParams);
-  return vec4<f32>(color, 1.0);
+  return vec4<f32>(color, 1.0f);
 }
 
 @stage(fragment)
@@ -394,12 +394,12 @@ fn textureLoadExternal(plane0 : texture_2d<f32>, plane1 : texture_2d<f32>, coord
   if ((params.numPlanes == 1u)) {
     color = textureLoad(plane0, coord, 0i).rgb;
   } else {
-    color = (vec4<f32>(textureLoad(plane0, coord, 0i).r, textureLoad(plane1, coord, 0i).rg, 1.0) * params.yuvToRgbConversionMatrix);
+    color = (vec4<f32>(textureLoad(plane0, coord, 0i).r, textureLoad(plane1, coord, 0i).rg, 1.0f) * params.yuvToRgbConversionMatrix);
   }
   color = gammaCorrection(color, params.gammaDecodeParams);
   color = (params.gamutConversionMatrix * color);
   color = gammaCorrection(color, params.gammaEncodeParams);
-  return vec4<f32>(color, 1.0);
+  return vec4<f32>(color, 1.0f);
 }
 
 @stage(fragment)
@@ -462,12 +462,12 @@ fn textureLoadExternal(plane0 : texture_2d<f32>, plane1 : texture_2d<f32>, coord
   if ((params.numPlanes == 1u)) {
     color = textureLoad(plane0, coord, 0i).rgb;
   } else {
-    color = (vec4<f32>(textureLoad(plane0, coord, 0i).r, textureLoad(plane1, coord, 0i).rg, 1.0) * params.yuvToRgbConversionMatrix);
+    color = (vec4<f32>(textureLoad(plane0, coord, 0i).r, textureLoad(plane1, coord, 0i).rg, 1.0f) * params.yuvToRgbConversionMatrix);
   }
   color = gammaCorrection(color, params.gammaDecodeParams);
   color = (params.gamutConversionMatrix * color);
   color = gammaCorrection(color, params.gammaEncodeParams);
-  return vec4<f32>(color, 1.0);
+  return vec4<f32>(color, 1.0f);
 }
 
 @stage(fragment)
@@ -536,14 +536,14 @@ fn gammaCorrection(v : vec3<f32>, params : GammaTransferParams) -> vec3<f32> {
 fn textureSampleExternal(plane0 : texture_2d<f32>, plane1 : texture_2d<f32>, smp : sampler, coord : vec2<f32>, params : ExternalTextureParams) -> vec4<f32> {
   var color : vec3<f32>;
   if ((params.numPlanes == 1u)) {
-    color = textureSampleLevel(plane0, smp, coord, 0.0).rgb;
+    color = textureSampleLevel(plane0, smp, coord, 0.0f).rgb;
   } else {
-    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0).r, textureSampleLevel(plane1, smp, coord, 0.0).rg, 1.0) * params.yuvToRgbConversionMatrix);
+    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0f).r, textureSampleLevel(plane1, smp, coord, 0.0f).rg, 1.0f) * params.yuvToRgbConversionMatrix);
   }
   color = gammaCorrection(color, params.gammaDecodeParams);
   color = (params.gamutConversionMatrix * color);
   color = gammaCorrection(color, params.gammaEncodeParams);
-  return vec4<f32>(color, 1.0);
+  return vec4<f32>(color, 1.0f);
 }
 
 fn textureLoadExternal(plane0 : texture_2d<f32>, plane1 : texture_2d<f32>, coord : vec2<i32>, params : ExternalTextureParams) -> vec4<f32> {
@@ -551,12 +551,12 @@ fn textureLoadExternal(plane0 : texture_2d<f32>, plane1 : texture_2d<f32>, coord
   if ((params.numPlanes == 1u)) {
     color = textureLoad(plane0, coord, 0i).rgb;
   } else {
-    color = (vec4<f32>(textureLoad(plane0, coord, 0i).r, textureLoad(plane1, coord, 0i).rg, 1.0) * params.yuvToRgbConversionMatrix);
+    color = (vec4<f32>(textureLoad(plane0, coord, 0i).r, textureLoad(plane1, coord, 0i).rg, 1.0f) * params.yuvToRgbConversionMatrix);
   }
   color = gammaCorrection(color, params.gammaDecodeParams);
   color = (params.gamutConversionMatrix * color);
   color = gammaCorrection(color, params.gammaEncodeParams);
-  return vec4<f32>(color, 1.0);
+  return vec4<f32>(color, 1.0f);
 }
 
 @stage(fragment)
@@ -619,14 +619,14 @@ fn gammaCorrection(v : vec3<f32>, params : GammaTransferParams) -> vec3<f32> {
 fn textureSampleExternal(plane0 : texture_2d<f32>, plane1 : texture_2d<f32>, smp : sampler, coord : vec2<f32>, params : ExternalTextureParams) -> vec4<f32> {
   var color : vec3<f32>;
   if ((params.numPlanes == 1u)) {
-    color = textureSampleLevel(plane0, smp, coord, 0.0).rgb;
+    color = textureSampleLevel(plane0, smp, coord, 0.0f).rgb;
   } else {
-    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0).r, textureSampleLevel(plane1, smp, coord, 0.0).rg, 1.0) * params.yuvToRgbConversionMatrix);
+    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0f).r, textureSampleLevel(plane1, smp, coord, 0.0f).rg, 1.0f) * params.yuvToRgbConversionMatrix);
   }
   color = gammaCorrection(color, params.gammaDecodeParams);
   color = (params.gamutConversionMatrix * color);
   color = gammaCorrection(color, params.gammaEncodeParams);
-  return vec4<f32>(color, 1.0);
+  return vec4<f32>(color, 1.0f);
 }
 
 fn textureLoadExternal(plane0 : texture_2d<f32>, plane1 : texture_2d<f32>, coord : vec2<i32>, params : ExternalTextureParams) -> vec4<f32> {
@@ -634,12 +634,12 @@ fn textureLoadExternal(plane0 : texture_2d<f32>, plane1 : texture_2d<f32>, coord
   if ((params.numPlanes == 1u)) {
     color = textureLoad(plane0, coord, 0i).rgb;
   } else {
-    color = (vec4<f32>(textureLoad(plane0, coord, 0i).r, textureLoad(plane1, coord, 0i).rg, 1.0) * params.yuvToRgbConversionMatrix);
+    color = (vec4<f32>(textureLoad(plane0, coord, 0i).r, textureLoad(plane1, coord, 0i).rg, 1.0f) * params.yuvToRgbConversionMatrix);
   }
   color = gammaCorrection(color, params.gammaDecodeParams);
   color = (params.gamutConversionMatrix * color);
   color = gammaCorrection(color, params.gammaEncodeParams);
-  return vec4<f32>(color, 1.0);
+  return vec4<f32>(color, 1.0f);
 }
 
 @stage(fragment)
@@ -730,14 +730,14 @@ fn gammaCorrection(v : vec3<f32>, params : GammaTransferParams) -> vec3<f32> {
 fn textureSampleExternal(plane0 : texture_2d<f32>, plane1 : texture_2d<f32>, smp : sampler, coord : vec2<f32>, params : ExternalTextureParams) -> vec4<f32> {
   var color : vec3<f32>;
   if ((params.numPlanes == 1u)) {
-    color = textureSampleLevel(plane0, smp, coord, 0.0).rgb;
+    color = textureSampleLevel(plane0, smp, coord, 0.0f).rgb;
   } else {
-    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0).r, textureSampleLevel(plane1, smp, coord, 0.0).rg, 1.0) * params.yuvToRgbConversionMatrix);
+    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0f).r, textureSampleLevel(plane1, smp, coord, 0.0f).rg, 1.0f) * params.yuvToRgbConversionMatrix);
   }
   color = gammaCorrection(color, params.gammaDecodeParams);
   color = (params.gamutConversionMatrix * color);
   color = gammaCorrection(color, params.gammaEncodeParams);
-  return vec4<f32>(color, 1.0);
+  return vec4<f32>(color, 1.0f);
 }
 
 @stage(fragment)
@@ -808,14 +808,14 @@ fn gammaCorrection(v : vec3<f32>, params : GammaTransferParams) -> vec3<f32> {
 fn textureSampleExternal(plane0 : texture_2d<f32>, plane1 : texture_2d<f32>, smp : sampler, coord : vec2<f32>, params : ExternalTextureParams) -> vec4<f32> {
   var color : vec3<f32>;
   if ((params.numPlanes == 1u)) {
-    color = textureSampleLevel(plane0, smp, coord, 0.0).rgb;
+    color = textureSampleLevel(plane0, smp, coord, 0.0f).rgb;
   } else {
-    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0).r, textureSampleLevel(plane1, smp, coord, 0.0).rg, 1.0) * params.yuvToRgbConversionMatrix);
+    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0f).r, textureSampleLevel(plane1, smp, coord, 0.0f).rg, 1.0f) * params.yuvToRgbConversionMatrix);
   }
   color = gammaCorrection(color, params.gammaDecodeParams);
   color = (params.gamutConversionMatrix * color);
   color = gammaCorrection(color, params.gammaEncodeParams);
-  return vec4<f32>(color, 1.0);
+  return vec4<f32>(color, 1.0f);
 }
 
 fn f(t : texture_2d<f32>, ext_tex_plane_1_1 : texture_2d<f32>, ext_tex_params_1 : ExternalTextureParams, s : sampler) {
@@ -895,14 +895,14 @@ fn gammaCorrection(v : vec3<f32>, params : GammaTransferParams) -> vec3<f32> {
 fn textureSampleExternal(plane0 : texture_2d<f32>, plane1 : texture_2d<f32>, smp : sampler, coord : vec2<f32>, params : ExternalTextureParams) -> vec4<f32> {
   var color : vec3<f32>;
   if ((params.numPlanes == 1u)) {
-    color = textureSampleLevel(plane0, smp, coord, 0.0).rgb;
+    color = textureSampleLevel(plane0, smp, coord, 0.0f).rgb;
   } else {
-    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0).r, textureSampleLevel(plane1, smp, coord, 0.0).rg, 1.0) * params.yuvToRgbConversionMatrix);
+    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0f).r, textureSampleLevel(plane1, smp, coord, 0.0f).rg, 1.0f) * params.yuvToRgbConversionMatrix);
   }
   color = gammaCorrection(color, params.gammaDecodeParams);
   color = (params.gamutConversionMatrix * color);
   color = gammaCorrection(color, params.gammaEncodeParams);
-  return vec4<f32>(color, 1.0);
+  return vec4<f32>(color, 1.0f);
 }
 
 fn f(t : texture_2d<f32>, ext_tex_plane_1_1 : texture_2d<f32>, ext_tex_params_1 : ExternalTextureParams, s : sampler) {
@@ -972,14 +972,14 @@ fn gammaCorrection(v : vec3<f32>, params : GammaTransferParams) -> vec3<f32> {
 fn textureSampleExternal(plane0 : texture_2d<f32>, plane1 : texture_2d<f32>, smp : sampler, coord : vec2<f32>, params : ExternalTextureParams) -> vec4<f32> {
   var color : vec3<f32>;
   if ((params.numPlanes == 1u)) {
-    color = textureSampleLevel(plane0, smp, coord, 0.0).rgb;
+    color = textureSampleLevel(plane0, smp, coord, 0.0f).rgb;
   } else {
-    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0).r, textureSampleLevel(plane1, smp, coord, 0.0).rg, 1.0) * params.yuvToRgbConversionMatrix);
+    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0f).r, textureSampleLevel(plane1, smp, coord, 0.0f).rg, 1.0f) * params.yuvToRgbConversionMatrix);
   }
   color = gammaCorrection(color, params.gammaDecodeParams);
   color = (params.gamutConversionMatrix * color);
   color = gammaCorrection(color, params.gammaEncodeParams);
-  return vec4<f32>(color, 1.0);
+  return vec4<f32>(color, 1.0f);
 }
 
 fn f(s : sampler, t : texture_2d<f32>, ext_tex_plane_1_1 : texture_2d<f32>, ext_tex_params_1 : ExternalTextureParams) {
@@ -1060,14 +1060,14 @@ fn gammaCorrection(v : vec3<f32>, params : GammaTransferParams) -> vec3<f32> {
 fn textureSampleExternal(plane0 : texture_2d<f32>, plane1 : texture_2d<f32>, smp : sampler, coord : vec2<f32>, params : ExternalTextureParams) -> vec4<f32> {
   var color : vec3<f32>;
   if ((params.numPlanes == 1u)) {
-    color = textureSampleLevel(plane0, smp, coord, 0.0).rgb;
+    color = textureSampleLevel(plane0, smp, coord, 0.0f).rgb;
   } else {
-    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0).r, textureSampleLevel(plane1, smp, coord, 0.0).rg, 1.0) * params.yuvToRgbConversionMatrix);
+    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0f).r, textureSampleLevel(plane1, smp, coord, 0.0f).rg, 1.0f) * params.yuvToRgbConversionMatrix);
   }
   color = gammaCorrection(color, params.gammaDecodeParams);
   color = (params.gamutConversionMatrix * color);
   color = gammaCorrection(color, params.gammaEncodeParams);
-  return vec4<f32>(color, 1.0);
+  return vec4<f32>(color, 1.0f);
 }
 
 fn f(t : texture_2d<f32>, ext_tex_plane_1_2 : texture_2d<f32>, ext_tex_params_2 : ExternalTextureParams, s : sampler, t2 : texture_2d<f32>, ext_tex_plane_1_3 : texture_2d<f32>, ext_tex_params_3 : ExternalTextureParams) {
@@ -1158,14 +1158,14 @@ fn gammaCorrection(v : vec3<f32>, params : GammaTransferParams) -> vec3<f32> {
 fn textureSampleExternal(plane0 : texture_2d<f32>, plane1 : texture_2d<f32>, smp : sampler, coord : vec2<f32>, params : ExternalTextureParams) -> vec4<f32> {
   var color : vec3<f32>;
   if ((params.numPlanes == 1u)) {
-    color = textureSampleLevel(plane0, smp, coord, 0.0).rgb;
+    color = textureSampleLevel(plane0, smp, coord, 0.0f).rgb;
   } else {
-    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0).r, textureSampleLevel(plane1, smp, coord, 0.0).rg, 1.0) * params.yuvToRgbConversionMatrix);
+    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0f).r, textureSampleLevel(plane1, smp, coord, 0.0f).rg, 1.0f) * params.yuvToRgbConversionMatrix);
   }
   color = gammaCorrection(color, params.gammaDecodeParams);
   color = (params.gamutConversionMatrix * color);
   color = gammaCorrection(color, params.gammaEncodeParams);
-  return vec4<f32>(color, 1.0);
+  return vec4<f32>(color, 1.0f);
 }
 
 fn f(t : texture_2d<f32>, ext_tex_plane_1_2 : texture_2d<f32>, ext_tex_params_2 : ExternalTextureParams, s : sampler, t2 : texture_2d<f32>, ext_tex_plane_1_3 : texture_2d<f32>, ext_tex_params_3 : ExternalTextureParams) {
@@ -1243,14 +1243,14 @@ fn gammaCorrection(v : vec3<f32>, params : GammaTransferParams) -> vec3<f32> {
 fn textureSampleExternal(plane0 : texture_2d<f32>, plane1 : texture_2d<f32>, smp : sampler, coord : vec2<f32>, params : ExternalTextureParams) -> vec4<f32> {
   var color : vec3<f32>;
   if ((params.numPlanes == 1u)) {
-    color = textureSampleLevel(plane0, smp, coord, 0.0).rgb;
+    color = textureSampleLevel(plane0, smp, coord, 0.0f).rgb;
   } else {
-    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0).r, textureSampleLevel(plane1, smp, coord, 0.0).rg, 1.0) * params.yuvToRgbConversionMatrix);
+    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0f).r, textureSampleLevel(plane1, smp, coord, 0.0f).rg, 1.0f) * params.yuvToRgbConversionMatrix);
   }
   color = gammaCorrection(color, params.gammaDecodeParams);
   color = (params.gamutConversionMatrix * color);
   color = gammaCorrection(color, params.gammaEncodeParams);
-  return vec4<f32>(color, 1.0);
+  return vec4<f32>(color, 1.0f);
 }
 
 fn nested(t : texture_2d<f32>, ext_tex_plane_1_1 : texture_2d<f32>, ext_tex_params_1 : ExternalTextureParams, s : sampler) {
@@ -1333,14 +1333,14 @@ fn gammaCorrection(v : vec3<f32>, params : GammaTransferParams) -> vec3<f32> {
 fn textureSampleExternal(plane0 : texture_2d<f32>, plane1 : texture_2d<f32>, smp : sampler, coord : vec2<f32>, params : ExternalTextureParams) -> vec4<f32> {
   var color : vec3<f32>;
   if ((params.numPlanes == 1u)) {
-    color = textureSampleLevel(plane0, smp, coord, 0.0).rgb;
+    color = textureSampleLevel(plane0, smp, coord, 0.0f).rgb;
   } else {
-    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0).r, textureSampleLevel(plane1, smp, coord, 0.0).rg, 1.0) * params.yuvToRgbConversionMatrix);
+    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0f).r, textureSampleLevel(plane1, smp, coord, 0.0f).rg, 1.0f) * params.yuvToRgbConversionMatrix);
   }
   color = gammaCorrection(color, params.gammaDecodeParams);
   color = (params.gamutConversionMatrix * color);
   color = gammaCorrection(color, params.gammaEncodeParams);
-  return vec4<f32>(color, 1.0);
+  return vec4<f32>(color, 1.0f);
 }
 
 fn nested(t : texture_2d<f32>, ext_tex_plane_1_1 : texture_2d<f32>, ext_tex_params_1 : ExternalTextureParams, s : sampler) {
@@ -1463,14 +1463,14 @@ fn gammaCorrection(v : vec3<f32>, params : GammaTransferParams) -> vec3<f32> {
 fn textureSampleExternal(plane0 : texture_2d<f32>, plane1 : texture_2d<f32>, smp : sampler, coord : vec2<f32>, params : ExternalTextureParams) -> vec4<f32> {
   var color : vec3<f32>;
   if ((params.numPlanes == 1u)) {
-    color = textureSampleLevel(plane0, smp, coord, 0.0).rgb;
+    color = textureSampleLevel(plane0, smp, coord, 0.0f).rgb;
   } else {
-    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0).r, textureSampleLevel(plane1, smp, coord, 0.0).rg, 1.0) * params.yuvToRgbConversionMatrix);
+    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0f).r, textureSampleLevel(plane1, smp, coord, 0.0f).rg, 1.0f) * params.yuvToRgbConversionMatrix);
   }
   color = gammaCorrection(color, params.gammaDecodeParams);
   color = (params.gamutConversionMatrix * color);
   color = gammaCorrection(color, params.gammaEncodeParams);
-  return vec4<f32>(color, 1.0);
+  return vec4<f32>(color, 1.0f);
 }
 
 fn f(t : texture_2d<f32>, ext_tex_plane_1_1 : texture_2d<f32>, ext_tex_params_1 : ExternalTextureParams, s : sampler) {
@@ -1551,14 +1551,14 @@ fn gammaCorrection(v : vec3<f32>, params : GammaTransferParams) -> vec3<f32> {
 fn textureSampleExternal(plane0 : texture_2d<f32>, plane1 : texture_2d<f32>, smp : sampler, coord : vec2<f32>, params : ExternalTextureParams) -> vec4<f32> {
   var color : vec3<f32>;
   if ((params.numPlanes == 1u)) {
-    color = textureSampleLevel(plane0, smp, coord, 0.0).rgb;
+    color = textureSampleLevel(plane0, smp, coord, 0.0f).rgb;
   } else {
-    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0).r, textureSampleLevel(plane1, smp, coord, 0.0).rg, 1.0) * params.yuvToRgbConversionMatrix);
+    color = (vec4<f32>(textureSampleLevel(plane0, smp, coord, 0.0f).r, textureSampleLevel(plane1, smp, coord, 0.0f).rg, 1.0f) * params.yuvToRgbConversionMatrix);
   }
   color = gammaCorrection(color, params.gammaDecodeParams);
   color = (params.gamutConversionMatrix * color);
   color = gammaCorrection(color, params.gammaEncodeParams);
-  return vec4<f32>(color, 1.0);
+  return vec4<f32>(color, 1.0f);
 }
 
 fn f(t : texture_2d<f32>, ext_tex_plane_1_1 : texture_2d<f32>, ext_tex_params_1 : ExternalTextureParams, s : sampler) {

src/tint/transform/vertex_pulling_test.cc

@@ -1172,22 +1172,22 @@ fn main(@builtin(vertex_index) tint_pulling_vertex_index : u32) -> @builtin(posi
     uint8x4 = (((vec4<u32>(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)]) << vec4<u32>(24u, 16u, 8u, 0u)) >> vec4<u32>(24u))).xy;
     sint8x2 = (((vec2<i32>(bitcast<i32>((tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)] << 16u))) << vec2<u32>(8u, 0u)) >> vec2<u32>(24u))).x;
     sint8x4 = (((vec4<i32>(bitcast<i32>(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)])) << vec4<u32>(24u, 16u, 8u, 0u)) >> vec4<u32>(24u))).xy;
-    unorm8x2 = vec4<f32>(unpack4x8unorm((tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)] & 65535u)).xy, 0.0, 1.0);
+    unorm8x2 = vec4<f32>(unpack4x8unorm((tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)] & 65535u)).xy, 0.0f, 1.0f);
     unorm8x4 = unpack4x8unorm(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)]).x;
-    snorm8x2 = vec3<f32>(unpack4x8snorm((tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)] & 65535u)).xy, 0.0);
+    snorm8x2 = vec3<f32>(unpack4x8snorm((tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)] & 65535u)).xy, 0.0f);
     snorm8x4 = unpack4x8snorm(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)]).x;
     uint16x2 = vec3<u32>(((vec2<u32>(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)]) << vec2<u32>(16u, 0u)) >> vec2<u32>(16u)), 0u);
     uint16x4 = (((vec2<u32>(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)], tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 17u)]).xxyy << vec4<u32>(16u, 0u, 16u, 0u)) >> vec4<u32>(16u))).xy;
     sint16x2 = vec4<i32>(((vec2<i32>(bitcast<i32>(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)])) << vec2<u32>(16u, 0u)) >> vec2<u32>(16u)), 0i, 1i);
     sint16x4 = (((vec2<i32>(bitcast<i32>(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)]), bitcast<i32>(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 17u)])).xxyy << vec4<u32>(16u, 0u, 16u, 0u)) >> vec4<u32>(16u))).x;
-    unorm16x2 = vec3<f32>(unpack2x16unorm(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)]), 0.0);
+    unorm16x2 = vec3<f32>(unpack2x16unorm(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)]), 0.0f);
     unorm16x4 = vec4<f32>(unpack2x16unorm(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)]), unpack2x16unorm(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 17u)])).x;
-    snorm16x2 = vec4<f32>(unpack2x16snorm(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)]), 0.0, 1.0);
+    snorm16x2 = vec4<f32>(unpack2x16snorm(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)]), 0.0f, 1.0f);
     snorm16x4 = vec4<f32>(unpack2x16snorm(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)]), unpack2x16snorm(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 17u)])).xyz;
-    float16x2 = vec4<f32>(unpack2x16float(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)]), 0.0, 1.0);
+    float16x2 = vec4<f32>(unpack2x16float(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)]), 0.0f, 1.0f);
     float16x4 = vec4<f32>(unpack2x16float(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)]), unpack2x16float(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 17u)])).x;
-    float32 = vec4<f32>(bitcast<f32>(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)]), 0.0, 0.0, 1.0);
-    float32x2 = vec4<f32>(vec2<f32>(bitcast<f32>(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)]), bitcast<f32>(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 17u)])), 0.0, 1.0);
+    float32 = vec4<f32>(bitcast<f32>(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)]), 0.0f, 0.0f, 1.0f);
+    float32x2 = vec4<f32>(vec2<f32>(bitcast<f32>(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)]), bitcast<f32>(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 17u)])), 0.0f, 1.0f);
     float32x3 = vec3<f32>(bitcast<f32>(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)]), bitcast<f32>(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 17u)]), bitcast<f32>(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 18u)])).xy;
     float32x4 = vec4<f32>(bitcast<f32>(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)]), bitcast<f32>(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 17u)]), bitcast<f32>(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 18u)]), bitcast<f32>(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 19u)])).xyz;
     uint32 = vec3<u32>(tint_pulling_vertex_buffer_0.tint_vertex_data[(buffer_array_base_0 + 16u)], 0u, 0u);