encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tint: Resolve empty loop continuing blocks 

Otherwise, calling `Sem().Get()` on an empty loop continuing block
will return nullptr, which causes issues when inspecting the semantic
information of ast::BlockStatement nodes generically.

Change-Id: Ib3665b750c96eda02355fa879cf6300b8d69293a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89721
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
This commit is contained in:
James Price 2022-05-11 13:50:33 +00:00
parent 2cf32b13d7
commit 8e68f0aad7
2 changed files with 37 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/tint/resolver/compound_statement_test.cc
View File

@ -144,6 +144,35 @@ TEST_F(ResolverCompoundStatementTest, Loop) {
} }
} }
TEST_F(ResolverCompoundStatementTest, Loop_EmptyContinuing) {
// fn F() {
// loop {
// break;
// continuing {
// }
// }
// }
auto* brk = Break();
auto* loop = Loop(Block(brk), Block());
Func("F", {}, ty.void_(), {loop});
ASSERT_TRUE(r()->Resolve()) << r()->error();
{
auto* s = Sem().Get(loop);
ASSERT_NE(s, nullptr);
EXPECT_TRUE(s->Is<sem::LoopStatement>());
EXPECT_EQ(s->Parent(), s->FindFirstParent<sem::FunctionBlockStatement>());
EXPECT_EQ(s->Parent(), s->Block());
}
{
auto* s = Sem().Get(loop->continuing);
ASSERT_NE(s, nullptr);
EXPECT_TRUE(Is<sem::LoopContinuingBlockStatement>(s));
EXPECT_TRUE(Is<sem::LoopStatement>(s->Parent()->Parent()));
}
}
TEST_F(ResolverCompoundStatementTest, ForLoop) { TEST_F(ResolverCompoundStatementTest, ForLoop) {
// fn F() { // fn F() {
// for (var i : u32; true; i = i + 1u) { // for (var i : u32; true; i = i + 1u) {

2
src/tint/resolver/resolver.cc
View File

@ -935,7 +935,6 @@ sem::LoopStatement* Resolver::LoopStatement(const ast::LoopStatement* stmt) {
if (stmt->continuing) { if (stmt->continuing) {
Mark(stmt->continuing); Mark(stmt->continuing);
if (!stmt->continuing->Empty()) {
auto* continuing = StatementScope( auto* continuing = StatementScope(
stmt->continuing, stmt->continuing,
builder_->create<sem::LoopContinuingBlockStatement>( builder_->create<sem::LoopContinuingBlockStatement>(
@ -946,7 +945,6 @@ sem::LoopStatement* Resolver::LoopStatement(const ast::LoopStatement* stmt) {
} }
behaviors.Add(continuing->Behaviors()); behaviors.Add(continuing->Behaviors());
} }
}
if (behaviors.Contains(sem::Behavior::kBreak)) { // Does the loop exit? if (behaviors.Contains(sem::Behavior::kBreak)) { // Does the loop exit?
behaviors.Add(sem::Behavior::kNext); behaviors.Add(sem::Behavior::kNext);