Use UNREACHABLE in more places

src/backend/CommandBufferStateTracker.cpp

@@ -477,7 +477,7 @@ namespace backend {
                 case nxt::BindingType::UniformBuffer:
                 case nxt::BindingType::StorageBuffer:
                     {
-                        nxt::BufferUsageBit requiredUsage;
+                        nxt::BufferUsageBit requiredUsage = nxt::BufferUsageBit::None;
                         switch (type) {
                             case nxt::BindingType::UniformBuffer:
                                 requiredUsage = nxt::BufferUsageBit::Uniform;

src/backend/ShaderModule.cpp

@@ -43,8 +43,7 @@ namespace backend {
                 executionModel = nxt::ShaderStage::Compute;
                 break;
             default:
-                ASSERT(false);
+                UNREACHABLE();
-                break;
         }
 
         // Extract push constants

src/backend/d3d12/PipelineD3D12.cpp

@@ -92,7 +92,7 @@ namespace d3d12 {
                     compileTarget = "ps_5_1";
                     break;
                 case nxt::ShaderStage::Compute:
-                    ASSERT(false);
+                    UNREACHABLE();
                     break;
                 }
 

src/backend/d3d12/ResourceAllocator.cpp

@@ -61,7 +61,7 @@ namespace d3d12 {
                 heapProperties = &kReadbackHeapProperties;
                 break;
             default:
-                ASSERT(false);
+                UNREACHABLE();
         }
 
         ComPtr<ID3D12Resource> resource;

src/backend/metal/PipelineMTL.mm

@@ -63,8 +63,7 @@ namespace metal {
                         descriptor.fragmentFunction = function;
                         break;
                     case nxt::ShaderStage::Compute:
-                        ASSERT(false);
+                        UNREACHABLE();
-                        break;
                 }
             }
 

src/backend/opengl/OpenGLBackend.cpp

@@ -174,8 +174,7 @@ namespace opengl {
                         glVertexAttribDivisor(location, 1);
                         break;
                     default:
-                        ASSERT(false);
+                        UNREACHABLE();
-                        break;
                 }
             }
         }

src/tests/NXTTest.cpp

@@ -32,8 +32,7 @@ namespace {
             case VulkanBackend:
                 return utils::BackendType::Vulkan;
             default:
-                NXT_ASSERT(false);
+                UNREACHABLE();
-                return utils::BackendType::Null;
         }
     }
 
@@ -48,8 +47,7 @@ namespace {
             case VulkanBackend:
                 return "Vulkan";
             default:
-                NXT_ASSERT(false);
+                UNREACHABLE();
-                return "";
         }
     }