encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tint/resolver: Reduce Hashmap fixed sizes for UA 

Uniformity analysis can have very deep call stacks, and we're on the cusp of stack overflowing. Reducing these sizes helps avoid cache misses at the cost of more heap allocations.

Change-Id: I4685d1d888d062456c296d9dc25231a48d72e941
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116878
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
This commit is contained in:
Ben Clayton 2023-01-12 20:31:33 +00:00 committed by Dawn LUCI CQ
parent e11278f1c7
commit 91d39a7639
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/tint/resolver/uniformity.cc
View File

@ -240,9 +240,9 @@ struct FunctionInfo {
/// The type of this control flow construct.
std::string type;
/// The input values for local variables at the start of this construct.
utils::Hashmap<const sem::Variable*, Node*, 8> var_in_nodes;
utils::Hashmap<const sem::Variable*, Node*, 4> var_in_nodes;
/// The exit values for local variables at the end of this construct.
utils::Hashmap<const sem::Variable*, Node*, 8> var_exit_nodes;
utils::Hashmap<const sem::Variable*, Node*, 4> var_exit_nodes;
};
/// @returns a LoopSwitchInfo for the given statement, allocating the LoopSwitchInfo if this is
@ -497,7 +497,7 @@ class UniformityGraph {
},
[&](const ast::BlockStatement* b) {
utils::Hashmap<const sem::Variable*, Node*, 8> scoped_assignments;
utils::Hashmap<const sem::Variable*, Node*, 4> scoped_assignments;
{
// Push a new scope for variable assignments in the block.
current_function_->variables.Push();
@ -819,15 +819,15 @@ class UniformityGraph {
v->affects_control_flow = true;
v->AddEdge(v_cond);
utils::Hashmap<const sem::Variable*, Node*, 8> true_vars;
utils::Hashmap<const sem::Variable*, Node*, 8> false_vars;
utils::Hashmap<const sem::Variable*, Node*, 4> true_vars;
utils::Hashmap<const sem::Variable*, Node*, 4> false_vars;
// Helper to process a statement with a new scope for variable assignments.
// Populates `assigned_vars` with new nodes for any variables that are assigned in
// this statement.
auto process_in_scope =
[&](Node* cf_in, const ast::Statement* s,
utils::Hashmap<const sem::Variable*, Node*, 8>& assigned_vars) {
utils::Hashmap<const sem::Variable*, Node*, 4>& assigned_vars) {
// Push a new scope for variable assignments.
current_function_->variables.Push();

4
src/tint/scope_stack.h
View File

@ -67,7 +67,7 @@ class ScopeStack {
/// Return the top scope of the stack.
/// @returns the top scope of the stack
const utils::Hashmap<K, V, 8>& Top() const { return stack_.Back(); }
const utils::Hashmap<K, V, 4>& Top() const { return stack_.Back(); }
/// Clear the scope stack.
void Clear() {
@ -76,7 +76,7 @@ class ScopeStack {
}
private:
utils::Vector<utils::Hashmap<K, V, 8>, 8> stack_ = {{}};
utils::Vector<utils::Hashmap<K, V, 4>, 8> stack_ = {{}};
};
} // namespace tint