encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix -Wunreachable-code-break 

Bug: None

Change-Id: I2bb05b6c4f9c2ec58ffdaa9eff14fd9bf71fccf7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/18661
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
This commit is contained in:
Corentin Wallez 2020-04-02 18:09:57 +00:00 committed by Commit Bot service account
parent e8316538e3
commit 9322cc3908
7 changed files with 2 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/dawn_native/BindGroupLayout.cpp
View File

@ -48,7 +48,6 @@ namespace dawn_native {
case wgpu::BindingType::StorageTexture: { case wgpu::BindingType::StorageTexture: {
return DAWN_VALIDATION_ERROR("Read-write storage texture binding is not supported"); return DAWN_VALIDATION_ERROR("Read-write storage texture binding is not supported");
break;
} }
case wgpu::BindingType::UniformBuffer: case wgpu::BindingType::UniformBuffer:

2
src/dawn_native/CommandValidation.cpp
View File

@ -161,7 +161,6 @@ namespace dawn_native {
commands->NextCommand<EndRenderPassCmd>(); commands->NextCommand<EndRenderPassCmd>();
DAWN_TRY(ValidateFinalDebugGroupStackSize(debugGroupStackSize)); DAWN_TRY(ValidateFinalDebugGroupStackSize(debugGroupStackSize));
return {}; return {};
break;
} }
case Command::ExecuteBundles: { case Command::ExecuteBundles: {
@ -225,7 +224,6 @@ namespace dawn_native {
commands->NextCommand<EndComputePassCmd>(); commands->NextCommand<EndComputePassCmd>();
DAWN_TRY(ValidateFinalDebugGroupStackSize(debugGroupStackSize)); DAWN_TRY(ValidateFinalDebugGroupStackSize(debugGroupStackSize));
return {}; return {};
break;
} }
case Command::Dispatch: { case Command::Dispatch: {

2
src/dawn_native/d3d12/CommandBufferD3D12.cpp
View File

@ -758,7 +758,6 @@ namespace dawn_native { namespace d3d12 {
case Command::EndComputePass: { case Command::EndComputePass: {
mCommands.NextCommand<EndComputePassCmd>(); mCommands.NextCommand<EndComputePassCmd>();
return {}; return {};
break;
} }
case Command::SetComputePipeline: { case Command::SetComputePipeline: {
@ -1160,7 +1159,6 @@ namespace dawn_native { namespace d3d12 {
ResolveMultisampledRenderPass(commandContext, renderPass); ResolveMultisampledRenderPass(commandContext, renderPass);
} }
return {}; return {};
break;
} }
case Command::SetStencilReference: { case Command::SetStencilReference: {

5
src/dawn_native/d3d12/ResourceAllocatorManagerD3D12.cpp
View File

@ -98,11 +98,10 @@ namespace dawn_native { namespace d3d12 {
if ((flags & D3D12_RESOURCE_FLAG_ALLOW_DEPTH_STENCIL) || if ((flags & D3D12_RESOURCE_FLAG_ALLOW_DEPTH_STENCIL) ||
(flags & D3D12_RESOURCE_FLAG_ALLOW_RENDER_TARGET)) { (flags & D3D12_RESOURCE_FLAG_ALLOW_RENDER_TARGET)) {
return Default_OnlyRenderableOrDepthTextures; return Default_OnlyRenderableOrDepthTextures;
} else {
return Default_OnlyNonRenderableOrDepthTextures;
} }
break; return Default_OnlyNonRenderableOrDepthTextures;
} }
default: default:
UNREACHABLE(); UNREACHABLE();
} }

2
src/dawn_native/metal/CommandBufferMTL.mm
View File

@ -845,7 +845,6 @@ namespace dawn_native { namespace metal {
mCommands.NextCommand<EndComputePassCmd>(); mCommands.NextCommand<EndComputePassCmd>();
commandContext->EndCompute(); commandContext->EndCompute();
return; return;
break;
} }
case Command::Dispatch: { case Command::Dispatch: {
@ -1218,7 +1217,6 @@ namespace dawn_native { namespace metal {
mCommands.NextCommand<EndRenderPassCmd>(); mCommands.NextCommand<EndRenderPassCmd>();
commandContext->EndRender(); commandContext->EndRender();
return; return;
break;
} }
case Command::SetStencilReference: { case Command::SetStencilReference: {

2
src/dawn_native/opengl/CommandBufferGL.cpp
View File

@ -654,7 +654,6 @@ namespace dawn_native { namespace opengl {
case Command::EndComputePass: { case Command::EndComputePass: {
mCommands.NextCommand<EndComputePassCmd>(); mCommands.NextCommand<EndComputePassCmd>();
return; return;
break;
} }
case Command::Dispatch: { case Command::Dispatch: {
@ -1013,7 +1012,6 @@ namespace dawn_native { namespace opengl {
} }
gl.DeleteFramebuffers(1, &fbo); gl.DeleteFramebuffers(1, &fbo);
return; return;
break;
} }
case Command::SetStencilReference: { case Command::SetStencilReference: {

2
src/dawn_native/vulkan/CommandBufferVk.cpp
View File

@ -572,7 +572,6 @@ namespace dawn_native { namespace vulkan {
case Command::EndComputePass: { case Command::EndComputePass: {
mCommands.NextCommand<EndComputePassCmd>(); mCommands.NextCommand<EndComputePassCmd>();
return; return;
break;
} }
case Command::Dispatch: { case Command::Dispatch: {
@ -876,7 +875,6 @@ namespace dawn_native { namespace vulkan {
mCommands.NextCommand<EndRenderPassCmd>(); mCommands.NextCommand<EndRenderPassCmd>();
device->fn.CmdEndRenderPass(commands); device->fn.CmdEndRenderPass(commands);
return {}; return {};
break;
} }
case Command::SetBlendColor: { case Command::SetBlendColor: {