encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "dawn: Suppress tests that fail on ANGLE/SwiftShader" 

This reverts commit d909f2b9c5.

Reason for revert: Since https://crrev.com/c/3924863 landed in ANGLE, I was able to land https://crbug.com/dawn/104120 in Dawn, so these suppressions are no longer needed.

Original change's description:
> dawn: Suppress tests that fail on ANGLE/SwiftShader
>
> Fails roll of SwiftShader into Dawn. See crbug.com/dawn/1557 for
> details.
>
> Bug: dawn:1557
> Change-Id: Ibe97f1c3083b1fe254dd935b4abfdfbea9e34050
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104260
> Reviewed-by: Brandon Jones <bajones@chromium.org>
> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
> Kokoro: Kokoro <noreply+kokoro@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: dawn:1557
Change-Id: I86f0c33d2c737c0e6ee92fc73e2f7051c513ed10
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104501
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
This commit is contained in:
Antonio Maiorano 2022-10-03 19:51:39 +00:00 committed by Dawn LUCI CQ
parent e67c9f94d3
commit 933441b7b8
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/dawn/tests/end2end/IndexFormatTests.cpp
View File

@ -294,9 +294,6 @@ TEST_P(TriangleStripPrimitiveRestartTests, Uint32PrimitiveRestart) {
// Same as the above test, but uses an OOB index to emulate primitive restart being disabled, // Same as the above test, but uses an OOB index to emulate primitive restart being disabled,
// causing point C to be written to. // causing point C to be written to.
TEST_P(TriangleStripPrimitiveRestartTests, Uint32WithoutPrimitiveRestart) { TEST_P(TriangleStripPrimitiveRestartTests, Uint32WithoutPrimitiveRestart) {
// TODO(crbug.com/dawn/1557): Remove suppression once ANGLE bug is fixed
DAWN_SUPPRESS_TEST_IF(IsOpenGLES() && IsANGLESwiftShader());
wgpu::RenderPipeline pipeline = MakeTestPipeline(wgpu::IndexFormat::Uint32); wgpu::RenderPipeline pipeline = MakeTestPipeline(wgpu::IndexFormat::Uint32);
wgpu::Buffer indexBuffer = wgpu::Buffer indexBuffer =
utils::CreateBufferFromData<uint32_t>(device, wgpu::BufferUsage::Index, utils::CreateBufferFromData<uint32_t>(device, wgpu::BufferUsage::Index,
@ -422,9 +419,6 @@ TEST_P(LineStripPrimitiveRestartTests, Uint32PrimitiveRestart) {
// Same as the above test, but uses an OOB index to emulate primitive restart being disabled, // Same as the above test, but uses an OOB index to emulate primitive restart being disabled,
// causing point A to be written to. // causing point A to be written to.
TEST_P(LineStripPrimitiveRestartTests, Uint32WithoutPrimitiveRestart) { TEST_P(LineStripPrimitiveRestartTests, Uint32WithoutPrimitiveRestart) {
// TODO(crbug.com/dawn/1557): Remove suppression once ANGLE bug is fixed
DAWN_SUPPRESS_TEST_IF(IsOpenGLES() && IsANGLESwiftShader());
wgpu::RenderPipeline pipeline = wgpu::RenderPipeline pipeline =
MakeTestPipeline(wgpu::IndexFormat::Uint32, wgpu::PrimitiveTopology::LineStrip); MakeTestPipeline(wgpu::IndexFormat::Uint32, wgpu::PrimitiveTopology::LineStrip);