encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tint: Fix compilation error with latest MSVC 17.5.0 

Not sure if MSVC is wrong here, but it now fails to compile this file
because it looks for `builtin::AddressSpace::kPrivate` within the inner
`builtin` namespace, rather than in `tint::builtin`.

Change-Id: I10f9e1bd58e6ba548d40823f03802320865f069d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/121221
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
This commit is contained in:
Antonio Maiorano 2023-02-23 18:35:49 +00:00 committed by Dawn LUCI CQ
parent 869bcabf88
commit 9386f73446
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/tint/resolver/side_effects_test.cc
View File

@ -129,7 +129,7 @@ TEST_F(SideEffectsTest, Call_Builtin_SE) {
EXPECT_TRUE(sem->HasSideEffects()); EXPECT_TRUE(sem->HasSideEffects());
} }
namespace builtin { namespace builtin_tests {
struct Case { struct Case {
const char* name; const char* name;
utils::Vector<const char*, 3> args; utils::Vector<const char*, 3> args;
@ -368,7 +368,7 @@ INSTANTIATE_TEST_SUITE_P(
// C("saturate", utils::Vector{"f"}, false), // // C("saturate", utils::Vector{"f"}, false), //
})); }));
} // namespace builtin } // namespace builtin_tests
TEST_F(SideEffectsTest, Call_Function) { TEST_F(SideEffectsTest, Call_Function) {
Func("f", utils::Empty, ty.i32(), utils::Vector{Return(1_i)}); Func("f", utils::Empty, ty.i32(), utils::Vector{Return(1_i)});