Remove depreated APIs and WGSL

WGSL:
* Remove vertex_idx and instance_idx.
  These are now vertex_index and instance_index.
  It seems this was removed once before, then reverted due to CTS
  failures, but the original change never landed again.
* Remove the [[set(n)]] decoration. This has been [[group(n)]] for
  months now.

API:
* Remove deprecated enums from transform::VertexFormat.
* Remove transform::Renamer constructor that takes a Config. This should
  be passed by DataMap.
* Remove ast::AccessControl alias to ast::Access.

Change-Id: I988c96c4269b02a5d77163409f261fd5923188e0
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/56541
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: James Price <jrprice@google.com>

src/resolver/resolver.cc

@@ -595,7 +595,7 @@ Resolver::VariableInfo* Resolver::Variable(ast::Variable* var,
   return info;
 }
 
-ast::AccessControl Resolver::DefaultAccessForStorageClass(
+ast::Access Resolver::DefaultAccessForStorageClass(
     ast::StorageClass storage_class) {
   // https://gpuweb.github.io/gpuweb/wgsl/#storage-class
   switch (storage_class) {

src/resolver/resolver.h

@@ -363,8 +363,7 @@ class Resolver {
 
   /// @param storage_class the storage class
   /// @returns the default access control for the given storage class
-  ast::AccessControl DefaultAccessForStorageClass(
-      ast::StorageClass storage_class);
+  ast::Access DefaultAccessForStorageClass(ast::StorageClass storage_class);
 
   /// @returns the resolved type of the ast::Expression `expr`
   /// @param expr the expression

src/resolver/storage_class_validation_test.cc

@@ -153,7 +153,7 @@ TEST_F(ResolverStorageClassValidationTest, StorageBufferNoError_Aliases) {
 
 TEST_F(ResolverStorageClassValidationTest, UniformBuffer_Struct_Runtime) {
   // [[block]] struct S { m:  array<f32>; };
-  // [[set(0), binding(0)]] var<uniform, > svar : S;
+  // [[group(0), binding(0)]] var<uniform, > svar : S;
 
   auto* s = Structure(Source{{12, 34}}, "S", {Member("m", ty.array<i32>())},
                       {create<ast::StructBlockDecoration>()});