encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-12 14:46:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix FXC compile errors on modulo by zero

Browse Source 
Just like for divide, FXC fails with the exact same error when
performing a modulo on a value that FXC determines to be zero. We
address it in the same way as we do for divide.

This also fixes a couple of the vk-gl-cts tests for which I manually
generated expectation files for.

Bug: tint:1083
Change-Id: Ia388bf002112afded542adb791d37e88e35a77ff
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/74220
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
This commit is contained in:
Antonio Maiorano
2021-12-22 15:02:09 +00:00
committed by Tint LUCI CQ
parent cc4d97b6e3
commit 9943de6813
159 changed files with 1965 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/expressions/binary/mod_by_zero/by_expression/vec3-scalar/i32.wgsl Normal file
View File

@@ -0,0 +1,6 @@
[[stage(compute), workgroup_size(1)]]
fn f() {
var a = vec3<i32>(1, 2, 3);
var b = 0;
let r : vec3<i32> = a % (b + b);
}

11
test/expressions/binary/mod_by_zero/by_expression/vec3-scalar/i32.wgsl.expected.hlsl Normal file
View File

@@ -0,0 +1,11 @@
int value_or_one_if_zero_int(int value) {
return value == 0 ? 1 : value;
}
[numthreads(1, 1, 1)]
void f() {
int3 a = int3(1, 2, 3);
int b = 0;
const int3 r = (a % value_or_one_if_zero_int((b + b)));
return;
}

10
test/expressions/binary/mod_by_zero/by_expression/vec3-scalar/i32.wgsl.expected.msl Normal file
View File

@@ -0,0 +1,10 @@
#include <metal_stdlib>
using namespace metal;
kernel void f() {
int3 a = int3(1, 2, 3);
int b = 0;
int3 const r = (a % as_type<int>((as_type<uint>(b) + as_type<uint>(b))));
return;
}

40
test/expressions/binary/mod_by_zero/by_expression/vec3-scalar/i32.wgsl.expected.spvasm Normal file
View File

@@ -0,0 +1,40 @@
; SPIR-V
; Version: 1.3
; Generator: Google Tint Compiler; 0
; Bound: 25
; Schema: 0
OpCapability Shader
OpMemoryModel Logical GLSL450
OpEntryPoint GLCompute %f "f"
OpExecutionMode %f LocalSize 1 1 1
OpName %f "f"
OpName %a "a"
OpName %b "b"
%void = OpTypeVoid
%1 = OpTypeFunction %void
%int = OpTypeInt 32 1
%v3int = OpTypeVector %int 3
%int_1 = OpConstant %int 1
%int_2 = OpConstant %int 2
%int_3 = OpConstant %int 3
%10 = OpConstantComposite %v3int %int_1 %int_2 %int_3
%_ptr_Function_v3int = OpTypePointer Function %v3int
%13 = OpConstantNull %v3int
%int_0 = OpConstant %int 0
%_ptr_Function_int = OpTypePointer Function %int
%17 = OpConstantNull %int
%f = OpFunction %void None %1
%4 = OpLabel
%a = OpVariable %_ptr_Function_v3int Function %13
%b = OpVariable %_ptr_Function_int Function %17
%23 = OpVariable %_ptr_Function_v3int Function %13
OpStore %a %10
OpStore %b %int_0
%18 = OpLoad %v3int %a
%19 = OpLoad %int %b
%20 = OpLoad %int %b
%21 = OpIAdd %int %19 %20
%24 = OpCompositeConstruct %v3int %21 %21 %21
%22 = OpSMod %v3int %18 %24
OpReturn
OpFunctionEnd

6
test/expressions/binary/mod_by_zero/by_expression/vec3-scalar/i32.wgsl.expected.wgsl Normal file
View File

@@ -0,0 +1,6 @@
[[stage(compute), workgroup_size(1)]]
fn f() {
var a = vec3<i32>(1, 2, 3);
var b = 0;
let r : vec3<i32> = (a % (b + b));
}

6
test/expressions/binary/mod_by_zero/by_expression/vec3-scalar/u32.wgsl Normal file
View File

@@ -0,0 +1,6 @@
[[stage(compute), workgroup_size(1)]]
fn f() {
var a = vec3<u32>(1u, 2u, 3u);
var b = 0u;
let r : vec3<u32> = a % (b + b);
}

11
test/expressions/binary/mod_by_zero/by_expression/vec3-scalar/u32.wgsl.expected.hlsl Normal file
View File

@@ -0,0 +1,11 @@
uint value_or_one_if_zero_uint(uint value) {
return value == 0u ? 1u : value;
}
[numthreads(1, 1, 1)]
void f() {
uint3 a = uint3(1u, 2u, 3u);
uint b = 0u;
const uint3 r = (a % value_or_one_if_zero_uint((b + b)));
return;
}

10
test/expressions/binary/mod_by_zero/by_expression/vec3-scalar/u32.wgsl.expected.msl Normal file
View File

@@ -0,0 +1,10 @@
#include <metal_stdlib>
using namespace metal;
kernel void f() {
uint3 a = uint3(1u, 2u, 3u);
uint b = 0u;
uint3 const r = (a % (b + b));
return;
}

40
test/expressions/binary/mod_by_zero/by_expression/vec3-scalar/u32.wgsl.expected.spvasm Normal file
View File

@@ -0,0 +1,40 @@
; SPIR-V
; Version: 1.3
; Generator: Google Tint Compiler; 0
; Bound: 25
; Schema: 0
OpCapability Shader
OpMemoryModel Logical GLSL450
OpEntryPoint GLCompute %f "f"
OpExecutionMode %f LocalSize 1 1 1
OpName %f "f"
OpName %a "a"
OpName %b "b"
%void = OpTypeVoid
%1 = OpTypeFunction %void
%uint = OpTypeInt 32 0
%v3uint = OpTypeVector %uint 3
%uint_1 = OpConstant %uint 1
%uint_2 = OpConstant %uint 2
%uint_3 = OpConstant %uint 3
%10 = OpConstantComposite %v3uint %uint_1 %uint_2 %uint_3
%_ptr_Function_v3uint = OpTypePointer Function %v3uint
%13 = OpConstantNull %v3uint
%uint_0 = OpConstant %uint 0
%_ptr_Function_uint = OpTypePointer Function %uint
%17 = OpConstantNull %uint
%f = OpFunction %void None %1
%4 = OpLabel
%a = OpVariable %_ptr_Function_v3uint Function %13
%b = OpVariable %_ptr_Function_uint Function %17
%23 = OpVariable %_ptr_Function_v3uint Function %13
OpStore %a %10
OpStore %b %uint_0
%18 = OpLoad %v3uint %a
%19 = OpLoad %uint %b
%20 = OpLoad %uint %b
%21 = OpIAdd %uint %19 %20
%24 = OpCompositeConstruct %v3uint %21 %21 %21
%22 = OpUMod %v3uint %18 %24
OpReturn
OpFunctionEnd

6
test/expressions/binary/mod_by_zero/by_expression/vec3-scalar/u32.wgsl.expected.wgsl Normal file
View File

@@ -0,0 +1,6 @@
[[stage(compute), workgroup_size(1)]]
fn f() {
var a = vec3<u32>(1u, 2u, 3u);
var b = 0u;
let r : vec3<u32> = (a % (b + b));
}