encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update parser comments. 

This CL updates a few parser comments to match spec.

Bug: tint:1633
Change-Id: I8cde5ea9a85f0ca58b914d2741ad131d1fa374c6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99700
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
This commit is contained in:
dan sinclair 2022-08-19 22:07:23 +00:00 committed by Dawn LUCI CQ
parent d0ccb1aae6
commit 9d27ab7043
1 changed files with 17 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/tint/reader/wgsl/parser_impl.cc
View File

@ -1533,7 +1533,7 @@ Expect<ParserImpl::ParameterList> ParserImpl::expect_param_list() {
} }
// param // param
// : attribute_list* ident_with_type_decl // : attribute_list* ident COLON type_decl
Expect<ast::Parameter*> ParserImpl::expect_param() { Expect<ast::Parameter*> ParserImpl::expect_param() {
auto attrs = attribute_list(); auto attrs = attribute_list();
@ -2563,20 +2563,6 @@ Maybe<const ast::Expression*> ParserImpl::postfix_expression(const ast::Expressi
return Failure::kErrored; return Failure::kErrored;
} }
// singular_expression
// : primary_expression postfix_expr
Maybe<const ast::Expression*> ParserImpl::singular_expression() {
auto prefix = primary_expression();
if (prefix.errored) {
return Failure::kErrored;
}
if (!prefix.matched) {
return Failure::kNoMatch;
}
return postfix_expression(prefix.value);
}
// argument_expression_list // argument_expression_list
// : PAREN_LEFT ((expression COMMA)* expression COMMA?)? PAREN_RIGHT // : PAREN_LEFT ((expression COMMA)* expression COMMA?)? PAREN_RIGHT
Expect<ParserImpl::ExpressionList> ParserImpl::expect_argument_expression_list( Expect<ParserImpl::ExpressionList> ParserImpl::expect_argument_expression_list(
@ -2814,6 +2800,20 @@ Maybe<const ast::Expression*> ParserImpl::element_count_expression() {
return math.value; return math.value;
} }
// singular_expression
// : primary_expression postfix_expr
Maybe<const ast::Expression*> ParserImpl::singular_expression() {
auto prefix = primary_expression();
if (prefix.errored) {
return Failure::kErrored;
}
if (!prefix.matched) {
return Failure::kNoMatch;
}
return postfix_expression(prefix.value);
}
// unary_expression // unary_expression
// : singular_expression // : singular_expression
// | MINUS unary_expression // | MINUS unary_expression
@ -2821,6 +2821,8 @@ Maybe<const ast::Expression*> ParserImpl::element_count_expression() {
// | TILDE unary_expression // | TILDE unary_expression
// | STAR unary_expression // | STAR unary_expression
// | AND unary_expression // | AND unary_expression
//
// The `primary_expression postfix_expression ?` is moved out into a `singular_expression`
Maybe<const ast::Expression*> ParserImpl::unary_expression() { Maybe<const ast::Expression*> ParserImpl::unary_expression() {
auto& t = peek(); auto& t = peek();