encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix build/include lint in samples/ 

This CL updates the SampleUtils file to use the full path to the header.
This required adding the root path into the include directories for the
sample utils project in CMake.

Bug: dawn:1339
Change-Id: If6abb18a2eefa19ee56b6f889080da67f4a953e3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86211
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
This commit is contained in:
dan sinclair 2022-04-11 14:46:11 +00:00 committed by Dawn LUCI CQ
parent a7230f06ff
commit a3b3b43162
3 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
samples/dawn/CMakeLists.txt
View File

@ -14,6 +14,7 @@
add_library(dawn_sample_utils STATIC ${DAWN_DUMMY_FILE}) add_library(dawn_sample_utils STATIC ${DAWN_DUMMY_FILE})
common_compile_options(dawn_sample_utils) common_compile_options(dawn_sample_utils)
target_include_directories(dawn_sample_utils PRIVATE ${PROJECT_SOURCE_DIR})
target_sources(dawn_sample_utils PRIVATE target_sources(dawn_sample_utils PRIVATE
"SampleUtils.cpp" "SampleUtils.cpp"
"SampleUtils.h" "SampleUtils.h"

1
samples/dawn/CPPLINT.cfg
View File

@ -1,5 +1,4 @@
filter=-build/header_guard filter=-build/header_guard
filter=-build/include
filter=-build/include_order filter=-build/include_order
filter=-build/include_what_you_use filter=-build/include_what_you_use
filter=-readability/casting filter=-readability/casting

2
samples/dawn/SampleUtils.cpp
View File

@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and // See the License for the specific language governing permissions and
// limitations under the License. // limitations under the License.
#include "SampleUtils.h" #include "samples/dawn/SampleUtils.h"
#include "GLFW/glfw3.h" #include "GLFW/glfw3.h"
#include "dawn/common/Assert.h" #include "dawn/common/Assert.h"