encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-16 00:17:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tint: Fix extractBits polyfill

Browse Source 
This CL fix the extractBits polyfill, used for D3D12 backend on windows.
With this patch the related CTS would get pass.

Fixed: tint:1775
Change-Id: I15636bb55af502fff773c19f03b4c3c9e99b63fd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112207
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Zhaoming Jiang <zhaoming.jiang@intel.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
This commit is contained in:
Zhaoming Jiang
2022-11-30 23:55:28 +00:00
committed by Dawn LUCI CQ
parent 2e30a374d7
commit a54df5eca5
27 changed files with 68 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
test/tint/builtins/extractBits/scalar/i32.spvasm.expected.dxc.hlsl
View File

@@ -3,7 +3,8 @@ int tint_extract_bits(int v, uint offset, uint count) {
const uint e = min(32u, (s + count));
const uint shl = (32u - e);
const uint shr = (shl + s);
return ((v << shl) >> shr);
const int shl_result = ((shl < 32u) ? (v << shl) : 0);
return ((shr < 32u) ? (shl_result >> shr) : ((shl_result >> 31u) >> 1u));
}
void f_1() {

3
test/tint/builtins/extractBits/scalar/i32.spvasm.expected.fxc.hlsl
View File

@@ -3,7 +3,8 @@ int tint_extract_bits(int v, uint offset, uint count) {
const uint e = min(32u, (s + count));
const uint shl = (32u - e);
const uint shr = (shl + s);
return ((v << shl) >> shr);
const int shl_result = ((shl < 32u) ? (v << shl) : 0);
return ((shr < 32u) ? (shl_result >> shr) : ((shl_result >> 31u) >> 1u));
}
void f_1() {

3
test/tint/builtins/extractBits/scalar/u32.spvasm.expected.dxc.hlsl
View File

@@ -3,7 +3,8 @@ uint tint_extract_bits(uint v, uint offset, uint count) {
const uint e = min(32u, (s + count));
const uint shl = (32u - e);
const uint shr = (shl + s);
return ((v << shl) >> shr);
const uint shl_result = ((shl < 32u) ? (v << shl) : 0u);
return ((shr < 32u) ? (shl_result >> shr) : ((shl_result >> 31u) >> 1u));
}
void f_1() {

3
test/tint/builtins/extractBits/scalar/u32.spvasm.expected.fxc.hlsl
View File

@@ -3,7 +3,8 @@ uint tint_extract_bits(uint v, uint offset, uint count) {
const uint e = min(32u, (s + count));
const uint shl = (32u - e);
const uint shr = (shl + s);
return ((v << shl) >> shr);
const uint shl_result = ((shl < 32u) ? (v << shl) : 0u);
return ((shr < 32u) ? (shl_result >> shr) : ((shl_result >> 31u) >> 1u));
}
void f_1() {