encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add a defaulted ExternalTextureBase destructor. 

Without this, users of ExternalTextureBase will try to instantiate the
default destructor, which will cause a call to ~Ref<BufferBase> which
will fail when Buffer.h isn't included.

Fixes the roll of Dawn in google3.

Bug: None
Change-Id: Ib88d4338033468779f416973e5808910eb4ef110
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/78721
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
This commit is contained in:
Corentin Wallez 2022-01-31 12:20:04 +00:00 committed by Dawn LUCI CQ
parent 808e6cf12d
commit abd099c063
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/dawn_native/ExternalTexture.cpp
View File

@ -119,6 +119,8 @@ namespace dawn::native {
: ApiObjectBase(device, tag) { : ApiObjectBase(device, tag) {
} }
ExternalTextureBase::~ExternalTextureBase() = default;
MaybeError ExternalTextureBase::Initialize(DeviceBase* device, MaybeError ExternalTextureBase::Initialize(DeviceBase* device,
const ExternalTextureDescriptor* descriptor) { const ExternalTextureDescriptor* descriptor) {
// Store any passed in TextureViews associated with individual planes. // Store any passed in TextureViews associated with individual planes.

2
src/dawn_native/ExternalTexture.h
View File

@ -58,6 +58,8 @@ namespace dawn::native {
ExternalTextureBase(DeviceBase* device); ExternalTextureBase(DeviceBase* device);
void DestroyImpl() override; void DestroyImpl() override;
~ExternalTextureBase() override;
private: private:
enum class ExternalTextureState { Alive, Destroyed }; enum class ExternalTextureState { Alive, Destroyed };
ExternalTextureBase(DeviceBase* device, const ExternalTextureDescriptor* descriptor); ExternalTextureBase(DeviceBase* device, const ExternalTextureDescriptor* descriptor);