encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-21 10:49:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace Literal::(Is|As)* with Castable

Browse Source 
Change-Id: I842483890b369d63c23dba475b6738bffe5cfdbd
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34319
Reviewed-by: dan sinclair <dsinclair@chromium.org>
This commit is contained in:
Ben Clayton
2020-11-30 23:30:58 +00:00
parent aedca4288c
commit acf7643518
45 changed files with 250 additions and 359 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/reader/wgsl/parser_impl.cc
View File

@@ -1753,10 +1753,10 @@ Expect<ast::CaseSelectorList> ParserImpl::expect_case_selectors() {
return Failure::kErrored;
if (!cond.matched)
break;
if (!cond->IsInt())
if (!cond->Is<ast::IntLiteral>())
return add_error(t, "invalid case selector must be an integer value");
selectors.push_back(cond.value->AsInt());
selectors.push_back(cond.value->As<ast::IntLiteral>());
}
if (selectors.empty())

8
src/reader/wgsl/parser_impl_additive_expression_test.cc
View File

@@ -44,8 +44,8 @@ TEST_F(ParserImplTest, AdditiveExpression_Parses_Plus) {
ASSERT_TRUE(rel->rhs()->Is<ast::ConstructorExpression>());
ASSERT_TRUE(rel->rhs()->Is<ast::ScalarConstructorExpression>());
auto* init = rel->rhs()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsBool());
ASSERT_TRUE(init->literal()->AsBool()->IsTrue());
ASSERT_TRUE(init->literal()->Is<ast::BoolLiteral>());
ASSERT_TRUE(init->literal()->As<ast::BoolLiteral>()->IsTrue());
}
TEST_F(ParserImplTest, AdditiveExpression_Parses_Minus) {
@@ -67,8 +67,8 @@ TEST_F(ParserImplTest, AdditiveExpression_Parses_Minus) {
ASSERT_TRUE(rel->rhs()->Is<ast::ConstructorExpression>());
ASSERT_TRUE(rel->rhs()->Is<ast::ScalarConstructorExpression>());
auto* init = rel->rhs()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsBool());
ASSERT_TRUE(init->literal()->AsBool()->IsTrue());
ASSERT_TRUE(init->literal()->Is<ast::BoolLiteral>());
ASSERT_TRUE(init->literal()->As<ast::BoolLiteral>()->IsTrue());
}
TEST_F(ParserImplTest, AdditiveExpression_InvalidLHS) {

4
src/reader/wgsl/parser_impl_and_expression_test.cc
View File

@@ -44,8 +44,8 @@ TEST_F(ParserImplTest, AndExpression_Parses) {
ASSERT_TRUE(rel->rhs()->Is<ast::ConstructorExpression>());
ASSERT_TRUE(rel->rhs()->Is<ast::ScalarConstructorExpression>());
auto* init = rel->rhs()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsBool());
ASSERT_TRUE(init->literal()->AsBool()->IsTrue());
ASSERT_TRUE(init->literal()->Is<ast::BoolLiteral>());
ASSERT_TRUE(init->literal()->As<ast::BoolLiteral>()->IsTrue());
}
TEST_F(ParserImplTest, AndExpression_InvalidLHS) {

12
src/reader/wgsl/parser_impl_assignment_stmt_test.cc
View File

@@ -49,8 +49,8 @@ TEST_F(ParserImplTest, AssignmentStmt_Parses_ToVariable) {
auto* init = e->rhs()->As<ast::ScalarConstructorExpression>();
ASSERT_NE(init->literal(), nullptr);
ASSERT_TRUE(init->literal()->IsSint());
EXPECT_EQ(init->literal()->AsSint()->value(), 123);
ASSERT_TRUE(init->literal()->Is<ast::SintLiteral>());
EXPECT_EQ(init->literal()->As<ast::SintLiteral>()->value(), 123);
}
TEST_F(ParserImplTest, AssignmentStmt_Parses_ToMember) {
@@ -69,8 +69,8 @@ TEST_F(ParserImplTest, AssignmentStmt_Parses_ToMember) {
ASSERT_TRUE(e->rhs()->Is<ast::ScalarConstructorExpression>());
auto* init = e->rhs()->As<ast::ScalarConstructorExpression>();
ASSERT_NE(init->literal(), nullptr);
ASSERT_TRUE(init->literal()->IsSint());
EXPECT_EQ(init->literal()->AsSint()->value(), 123);
ASSERT_TRUE(init->literal()->Is<ast::SintLiteral>());
EXPECT_EQ(init->literal()->As<ast::SintLiteral>()->value(), 123);
ASSERT_TRUE(e->lhs()->Is<ast::MemberAccessorExpression>());
auto* mem = e->lhs()->As<ast::MemberAccessorExpression>();
@@ -86,8 +86,8 @@ TEST_F(ParserImplTest, AssignmentStmt_Parses_ToMember) {
ASSERT_TRUE(ary->idx_expr()->Is<ast::ScalarConstructorExpression>());
init = ary->idx_expr()->As<ast::ScalarConstructorExpression>();
ASSERT_NE(init->literal(), nullptr);
ASSERT_TRUE(init->literal()->IsSint());
EXPECT_EQ(init->literal()->AsSint()->value(), 2);
ASSERT_TRUE(init->literal()->Is<ast::SintLiteral>());
EXPECT_EQ(init->literal()->As<ast::SintLiteral>()->value(), 2);
ASSERT_TRUE(ary->array()->Is<ast::MemberAccessorExpression>());
mem = ary->array()->As<ast::MemberAccessorExpression>();

12
src/reader/wgsl/parser_impl_const_expr_test.cc
View File

@@ -44,14 +44,14 @@ TEST_F(ParserImplTest, ConstExpr_TypeDecl) {
ASSERT_TRUE(v[0]->Is<ast::ConstructorExpression>());
ASSERT_TRUE(v[0]->Is<ast::ScalarConstructorExpression>());
auto* c = v[0]->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(c->literal()->IsFloat());
EXPECT_FLOAT_EQ(c->literal()->AsFloat()->value(), 1.);
ASSERT_TRUE(c->literal()->Is<ast::FloatLiteral>());
EXPECT_FLOAT_EQ(c->literal()->As<ast::FloatLiteral>()->value(), 1.);
ASSERT_TRUE(v[1]->Is<ast::ConstructorExpression>());
ASSERT_TRUE(v[1]->Is<ast::ScalarConstructorExpression>());
c = v[1]->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(c->literal()->IsFloat());
EXPECT_FLOAT_EQ(c->literal()->AsFloat()->value(), 2.);
ASSERT_TRUE(c->literal()->Is<ast::FloatLiteral>());
EXPECT_FLOAT_EQ(c->literal()->As<ast::FloatLiteral>()->value(), 2.);
}
TEST_F(ParserImplTest, ConstExpr_TypeDecl_MissingRightParen) {
@@ -117,8 +117,8 @@ TEST_F(ParserImplTest, ConstExpr_ConstLiteral) {
ASSERT_TRUE(e->Is<ast::ConstructorExpression>());
ASSERT_TRUE(e->Is<ast::ScalarConstructorExpression>());
auto* c = e->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(c->literal()->IsBool());
EXPECT_TRUE(c->literal()->AsBool()->IsTrue());
ASSERT_TRUE(c->literal()->Is<ast::BoolLiteral>());
EXPECT_TRUE(c->literal()->As<ast::BoolLiteral>()->IsTrue());
}
TEST_F(ParserImplTest, ConstExpr_ConstLiteral_Invalid) {

20
src/reader/wgsl/parser_impl_const_literal_test.cc
View File

@@ -32,8 +32,8 @@ TEST_F(ParserImplTest, ConstLiteral_Int) {
EXPECT_FALSE(c.errored);
EXPECT_FALSE(p->has_error());
ASSERT_NE(c.value, nullptr);
ASSERT_TRUE(c->IsSint());
EXPECT_EQ(c->AsSint()->value(), -234);
ASSERT_TRUE(c->Is<ast::SintLiteral>());
EXPECT_EQ(c->As<ast::SintLiteral>()->value(), -234);
}
TEST_F(ParserImplTest, ConstLiteral_Uint) {
@@ -43,8 +43,8 @@ TEST_F(ParserImplTest, ConstLiteral_Uint) {
EXPECT_FALSE(c.errored);
EXPECT_FALSE(p->has_error());
ASSERT_NE(c.value, nullptr);
ASSERT_TRUE(c->IsUint());
EXPECT_EQ(c->AsUint()->value(), 234u);
ASSERT_TRUE(c->Is<ast::UintLiteral>());
EXPECT_EQ(c->As<ast::UintLiteral>()->value(), 234u);
}
TEST_F(ParserImplTest, ConstLiteral_Float) {
@@ -54,8 +54,8 @@ TEST_F(ParserImplTest, ConstLiteral_Float) {
EXPECT_FALSE(c.errored);
EXPECT_FALSE(p->has_error());
ASSERT_NE(c.value, nullptr);
ASSERT_TRUE(c->IsFloat());
EXPECT_FLOAT_EQ(c->AsFloat()->value(), 234e12f);
ASSERT_TRUE(c->Is<ast::FloatLiteral>());
EXPECT_FLOAT_EQ(c->As<ast::FloatLiteral>()->value(), 234e12f);
}
TEST_F(ParserImplTest, ConstLiteral_InvalidFloat) {
@@ -73,8 +73,8 @@ TEST_F(ParserImplTest, ConstLiteral_True) {
EXPECT_FALSE(c.errored);
EXPECT_FALSE(p->has_error());
ASSERT_NE(c.value, nullptr);
ASSERT_TRUE(c->IsBool());
EXPECT_TRUE(c->AsBool()->IsTrue());
ASSERT_TRUE(c->Is<ast::BoolLiteral>());
EXPECT_TRUE(c->As<ast::BoolLiteral>()->IsTrue());
}
TEST_F(ParserImplTest, ConstLiteral_False) {
@@ -84,8 +84,8 @@ TEST_F(ParserImplTest, ConstLiteral_False) {
EXPECT_FALSE(c.errored);
EXPECT_FALSE(p->has_error());
ASSERT_NE(c.value, nullptr);
ASSERT_TRUE(c->IsBool());
EXPECT_TRUE(c->AsBool()->IsFalse());
ASSERT_TRUE(c->Is<ast::BoolLiteral>());
EXPECT_TRUE(c->As<ast::BoolLiteral>()->IsFalse());
}
TEST_F(ParserImplTest, ConstLiteral_NoMatch) {

8
src/reader/wgsl/parser_impl_equality_expression_test.cc
View File

@@ -44,8 +44,8 @@ TEST_F(ParserImplTest, EqualityExpression_Parses_Equal) {
ASSERT_TRUE(rel->rhs()->Is<ast::ConstructorExpression>());
ASSERT_TRUE(rel->rhs()->Is<ast::ScalarConstructorExpression>());
auto* init = rel->rhs()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsBool());
ASSERT_TRUE(init->literal()->AsBool()->IsTrue());
ASSERT_TRUE(init->literal()->Is<ast::BoolLiteral>());
ASSERT_TRUE(init->literal()->As<ast::BoolLiteral>()->IsTrue());
}
TEST_F(ParserImplTest, EqualityExpression_Parses_NotEqual) {
@@ -67,8 +67,8 @@ TEST_F(ParserImplTest, EqualityExpression_Parses_NotEqual) {
ASSERT_TRUE(rel->rhs()->Is<ast::ConstructorExpression>());
ASSERT_TRUE(rel->rhs()->Is<ast::ScalarConstructorExpression>());
auto* init = rel->rhs()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsBool());
ASSERT_TRUE(init->literal()->AsBool()->IsTrue());
ASSERT_TRUE(init->literal()->Is<ast::BoolLiteral>());
ASSERT_TRUE(init->literal()->As<ast::BoolLiteral>()->IsTrue());
}
TEST_F(ParserImplTest, EqualityExpression_InvalidLHS) {

4
src/reader/wgsl/parser_impl_exclusive_or_expression_test.cc
View File

@@ -44,8 +44,8 @@ TEST_F(ParserImplTest, ExclusiveOrExpression_Parses) {
ASSERT_TRUE(rel->rhs()->Is<ast::ConstructorExpression>());
ASSERT_TRUE(rel->rhs()->Is<ast::ScalarConstructorExpression>());
auto* init = rel->rhs()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsBool());
ASSERT_TRUE(init->literal()->AsBool()->IsTrue());
ASSERT_TRUE(init->literal()->Is<ast::BoolLiteral>());
ASSERT_TRUE(init->literal()->As<ast::BoolLiteral>()->IsTrue());
}
TEST_F(ParserImplTest, ExclusiveOrExpression_InvalidLHS) {

4
src/reader/wgsl/parser_impl_inclusive_or_expression_test.cc
View File

@@ -44,8 +44,8 @@ TEST_F(ParserImplTest, InclusiveOrExpression_Parses) {
ASSERT_TRUE(rel->rhs()->Is<ast::ConstructorExpression>());
ASSERT_TRUE(rel->rhs()->Is<ast::ScalarConstructorExpression>());
auto* init = rel->rhs()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsBool());
ASSERT_TRUE(init->literal()->AsBool()->IsTrue());
ASSERT_TRUE(init->literal()->Is<ast::BoolLiteral>());
ASSERT_TRUE(init->literal()->As<ast::BoolLiteral>()->IsTrue());
}
TEST_F(ParserImplTest, InclusiveOrExpression_InvalidLHS) {

4
src/reader/wgsl/parser_impl_logical_and_expression_test.cc
View File

@@ -44,8 +44,8 @@ TEST_F(ParserImplTest, LogicalAndExpression_Parses) {
ASSERT_TRUE(rel->rhs()->Is<ast::ConstructorExpression>());
ASSERT_TRUE(rel->rhs()->Is<ast::ScalarConstructorExpression>());
auto* init = rel->rhs()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsBool());
ASSERT_TRUE(init->literal()->AsBool()->IsTrue());
ASSERT_TRUE(init->literal()->Is<ast::BoolLiteral>());
ASSERT_TRUE(init->literal()->As<ast::BoolLiteral>()->IsTrue());
}
TEST_F(ParserImplTest, LogicalAndExpression_InvalidLHS) {

4
src/reader/wgsl/parser_impl_logical_or_expression_test.cc
View File

@@ -44,8 +44,8 @@ TEST_F(ParserImplTest, LogicalOrExpression_Parses) {
ASSERT_TRUE(rel->rhs()->Is<ast::ConstructorExpression>());
ASSERT_TRUE(rel->rhs()->Is<ast::ScalarConstructorExpression>());
auto* init = rel->rhs()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsBool());
ASSERT_TRUE(init->literal()->AsBool()->IsTrue());
ASSERT_TRUE(init->literal()->Is<ast::BoolLiteral>());
ASSERT_TRUE(init->literal()->As<ast::BoolLiteral>()->IsTrue());
}
TEST_F(ParserImplTest, LogicalOrExpression_InvalidLHS) {

12
src/reader/wgsl/parser_impl_multiplicative_expression_test.cc
View File

@@ -44,8 +44,8 @@ TEST_F(ParserImplTest, MultiplicativeExpression_Parses_Multiply) {
ASSERT_TRUE(rel->rhs()->Is<ast::ConstructorExpression>());
ASSERT_TRUE(rel->rhs()->Is<ast::ScalarConstructorExpression>());
auto* init = rel->rhs()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsBool());
ASSERT_TRUE(init->literal()->AsBool()->IsTrue());
ASSERT_TRUE(init->literal()->Is<ast::BoolLiteral>());
ASSERT_TRUE(init->literal()->As<ast::BoolLiteral>()->IsTrue());
}
TEST_F(ParserImplTest, MultiplicativeExpression_Parses_Divide) {
@@ -67,8 +67,8 @@ TEST_F(ParserImplTest, MultiplicativeExpression_Parses_Divide) {
ASSERT_TRUE(rel->rhs()->Is<ast::ConstructorExpression>());
ASSERT_TRUE(rel->rhs()->Is<ast::ScalarConstructorExpression>());
auto* init = rel->rhs()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsBool());
ASSERT_TRUE(init->literal()->AsBool()->IsTrue());
ASSERT_TRUE(init->literal()->Is<ast::BoolLiteral>());
ASSERT_TRUE(init->literal()->As<ast::BoolLiteral>()->IsTrue());
}
TEST_F(ParserImplTest, MultiplicativeExpression_Parses_Modulo) {
@@ -90,8 +90,8 @@ TEST_F(ParserImplTest, MultiplicativeExpression_Parses_Modulo) {
ASSERT_TRUE(rel->rhs()->Is<ast::ConstructorExpression>());
ASSERT_TRUE(rel->rhs()->Is<ast::ScalarConstructorExpression>());
auto* init = rel->rhs()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsBool());
ASSERT_TRUE(init->literal()->AsBool()->IsTrue());
ASSERT_TRUE(init->literal()->Is<ast::BoolLiteral>());
ASSERT_TRUE(init->literal()->As<ast::BoolLiteral>()->IsTrue());
}
TEST_F(ParserImplTest, MultiplicativeExpression_InvalidLHS) {

4
src/reader/wgsl/parser_impl_postfix_expression_test.cc
View File

@@ -47,8 +47,8 @@ TEST_F(ParserImplTest, PostfixExpression_Array_ConstantIndex) {
ASSERT_TRUE(ary->idx_expr()->Is<ast::ConstructorExpression>());
ASSERT_TRUE(ary->idx_expr()->Is<ast::ScalarConstructorExpression>());
auto* c = ary->idx_expr()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(c->literal()->IsSint());
EXPECT_EQ(c->literal()->AsSint()->value(), 1);
ASSERT_TRUE(c->literal()->Is<ast::SintLiteral>());
EXPECT_EQ(c->literal()->As<ast::SintLiteral>()->value(), 1);
}
TEST_F(ParserImplTest, PostfixExpression_Array_ExpressionIndex) {

20
src/reader/wgsl/parser_impl_primary_expression_test.cc
View File

@@ -60,26 +60,26 @@ TEST_F(ParserImplTest, PrimaryExpression_TypeDecl) {
ASSERT_TRUE(val[0]->Is<ast::ConstructorExpression>());
ASSERT_TRUE(val[0]->Is<ast::ScalarConstructorExpression>());
auto* ident = val[0]->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(ident->literal()->IsSint());
EXPECT_EQ(ident->literal()->AsSint()->value(), 1);
ASSERT_TRUE(ident->literal()->Is<ast::SintLiteral>());
EXPECT_EQ(ident->literal()->As<ast::SintLiteral>()->value(), 1);
ASSERT_TRUE(val[1]->Is<ast::ConstructorExpression>());
ASSERT_TRUE(val[1]->Is<ast::ScalarConstructorExpression>());
ident = val[1]->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(ident->literal()->IsSint());
EXPECT_EQ(ident->literal()->AsSint()->value(), 2);
ASSERT_TRUE(ident->literal()->Is<ast::SintLiteral>());
EXPECT_EQ(ident->literal()->As<ast::SintLiteral>()->value(), 2);
ASSERT_TRUE(val[2]->Is<ast::ConstructorExpression>());
ASSERT_TRUE(val[2]->Is<ast::ScalarConstructorExpression>());
ident = val[2]->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(ident->literal()->IsSint());
EXPECT_EQ(ident->literal()->AsSint()->value(), 3);
ASSERT_TRUE(ident->literal()->Is<ast::SintLiteral>());
EXPECT_EQ(ident->literal()->As<ast::SintLiteral>()->value(), 3);
ASSERT_TRUE(val[3]->Is<ast::ConstructorExpression>());
ASSERT_TRUE(val[3]->Is<ast::ScalarConstructorExpression>());
ident = val[3]->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(ident->literal()->IsSint());
EXPECT_EQ(ident->literal()->AsSint()->value(), 4);
ASSERT_TRUE(ident->literal()->Is<ast::SintLiteral>());
EXPECT_EQ(ident->literal()->As<ast::SintLiteral>()->value(), 4);
}
TEST_F(ParserImplTest, PrimaryExpression_TypeDecl_ZeroConstructor) {
@@ -146,8 +146,8 @@ TEST_F(ParserImplTest, PrimaryExpression_ConstLiteral_True) {
ASSERT_TRUE(e->Is<ast::ConstructorExpression>());
ASSERT_TRUE(e->Is<ast::ScalarConstructorExpression>());
auto* init = e->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsBool());
EXPECT_TRUE(init->literal()->AsBool()->IsTrue());
ASSERT_TRUE(init->literal()->Is<ast::BoolLiteral>());
EXPECT_TRUE(init->literal()->As<ast::BoolLiteral>()->IsTrue());
}
TEST_F(ParserImplTest, PrimaryExpression_ParenExpr) {

16
src/reader/wgsl/parser_impl_relational_expression_test.cc
View File

@@ -44,8 +44,8 @@ TEST_F(ParserImplTest, RelationalExpression_Parses_LessThan) {
ASSERT_TRUE(rel->rhs()->Is<ast::ConstructorExpression>());
ASSERT_TRUE(rel->rhs()->Is<ast::ScalarConstructorExpression>());
auto* init = rel->rhs()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsBool());
ASSERT_TRUE(init->literal()->AsBool()->IsTrue());
ASSERT_TRUE(init->literal()->Is<ast::BoolLiteral>());
ASSERT_TRUE(init->literal()->As<ast::BoolLiteral>()->IsTrue());
}
TEST_F(ParserImplTest, RelationalExpression_Parses_GreaterThan) {
@@ -67,8 +67,8 @@ TEST_F(ParserImplTest, RelationalExpression_Parses_GreaterThan) {
ASSERT_TRUE(rel->rhs()->Is<ast::ConstructorExpression>());
ASSERT_TRUE(rel->rhs()->Is<ast::ScalarConstructorExpression>());
auto* init = rel->rhs()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsBool());
ASSERT_TRUE(init->literal()->AsBool()->IsTrue());
ASSERT_TRUE(init->literal()->Is<ast::BoolLiteral>());
ASSERT_TRUE(init->literal()->As<ast::BoolLiteral>()->IsTrue());
}
TEST_F(ParserImplTest, RelationalExpression_Parses_LessThanEqual) {
@@ -90,8 +90,8 @@ TEST_F(ParserImplTest, RelationalExpression_Parses_LessThanEqual) {
ASSERT_TRUE(rel->rhs()->Is<ast::ConstructorExpression>());
ASSERT_TRUE(rel->rhs()->Is<ast::ScalarConstructorExpression>());
auto* init = rel->rhs()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsBool());
ASSERT_TRUE(init->literal()->AsBool()->IsTrue());
ASSERT_TRUE(init->literal()->Is<ast::BoolLiteral>());
ASSERT_TRUE(init->literal()->As<ast::BoolLiteral>()->IsTrue());
}
TEST_F(ParserImplTest, RelationalExpression_Parses_GreaterThanEqual) {
@@ -113,8 +113,8 @@ TEST_F(ParserImplTest, RelationalExpression_Parses_GreaterThanEqual) {
ASSERT_TRUE(rel->rhs()->Is<ast::ConstructorExpression>());
ASSERT_TRUE(rel->rhs()->Is<ast::ScalarConstructorExpression>());
auto* init = rel->rhs()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsBool());
ASSERT_TRUE(init->literal()->AsBool()->IsTrue());
ASSERT_TRUE(init->literal()->Is<ast::BoolLiteral>());
ASSERT_TRUE(init->literal()->As<ast::BoolLiteral>()->IsTrue());
}
TEST_F(ParserImplTest, RelationalExpression_InvalidLHS) {

8
src/reader/wgsl/parser_impl_shift_expression_test.cc
View File

@@ -44,8 +44,8 @@ TEST_F(ParserImplTest, ShiftExpression_Parses_ShiftLeft) {
ASSERT_TRUE(rel->rhs()->Is<ast::ConstructorExpression>());
ASSERT_TRUE(rel->rhs()->Is<ast::ScalarConstructorExpression>());
auto* init = rel->rhs()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsBool());
ASSERT_TRUE(init->literal()->AsBool()->IsTrue());
ASSERT_TRUE(init->literal()->Is<ast::BoolLiteral>());
ASSERT_TRUE(init->literal()->As<ast::BoolLiteral>()->IsTrue());
}
TEST_F(ParserImplTest, ShiftExpression_Parses_ShiftRight) {
@@ -67,8 +67,8 @@ TEST_F(ParserImplTest, ShiftExpression_Parses_ShiftRight) {
ASSERT_TRUE(rel->rhs()->Is<ast::ConstructorExpression>());
ASSERT_TRUE(rel->rhs()->Is<ast::ScalarConstructorExpression>());
auto* init = rel->rhs()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsBool());
ASSERT_TRUE(init->literal()->AsBool()->IsTrue());
ASSERT_TRUE(init->literal()->Is<ast::BoolLiteral>());
ASSERT_TRUE(init->literal()->As<ast::BoolLiteral>()->IsTrue());
}
TEST_F(ParserImplTest, ShiftExpression_InvalidLHS) {

12
src/reader/wgsl/parser_impl_unary_expression_test.cc
View File

@@ -43,8 +43,8 @@ TEST_F(ParserImplTest, UnaryExpression_Postix) {
ASSERT_TRUE(ary->idx_expr()->Is<ast::ConstructorExpression>());
ASSERT_TRUE(ary->idx_expr()->Is<ast::ScalarConstructorExpression>());
auto* init = ary->idx_expr()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsSint());
ASSERT_EQ(init->literal()->AsSint()->value(), 2);
ASSERT_TRUE(init->literal()->Is<ast::SintLiteral>());
ASSERT_EQ(init->literal()->As<ast::SintLiteral>()->value(), 2);
}
TEST_F(ParserImplTest, UnaryExpression_Minus) {
@@ -63,8 +63,8 @@ TEST_F(ParserImplTest, UnaryExpression_Minus) {
ASSERT_TRUE(u->expr()->Is<ast::ScalarConstructorExpression>());
auto* init = u->expr()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsSint());
EXPECT_EQ(init->literal()->AsSint()->value(), 1);
ASSERT_TRUE(init->literal()->Is<ast::SintLiteral>());
EXPECT_EQ(init->literal()->As<ast::SintLiteral>()->value(), 1);
}
TEST_F(ParserImplTest, UnaryExpression_Minus_InvalidRHS) {
@@ -93,8 +93,8 @@ TEST_F(ParserImplTest, UnaryExpression_Bang) {
ASSERT_TRUE(u->expr()->Is<ast::ScalarConstructorExpression>());
auto* init = u->expr()->As<ast::ScalarConstructorExpression>();
ASSERT_TRUE(init->literal()->IsSint());
EXPECT_EQ(init->literal()->AsSint()->value(), 1);
ASSERT_TRUE(init->literal()->Is<ast::SintLiteral>());
EXPECT_EQ(init->literal()->As<ast::SintLiteral>()->value(), 1);
}
TEST_F(ParserImplTest, UnaryExpression_Bang_InvalidRHS) {