encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

dawn/native: Fix a bunch of GCC warnings 

GCC is warning that the switch cases do not have a 'default' clause, and so control flow can reach the end of the function, which does not have a return.

Change-Id: I45465e7f9547d683ea7eb5f356b80a77e6d95d73
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/88310
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Ben Clayton 2022-04-29 11:07:33 +00:00 committed by Dawn LUCI CQ
parent 27f480b7e6
commit ad0602fbf2
5 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/dawn/native/BindGroupLayout.cpp
View File

@ -657,8 +657,9 @@ namespace dawn::native {
case wgpu::BufferBindingType::ReadOnlyStorage:
return true;
case wgpu::BufferBindingType::Undefined:
UNREACHABLE();
break;
}
UNREACHABLE();
}
std::string BindGroupLayoutBase::EntriesToString() const {

4
src/dawn/native/CommandBuffer.cpp
View File

@ -85,6 +85,8 @@ namespace dawn::native {
return extent.width == copySize.width && extent.height == copySize.height &&
extent.depthOrArrayLayers == copySize.depthOrArrayLayers;
}
UNREACHABLE();
}
SubresourceRange GetSubresourcesAffectedByCopy(const TextureCopy& copy,
@ -100,6 +102,8 @@ namespace dawn::native {
case wgpu::TextureDimension::e3D:
return {copy.aspect, {0, 1}, {copy.mipLevel, 1}};
}
UNREACHABLE();
}
void LazyClearRenderPassAttachments(BeginRenderPassCmd* renderPass) {

3
src/dawn/native/Features.cpp
View File

@ -156,8 +156,9 @@ namespace dawn::native {
return wgpu::FeatureName::DawnNative;
case Feature::EnumCount:
UNREACHABLE();
break;
}
UNREACHABLE();
}
} // anonymous namespace

6
src/dawn/native/Texture.cpp
View File

@ -111,8 +111,9 @@ namespace dawn::native {
return textureDimension == wgpu::TextureDimension::e1D;
case wgpu::TextureViewDimension::Undefined:
UNREACHABLE();
break;
}
UNREACHABLE();
}
bool IsArrayLayerValidForTextureViewDimension(
@ -132,8 +133,9 @@ namespace dawn::native {
return textureViewArrayLayer == 1u;
case wgpu::TextureViewDimension::Undefined:
UNREACHABLE();
break;
}
UNREACHABLE();
}
MaybeError ValidateSampleCount(const TextureDescriptor* descriptor,

3
src/dawn/native/vulkan/TextureVk.cpp
View File

@ -54,8 +54,9 @@ namespace dawn::native::vulkan {
return VK_IMAGE_VIEW_TYPE_3D;
case wgpu::TextureViewDimension::Undefined:
UNREACHABLE();
break;
}
UNREACHABLE();
}
// Computes which vulkan access type could be required for the given Dawn usage.