encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-21 10:49:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixup build/include_order issues in src/dawn.

Browse Source 
This Cl moves the cpp includes to above the project includes fixing up
the build/include_order issues and enabling the lint check.

A couple includes are marked as NOLINT as the c header has to come after
the project header due to setting defines.

Bug: dawn:1339
Change-Id: Ia47499c94fff99106397b83f6c5c7fe100c44a0e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86513
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
This commit is contained in:
dan sinclair
2022-04-19 20:38:44 +00:00
committed by Dawn LUCI CQ
parent ebdb70b81d
commit b02535557e
274 changed files with 716 additions and 704 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/tint/bench/benchmark.h
View File

@@ -17,6 +17,7 @@
#include <memory>
#include <string>
// TODO(https://crbug.com/dawn/1379) Update cpplint and remove NOLINT
#include <variant> // NOLINT: Found C system header after C++ system header.
#include "benchmark/benchmark.h"

3
src/tint/reader/wgsl/token.h
View File

@@ -17,7 +17,8 @@
#include <string>
#include <string_view>
#include <variant> // NOLINT: cpplint doesn't recognise this
// TODO(https://crbug.com/dawn/1379) Update cpplint and remove NOLINT
#include <variant> // NOLINT(build/include_order))
#include "src/tint/source.h"