encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-05-13 10:51:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove lintcpp from presubmits since it fails on all Dawn files

Browse Source 
Also fixes some other lint issues.

Bug: dawn:1339
Change-Id: I19a212218db3249191deedc671fc6e36991ecad8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86061
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Corentin Wallez 2022-04-07 11:36:06 +00:00 committed by Dawn LUCI CQ
parent 9f54a51b3d
commit b28d6c8e1c
7 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
BUILD.gn
View File

@ -21,8 +21,8 @@ group("all") {
"src/dawn/native:webgpu_dawn", "src/dawn/native:webgpu_dawn",
"src/dawn/tests", "src/dawn/tests",
"src/fuzzers/dawn:dawn_fuzzers", "src/fuzzers/dawn:dawn_fuzzers",
"src/tint/fuzzers",
"src/tint:libtint", "src/tint:libtint",
"src/tint/fuzzers",
"test/tint:tint_unittests", "test/tint:tint_unittests",
] ]
if (dawn_standalone) { if (dawn_standalone) {

6
PRESUBMIT.py
View File

@ -129,10 +129,8 @@ def _DoCommonChecks(input_api, output_api):
input_api, output_api)) input_api, output_api))
results.extend( results.extend(
input_api.canned_checks.CheckDoNotSubmit(input_api, output_api)) input_api.canned_checks.CheckDoNotSubmit(input_api, output_api))
results.extend( # TODO(dawn:1339): Add back CheckChangeLintsClean, it fails on all Dawn
input_api.canned_checks.CheckChangeLintsClean(input_api, # source files because they where never linted (and use different rules).
output_api,
lint_filters=""))
results.extend( results.extend(
_CheckNonInclusiveLanguage(input_api, output_api, _CheckNonInclusiveLanguage(input_api, output_api,
_NonInclusiveFileFilter)) _NonInclusiveFileFilter))

2
src/dawn/native/BUILD.gn
View File

@ -161,9 +161,9 @@ source_set("sources") {
":headers", ":headers",
":utils_gen", ":utils_gen",
"${dawn_root}/src/dawn/common", "${dawn_root}/src/dawn/common",
"${dawn_root}/src/tint:libtint",
"${dawn_spirv_tools_dir}:spvtools_opt", "${dawn_spirv_tools_dir}:spvtools_opt",
"${dawn_spirv_tools_dir}:spvtools_val", "${dawn_spirv_tools_dir}:spvtools_val",
"${dawn_root}/src/tint:libtint",
] ]
defines = [] defines = []
libs = [] libs = []

2
src/dawn/tests/unittests/ITypBitsetTests.cpp
View File

@ -206,4 +206,4 @@ TEST_F(ITypBitsetTest, GetHighestBitIndexPlusOne) {
EXPECT_EQ(36u, static_cast<size_t>(GetHighestBitIndexPlusOne(Bitset40(0xFFFFFFFFF)))); EXPECT_EQ(36u, static_cast<size_t>(GetHighestBitIndexPlusOne(Bitset40(0xFFFFFFFFF))));
EXPECT_EQ(40u, static_cast<size_t>(GetHighestBitIndexPlusOne(Bitset40(0xF000000000)))); EXPECT_EQ(40u, static_cast<size_t>(GetHighestBitIndexPlusOne(Bitset40(0xF000000000))));
EXPECT_EQ(40u, static_cast<size_t>(GetHighestBitIndexPlusOne(Bitset40(0xFFFFFFFFFF)))); EXPECT_EQ(40u, static_cast<size_t>(GetHighestBitIndexPlusOne(Bitset40(0xFFFFFFFFFF))));
} }

2
src/dawn/tests/white_box/D3D12GPUTimestampCalibrationTests.cpp
View File

@ -115,4 +115,4 @@ TEST_P(D3D12GPUTimestampCalibrationTests, TimestampsInOrder) {
} }
DAWN_INSTANTIATE_TEST(D3D12GPUTimestampCalibrationTests, DAWN_INSTANTIATE_TEST(D3D12GPUTimestampCalibrationTests,
D3D12Backend({"disable_timestamp_query_conversion"})); D3D12Backend({"disable_timestamp_query_conversion"}));

4
src/tint/BUILD.gn
View File

@ -449,6 +449,8 @@ libtint_source_set("libtint_core_all_src") {
"transform/decompose_strided_array.h", "transform/decompose_strided_array.h",
"transform/decompose_strided_matrix.cc", "transform/decompose_strided_matrix.cc",
"transform/decompose_strided_matrix.h", "transform/decompose_strided_matrix.h",
"transform/expand_compound_assignment.cc",
"transform/expand_compound_assignment.h",
"transform/first_index_offset.cc", "transform/first_index_offset.cc",
"transform/first_index_offset.h", "transform/first_index_offset.h",
"transform/fold_constants.cc", "transform/fold_constants.cc",
@ -457,8 +459,6 @@ libtint_source_set("libtint_core_all_src") {
"transform/fold_trivial_single_use_lets.h", "transform/fold_trivial_single_use_lets.h",
"transform/for_loop_to_loop.cc", "transform/for_loop_to_loop.cc",
"transform/for_loop_to_loop.h", "transform/for_loop_to_loop.h",
"transform/expand_compound_assignment.cc",
"transform/expand_compound_assignment.h",
"transform/localize_struct_array_assignment.cc", "transform/localize_struct_array_assignment.cc",
"transform/localize_struct_array_assignment.h", "transform/localize_struct_array_assignment.h",
"transform/loop_to_for_loop.cc", "transform/loop_to_for_loop.cc",

2
test/tint/BUILD.gn
View File

@ -320,11 +320,11 @@ tint_unittests_source_set("tint_unittests_transform_src") {
"../../src/tint/transform/decompose_memory_access_test.cc", "../../src/tint/transform/decompose_memory_access_test.cc",
"../../src/tint/transform/decompose_strided_array_test.cc", "../../src/tint/transform/decompose_strided_array_test.cc",
"../../src/tint/transform/decompose_strided_matrix_test.cc", "../../src/tint/transform/decompose_strided_matrix_test.cc",
"../../src/tint/transform/expand_compound_assignment_test.cc",
"../../src/tint/transform/first_index_offset_test.cc", "../../src/tint/transform/first_index_offset_test.cc",
"../../src/tint/transform/fold_constants_test.cc", "../../src/tint/transform/fold_constants_test.cc",
"../../src/tint/transform/fold_trivial_single_use_lets_test.cc", "../../src/tint/transform/fold_trivial_single_use_lets_test.cc",
"../../src/tint/transform/for_loop_to_loop_test.cc", "../../src/tint/transform/for_loop_to_loop_test.cc",
"../../src/tint/transform/expand_compound_assignment_test.cc",
"../../src/tint/transform/localize_struct_array_assignment_test.cc", "../../src/tint/transform/localize_struct_array_assignment_test.cc",
"../../src/tint/transform/loop_to_for_loop_test.cc", "../../src/tint/transform/loop_to_for_loop_test.cc",
"../../src/tint/transform/module_scope_var_to_entry_point_param_test.cc", "../../src/tint/transform/module_scope_var_to_entry_point_param_test.cc",