encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Enables device.destroy API now that CTS tests have been implemented. 

Bug: dawn:628
Change-Id: I52e9c2d04c605b64a5fd80762891fc44e2c2c53a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/84921
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
This commit is contained in:
Loko Kung 2022-03-29 01:23:22 +00:00 committed by Dawn LUCI CQ
parent 0d7772208f
commit b8a4f34ed9
2 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/dawn/native/Device.cpp
View File

@ -412,12 +412,6 @@ namespace dawn::native {
}
void DeviceBase::APIDestroy() {
// TODO(crbug.com/dawn/628) Re-enable once CTS testing is in place and passing.
if (IsToggleEnabled(Toggle::DisallowUnsafeAPIs)) {
ConsumedError(DAWN_VALIDATION_ERROR(
"Explicit device.destroy() is disallowed because it is not fully implemented"));
return;
}
Destroy();
}

6
src/dawn/tests/unittests/validation/UnsafeAPIValidationTests.cpp
View File

@ -36,12 +36,6 @@ class UnsafeAPIValidationTest : public ValidationTest {
}
};
// Check that explicit user device.destroy() is disallowed as part of unsafe APIs.
// TODO(crbug.com/dawn/628) Remove when CTS testing is in place and passing.
TEST_F(UnsafeAPIValidationTest, ExplicitDeviceDestroy) {
ASSERT_DEVICE_ERROR(device.Destroy(), HasSubstr("Explicit device.destroy() is disallowed"));
}
// Check that pipeline overridable constants are disallowed as part of unsafe APIs.
// TODO(dawn:1041) Remove when implementation for all backend is added
TEST_F(UnsafeAPIValidationTest, PipelineOverridableConstants) {