mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-12-14 15:46:28 +00:00
PRESUBMIT: Check that generated files aren't stale
Fails presubmit if you need to run `./tools/run gen` Change-Id: I05311cd668c5a1f4f484b25cc1367f680a9d24eb Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/110140 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: Dan Sinclair <dsinclair@chromium.org> Kokoro: Ben Clayton <bclayton@google.com>
This commit is contained in:
committed by
Dawn LUCI CQ
parent
6be02b607f
commit
bca96d9bc8
21
PRESUBMIT.py
21
PRESUBMIT.py
@@ -127,8 +127,29 @@ def _NonInclusiveFileFilter(file):
|
||||
return file.LocalPath() not in filter_list
|
||||
|
||||
|
||||
def _CheckNoStaleGen(input_api, output_api):
|
||||
results = []
|
||||
try:
|
||||
go = input_api.os_path.join(input_api.change.RepositoryRoot(), "tools",
|
||||
"golang", "bin", "go")
|
||||
if input_api.is_windows:
|
||||
go += '.exe'
|
||||
input_api.subprocess.check_call_out(
|
||||
[go, "run", "tools/src/cmd/gen/main.go", "--check-stale"],
|
||||
stdout=input_api.subprocess.PIPE,
|
||||
stderr=input_api.subprocess.PIPE,
|
||||
cwd=input_api.change.RepositoryRoot())
|
||||
except input_api.subprocess.CalledProcessError as e:
|
||||
if input_api.is_committing:
|
||||
results.append(output_api.PresubmitError('%s' % (e, )))
|
||||
else:
|
||||
results.append(output_api.PresubmitPromptWarning('%s' % (e, )))
|
||||
return results
|
||||
|
||||
|
||||
def _DoCommonChecks(input_api, output_api):
|
||||
results = []
|
||||
results.extend(_CheckNoStaleGen(input_api, output_api))
|
||||
results.extend(
|
||||
input_api.canned_checks.CheckChangedLUCIConfigs(input_api, output_api))
|
||||
|
||||
|
||||
Reference in New Issue
Block a user