encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-12 14:46:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

PRESUBMIT: Check that generated files aren't stale

Browse Source 
Fails presubmit if you need to run `./tools/run gen`

Change-Id: I05311cd668c5a1f4f484b25cc1367f680a9d24eb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/110140
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Ben Clayton <bclayton@google.com>
This commit is contained in:
Ben Clayton
2022-11-16 21:34:14 +00:00
committed by Dawn LUCI CQ
parent 6be02b607f
commit bca96d9bc8
2 changed files with 53 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
tools/src/cmd/gen/main.go
View File

@@ -75,10 +75,13 @@ optional flags:`)
func run() error {
outputDir := ""
verbose := false
checkStale := false
flag.StringVar(&outputDir, "o", "", "custom output directory (optional)")
flag.BoolVar(&verbose, "verbose", false, "print verbose output")
flag.BoolVar(&checkStale, "check-stale", false, "don't emit anything, just check that files are up to date")
flag.Parse()
staleFiles := []string{}
projectRoot := fileutils.DawnRoot()
// Find clang-format
@@ -168,8 +171,22 @@ func run() error {
sb := strings.Builder{}
sb.WriteString(fmt.Sprintf(header, copyrightYear, filepath.ToSlash(relTmplPath)))
sb.WriteString(body)
content := sb.String()
return writeFileIfChanged(outPath, content, string(existing))
oldContent, newContent := string(existing), sb.String()
if oldContent != newContent {
if checkStale {
staleFiles = append(staleFiles, outPath)
} else {
if err := os.MkdirAll(filepath.Dir(outPath), 0777); err != nil {
return fmt.Errorf("failed to create directory for '%v': %w", outPath, err)
}
if err := ioutil.WriteFile(outPath, []byte(newContent), 0666); err != nil {
return fmt.Errorf("failed to write file '%v': %w", outPath, err)
}
}
}
return nil
}
// Write the content generated using the template and semantic info
@@ -196,6 +213,19 @@ func run() error {
}
}
if len(staleFiles) > 0 {
fmt.Println(len(staleFiles), "files need regenerating:")
for _, path := range staleFiles {
if rel, err := filepath.Rel(projectRoot, path); err == nil {
fmt.Println(" •", rel)
} else {
fmt.Println(" •", path)
}
}
fmt.Println("Regenerate these files with: ./tools/run gen")
os.Exit(1)
}
return nil
}
@@ -268,20 +298,6 @@ func (g *genCache) permute(overload *sem.Overload) ([]gen.Permutation, error) {
return g.cached.permuter.Permute(overload)
}
// writes content to path if the file has changed
func writeFileIfChanged(path, newContent, oldContent string) error {
if oldContent == newContent {
return nil // Not changed
}
if err := os.MkdirAll(filepath.Dir(path), 0777); err != nil {
return fmt.Errorf("failed to create directory for '%v': %w", path, err)
}
if err := ioutil.WriteFile(path, []byte(newContent), 0666); err != nil {
return fmt.Errorf("failed to write file '%v': %w", path, err)
}
return nil
}
var copyrightRegex = regexp.MustCompile(`// Copyright (\d+) The`)
const header = `// Copyright %v The Tint Authors.