encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tools/cts: Treat 'Skip' results as 'Pass' 

Change-Id: I2548c2449e535cff1f6907a9f2e892037038aa02
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95841
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
This commit is contained in:
Ben Clayton 2022-07-08 12:33:46 +00:00 committed by Dawn LUCI CQ
parent d31838aff1
commit be88e62c0f
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tools/src/cts/expectations/update.go
View File

@ -78,13 +78,17 @@ type updater struct {
tagSets []result.Tags // reverse-ordered tag-sets of 'in' tagSets []result.Tags // reverse-ordered tag-sets of 'in'
} }
// simplifyStatuses replaces all result statuses that are not 'Pass', // simplifyStatuses replaces all result statuses that are not one of
// 'RetryOnFailure', 'Slow', 'Skip' with 'Failure'. // 'Pass', 'RetryOnFailure', 'Slow', 'Skip' with 'Failure', and also replaces
// 'Skip' results with 'Pass'.
func simplifyStatuses(results result.List) { func simplifyStatuses(results result.List) {
for i, r := range results { for i, r := range results {
switch r.Status { switch r.Status {
case result.Pass, result.RetryOnFailure, result.Slow, result.Skip: case result.Pass, result.RetryOnFailure, result.Slow:
// keep // keep
case result.Skip:
// Typically represents a .unimplemented() test
results[i].Status = result.Pass
default: default:
results[i].Status = result.Failure results[i].Status = result.Failure
} }