encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Re-enable unittests for Tint 

Bug: tint:717
Bug: tint:692
Bug: tint:718

Change-Id: I5765d8582ee0132efb47939f495781954a1e2afa
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/48843
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
This commit is contained in:
Ryan Harrison 2021-04-26 08:31:15 +00:00 committed by Commit Bot service account
parent 221b8b06cc
commit bf99a720c3
2 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/tests/unittests/validation/ShaderModuleValidationTests.cpp
View File

@ -118,9 +118,6 @@ TEST_F(ShaderModuleValidationTest, CombinedTextureAndSampler) {
// Test that it is not allowed to declare a multisampled-array interface texture. // Test that it is not allowed to declare a multisampled-array interface texture.
// TODO(enga): Also test multisampled cube, cube array, and 3D. These have no GLSL keywords. // TODO(enga): Also test multisampled cube, cube array, and 3D. These have no GLSL keywords.
TEST_F(ShaderModuleValidationTest, MultisampledArrayTexture) { TEST_F(ShaderModuleValidationTest, MultisampledArrayTexture) {
// TODO(https://crbug.com/tint/717): Remove skip once this is fixed
DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator"));
// SPIR-V ASM produced by glslang for the following fragment shader: // SPIR-V ASM produced by glslang for the following fragment shader:
// //
// #version 450 // #version 450

9
src/tests/unittests/validation/StorageTextureValidationTests.cpp
View File

@ -227,9 +227,6 @@ TEST_F(StorageTextureValidationTests, ComputePipeline) {
// Validate read-write storage textures are not currently supported. // Validate read-write storage textures are not currently supported.
TEST_F(StorageTextureValidationTests, ReadWriteStorageTexture) { TEST_F(StorageTextureValidationTests, ReadWriteStorageTexture) {
// TODO(https://crbug.com/tint/692): Remove skip once this is fixed.
DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator"));
// Read-write storage textures cannot be declared in a vertex shader by default. // Read-write storage textures cannot be declared in a vertex shader by default.
{ {
ASSERT_DEVICE_ERROR(utils::CreateShaderModule(device, R"( ASSERT_DEVICE_ERROR(utils::CreateShaderModule(device, R"(
@ -293,9 +290,6 @@ TEST_F(StorageTextureValidationTests, BindGroupLayoutWithStorageTextureBindingTy
// Validate it is an error to declare a read-only or write-only storage texture in shaders with any // Validate it is an error to declare a read-only or write-only storage texture in shaders with any
// format that doesn't support TextureUsage::Storage texture usages. // format that doesn't support TextureUsage::Storage texture usages.
TEST_F(StorageTextureValidationTests, StorageTextureFormatInShaders) { TEST_F(StorageTextureValidationTests, StorageTextureFormatInShaders) {
// TODO(https://crbug.com/tint/718): Remove skip once this is fixed.
DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator"));
// Not include RGBA8UnormSrgb, BGRA8Unorm, BGRA8UnormSrgb because they are not related to any // Not include RGBA8UnormSrgb, BGRA8Unorm, BGRA8UnormSrgb because they are not related to any
// SPIR-V Image Formats. // SPIR-V Image Formats.
constexpr std::array<wgpu::TextureFormat, 32> kWGPUTextureFormatSupportedAsSPIRVImageFormats = { constexpr std::array<wgpu::TextureFormat, 32> kWGPUTextureFormatSupportedAsSPIRVImageFormats = {
@ -332,9 +326,6 @@ TEST_F(StorageTextureValidationTests, StorageTextureFormatInShaders) {
// Verify that declaring a storage texture format that is not supported in WebGPU causes validation // Verify that declaring a storage texture format that is not supported in WebGPU causes validation
// error. // error.
TEST_F(StorageTextureValidationTests, UnsupportedWGSLStorageTextureFormat) { TEST_F(StorageTextureValidationTests, UnsupportedWGSLStorageTextureFormat) {
// TODO(https://crbug.com/tint/718): Remove skip once this is fixed.
DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator"));
constexpr std::array<wgpu::TextureFormat, 16> kUnsupportedTextureFormats = { constexpr std::array<wgpu::TextureFormat, 16> kUnsupportedTextureFormats = {
wgpu::TextureFormat::R8Unorm, wgpu::TextureFormat::R8Snorm, wgpu::TextureFormat::R8Unorm, wgpu::TextureFormat::R8Snorm,
wgpu::TextureFormat::R8Uint, wgpu::TextureFormat::R8Sint, wgpu::TextureFormat::R8Uint, wgpu::TextureFormat::R8Sint,