Add semantic::MemberAccessorExpression, use it.

Pull the mutable 'is_swizzled' semantic field from ast::MemberAccessorExpression and into a new semantic::MemberAccessorExpression node.
Have the TypeDeterminer create these semantic::MemberAccessorExpression nodes.

Bug: tint:390
Change-Id: I8fc6e36dabb417190528536a94d027af54059222
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/40142
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: David Neto <dneto@google.com>
This commit is contained in:
Ben Clayton
2021-02-03 23:55:56 +00:00
committed by Commit Bot service account
parent df629c5404
commit c1052a4971
9 changed files with 87 additions and 12 deletions

View File

@@ -0,0 +1,43 @@
// Copyright 2021 The Tint Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#ifndef SRC_SEMANTIC_MEMBER_ACCESSOR_EXPRESSION_H_
#define SRC_SEMANTIC_MEMBER_ACCESSOR_EXPRESSION_H_
#include "src/semantic/expression.h"
namespace tint {
namespace semantic {
/// MemberAccessorExpression holds the semantic information for a
/// ast::MemberAccessorExpression node.
class MemberAccessorExpression
: public Castable<MemberAccessorExpression, Expression> {
public:
/// Constructor
/// @param type the resolved type of the expression
/// @param is_swizzle true if this member access is for a vector swizzle
MemberAccessorExpression(type::Type* type, bool is_swizzle);
/// @return true if this member access is for a vector swizzle
bool IsSwizzle() const { return is_swizzle_; }
private:
bool const is_swizzle_;
};
} // namespace semantic
} // namespace tint
#endif // SRC_SEMANTIC_MEMBER_ACCESSOR_EXPRESSION_H_

View File

@@ -0,0 +1,27 @@
// Copyright 2021 The Tint Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "src/semantic/member_accessor_expression.h"
TINT_INSTANTIATE_CLASS_ID(tint::semantic::MemberAccessorExpression);
namespace tint {
namespace semantic {
MemberAccessorExpression::MemberAccessorExpression(type::Type* type,
bool is_swizzle)
: Base(type), is_swizzle_(is_swizzle) {}
} // namespace semantic
} // namespace tint

View File

@@ -25,6 +25,7 @@ namespace ast {
class CallExpression;
class Expression;
class Function;
class MemberAccessorExpression;
class Variable;
} // namespace ast
@@ -34,6 +35,7 @@ namespace semantic {
class Call;
class Expression;
class Function;
class MemberAccessorExpression;
class Variable;
/// TypeMappings is a struct that holds dummy `operator()` methods that's used
@@ -47,6 +49,8 @@ struct TypeMappings {
semantic::Function* operator()(ast::Function*);
semantic::Variable* operator()(ast::Variable*);
semantic::Call* operator()(ast::CallExpression*);
semantic::MemberAccessorExpression* operator()(
ast::MemberAccessorExpression*);
//! @endcond
};