encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Re-enable lint presubmit 

This CL updates the list of lint filters in order to allow the lint
presubmit check to pass. This allows each of the individual exclusions
to be fixed or ignored independently.

Issue: dawn:1339
Change-Id: Ia96a38c54508628996ca1e19555c01b11776c07f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86045
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
dan sinclair 2022-04-08 12:08:56 +00:00 committed by Dawn LUCI CQ
parent 9d27aaaaa1
commit c4502a0c41
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
PRESUBMIT.py
View File

@ -71,6 +71,15 @@ NONINCLUSIVE_REGEX_LIST = []
for reg in NONINCLUSIVE_REGEXES: for reg in NONINCLUSIVE_REGEXES:
NONINCLUSIVE_REGEX_LIST.append(re.compile(reg)) NONINCLUSIVE_REGEX_LIST.append(re.compile(reg))
LINT_FILTERS = [
"-build/header_guard", "-build/include", "-build/include_directory",
"-build/include_order", "-build/include_what_you_use", "-build/namespaces",
"-legal/copyright", "-readability/braces", "-readability/casting",
"-readability/inheritance", "-readability/namespace", "-runtime/explicit",
"-runtime/indentation_namespace", "-runtime/int", "-runtime/printf",
"-whitespace/comments", "-whitespace/empty_if_body"
]
def _CheckNonInclusiveLanguage(input_api, output_api, source_file_filter=None): def _CheckNonInclusiveLanguage(input_api, output_api, source_file_filter=None):
"""Checks the files for non-inclusive language.""" """Checks the files for non-inclusive language."""
@ -129,8 +138,9 @@ def _DoCommonChecks(input_api, output_api):
input_api, output_api)) input_api, output_api))
results.extend( results.extend(
input_api.canned_checks.CheckDoNotSubmit(input_api, output_api)) input_api.canned_checks.CheckDoNotSubmit(input_api, output_api))
# TODO(dawn:1339): Add back CheckChangeLintsClean, it fails on all Dawn results.extend(
# source files because they where never linted (and use different rules). input_api.canned_checks.CheckChangeLintsClean(
input_api, output_api, lint_filters=LINT_FILTERS))
results.extend( results.extend(
_CheckNonInclusiveLanguage(input_api, output_api, _CheckNonInclusiveLanguage(input_api, output_api,
_NonInclusiveFileFilter)) _NonInclusiveFileFilter))