Reenable D3D12 tests that failed with TINT_UNIMPLEMENTED

Fixed: tint:683
Change-Id: I38bd482063a38ae9aa71047e4fc05dbbc4a1c236
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/47423
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
This commit is contained in:
Ben Clayton 2021-04-12 20:56:24 +00:00 committed by Commit Bot service account
parent fab8bde2ce
commit c59d0f6014
4 changed files with 0 additions and 11 deletions

View File

@ -1186,9 +1186,6 @@ TEST_P(BufferZeroInitTest, IndirectBufferForDispatchIndirect) {
// Test the buffer will be lazily initialized correctly when its first use is in resolveQuerySet // Test the buffer will be lazily initialized correctly when its first use is in resolveQuerySet
TEST_P(BufferZeroInitTest, ResolveQuerySet) { TEST_P(BufferZeroInitTest, ResolveQuerySet) {
// TODO(crbug.com/tint/683): internal compiler error: TINT_UNIMPLEMENTED
DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
// Timestamp query is not supported on OpenGL // Timestamp query is not supported on OpenGL
DAWN_SKIP_TEST_IF(IsOpenGL()); DAWN_SKIP_TEST_IF(IsOpenGL());

View File

@ -110,9 +110,6 @@ TEST_P(ComputeCopyStorageBufferTests, SizedArrayOfBasic) {
// Test that a slightly-less-trivial compute-shader memcpy implementation works. // Test that a slightly-less-trivial compute-shader memcpy implementation works.
TEST_P(ComputeCopyStorageBufferTests, SizedArrayOfStruct) { TEST_P(ComputeCopyStorageBufferTests, SizedArrayOfStruct) {
// TODO(crbug.com/tint/683): internal compiler error: TINT_UNIMPLEMENTED
DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
BasicTest(R"( BasicTest(R"(
struct S { struct S {
a : vec2<u32>; a : vec2<u32>;

View File

@ -512,9 +512,6 @@ class TimestampQueryTests : public QueryTests {
void SetUp() override { void SetUp() override {
DawnTest::SetUp(); DawnTest::SetUp();
// TODO(crbug.com/tint/683): internal compiler error: TINT_UNIMPLEMENTED
DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
// Skip all tests if timestamp extension is not supported // Skip all tests if timestamp extension is not supported
DAWN_SKIP_TEST_IF(!SupportsExtensions({"timestamp_query"})); DAWN_SKIP_TEST_IF(!SupportsExtensions({"timestamp_query"}));
} }

View File

@ -86,8 +86,6 @@ class QueryInternalShaderTests : public DawnTest {};
// timestamp period (here use GPU frequency (HZ) on Intel D3D12 to calculate the period in // timestamp period (here use GPU frequency (HZ) on Intel D3D12 to calculate the period in
// ns for testing). // ns for testing).
TEST_P(QueryInternalShaderTests, TimestampComputeShader) { TEST_P(QueryInternalShaderTests, TimestampComputeShader) {
// TODO(crbug.com/tint/683): internal compiler error: TINT_UNIMPLEMENTED
DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
// TODO(crbug.com/dawn/741): Test output is wrong with D3D12 + WARP. // TODO(crbug.com/dawn/741): Test output is wrong with D3D12 + WARP.
DAWN_SKIP_TEST_IF(IsD3D12() && IsWARP()); DAWN_SKIP_TEST_IF(IsD3D12() && IsWARP());