encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Raise base maxComputeWorkgroupStorageSize limit. 16352 -> 16384 

Bug: dawn:1410
Change-Id: I0ad4873474614bcd62638583bf905ff2742eaae2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89821
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Loko Kung <lokokung@google.com>
This commit is contained in:
Austin Eng 2022-05-11 18:28:46 +00:00 committed by Dawn LUCI CQ
parent 75a31aa10a
commit ca8a54ed35
3 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/dawn/native/Limits.cpp
View File

@ -23,7 +23,7 @@
// TODO(crbug.com/dawn/685):
// For now, only expose these tiers until metrics can determine better ones.
#define LIMITS_WORKGROUP_STORAGE_SIZE(X) \
X(Maximum, maxComputeWorkgroupStorageSize, 16352, 32768, 49152, 65536)
X(Maximum, maxComputeWorkgroupStorageSize, 16384, 32768, 49152, 65536)
#define LIMITS_STORAGE_BUFFER_BINDING_SIZE(X) \
X(Maximum, maxStorageBufferBindingSize, 134217728, 1073741824, 2147483647, 4294967295)

4
src/dawn/tests/unittests/LimitsTests.cpp
View File

@ -34,7 +34,7 @@ TEST(Limits, ReifyDefaultLimits_PopulatesDefault) {
limits.maxStorageBufferBindingSize = wgpu::kLimitU64Undefined;
dawn::native::Limits reified = dawn::native::ReifyDefaultLimits(limits);
EXPECT_EQ(reified.maxComputeWorkgroupStorageSize, 16352u);
EXPECT_EQ(reified.maxComputeWorkgroupStorageSize, 16384u);
EXPECT_EQ(reified.maxStorageBufferBindingSize, 134217728ul);
}
@ -137,7 +137,7 @@ TEST(Limits, ApplyLimitTiers) {
SetLimitsStorageBufferBindingSizeTier3(&limitsStorageBufferBindingSizeTier3);
auto SetLimitsComputeWorkgroupStorageSizeTier1 = [](dawn::native::Limits* limits) {
limits->maxComputeWorkgroupStorageSize = 16352;
limits->maxComputeWorkgroupStorageSize = 16384;
};
dawn::native::Limits limitsComputeWorkgroupStorageSizeTier1;
dawn::native::GetDefaultLimits(&limitsComputeWorkgroupStorageSizeTier1);

6
webgpu-cts/expectations.txt
View File

@ -354,6 +354,12 @@ crbug.com/dawn/0000 [ win ] webgpu:shader,execution,expression,binary,f32_logica
crbug.com/1322180 webgpu:api,operation,adapter,requestDevice_limits:worse_than_default:limit="minStorageBufferOffsetAlignment" [ Skip ]
crbug.com/1322180 webgpu:api,operation,adapter,requestDevice_limits:worse_than_default:limit="minUniformBufferOffsetAlignment" [ Skip ]
################################################################################
# Failing due to limit value change. Needs CTS update.
################################################################################
crbug.com/dawn/1410 webgpu:api,operation,adapter,requestDevice_limits:supported_limits:limit="maxComputeWorkgroupStorageSize" [ Failure ]
crbug.com/dawn/1410 webgpu:api,operation,adapter,requestDevice_limits:worse_than_default:limit="maxComputeWorkgroupStorageSize" [ Failure ]
# New failures. Please triage:
crbug.com/dawn/0000 [ intel-0x5912 ubuntu ] webgpu:api,operation,adapter,requestDevice_limits:worse_than_default:limit="maxBindGroups" [ Failure ]
crbug.com/dawn/0000 [ intel-0x5912 ubuntu ] webgpu:api,operation,command_buffer,copyTextureToTexture:color_textures,compressed,array:srcFormat="astc-10x10-unorm";dstFormat="astc-10x10-unorm-srgb";dimension="2d" [ Failure ]