encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-07-06 05:06:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Metal: Remove usage of MTLTextureUsagePixelFormatView

Browse Source 
This usage is only needed when reinterpreting formats, which Dawn
doesn't support yet, and has a significant cost in that textures can't
be compressed as well.

Bug: dawn:510
Change-Id: I6e416a97c84a708f97d83f9b15c60b05bbf15908
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26881
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Corentin Wallez 2020-08-18 15:39:06 +00:00 committed by Commit Bot service account
parent 9aed03dcb0
commit caec4ab04a
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/dawn_native/metal/TextureMTL.mm
View File

@ -49,10 +49,6 @@ namespace dawn_native { namespace metal {
result |= MTLTextureUsageRenderTarget; result |= MTLTextureUsageRenderTarget;
} }
if (UsageNeedsTextureView(usage)) {
result |= MTLTextureUsagePixelFormatView;
}
return result; return result;
} }
@ -291,6 +287,8 @@ namespace dawn_native { namespace metal {
mtlDesc.width = descriptor->size.width; mtlDesc.width = descriptor->size.width;
mtlDesc.height = descriptor->size.height; mtlDesc.height = descriptor->size.height;
mtlDesc.sampleCount = descriptor->sampleCount; mtlDesc.sampleCount = descriptor->sampleCount;
// TODO: add MTLTextureUsagePixelFormatView when needed when we support format
// reinterpretation.
mtlDesc.usage = MetalTextureUsage(descriptor->usage); mtlDesc.usage = MetalTextureUsage(descriptor->usage);
mtlDesc.pixelFormat = MetalPixelFormat(descriptor->format); mtlDesc.pixelFormat = MetalPixelFormat(descriptor->format);
mtlDesc.mipmapLevelCount = descriptor->mipLevelCount; mtlDesc.mipmapLevelCount = descriptor->mipLevelCount;