mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-12-16 16:37:08 +00:00
Nuke Builders Part 2: remove all builder code from wire
This removes blocks of code that were obviously builder-specific but also removes the ObjectStorage::valid member that was used to implement the maybe monad on the wire server side. This is no longer needed since dawn_native handles the maybe monad internally now. BUG=dawn:125 Change-Id: I8c30daae9fc70853bc1996d85a860b4877c5976c Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6161 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
committed by
Commit Bot service account
parent
20b0c33913
commit
cb2c64f7d9
@@ -21,24 +21,6 @@ namespace dawn_wire { namespace client {
|
||||
|
||||
class Device;
|
||||
|
||||
struct BuilderCallbackData {
|
||||
bool Call(DawnBuilderErrorStatus status, const char* message) {
|
||||
if (canCall && callback != nullptr) {
|
||||
canCall = true;
|
||||
callback(status, message, userdata1, userdata2);
|
||||
return true;
|
||||
}
|
||||
|
||||
return false;
|
||||
}
|
||||
|
||||
// For help with development, prints all builder errors by default.
|
||||
DawnBuilderErrorCallback callback = nullptr;
|
||||
DawnCallbackUserdata userdata1 = 0;
|
||||
DawnCallbackUserdata userdata2 = 0;
|
||||
bool canCall = true;
|
||||
};
|
||||
|
||||
// All non-Device objects of the client side have:
|
||||
// - A pointer to the device to get where to serialize commands
|
||||
// - The external reference count
|
||||
@@ -51,8 +33,6 @@ namespace dawn_wire { namespace client {
|
||||
Device* device;
|
||||
uint32_t refcount;
|
||||
uint32_t id;
|
||||
|
||||
BuilderCallbackData builderCallback;
|
||||
};
|
||||
|
||||
}} // namespace dawn_wire::client
|
||||
|
||||
Reference in New Issue
Block a user