encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

d3d11: suppress BufferMappedAtCreationTests.NonMappable* 

BufferBase uses a staging buffer to upload data for non-mappable
buffer created with mappedAtCreation. However BufferBase doesn't
unmap staging buffer before copy data from it.  But d3d11 debug
layer complain this illegal usage. It causes test failures.

Bug: dawn:1772
Change-Id: Id1c386ac7c45f41487f9cc7ef4e431eab87ba1c2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/128480
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
This commit is contained in:
Peng Huang 2023-04-21 11:15:39 +00:00 committed by Dawn LUCI CQ
parent d1d1bf7135
commit cc7028ba3f
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/dawn/tests/end2end/BufferTests.cpp
View File

@ -789,6 +789,10 @@ TEST_P(BufferMappedAtCreationTests, MapReadUsageSmall) {
// Test that the simplest mappedAtCreation works for non-mappable buffers. // Test that the simplest mappedAtCreation works for non-mappable buffers.
TEST_P(BufferMappedAtCreationTests, NonMappableUsageSmall) { TEST_P(BufferMappedAtCreationTests, NonMappableUsageSmall) {
// ID3D11DeviceContext::CopySubresourceRegion doesn't allow copying between mapped buffers.
// TODO(dawn:1772): enable this test for D3D11
DAWN_SUPPRESS_TEST_IF(IsD3D11() && IsBackendValidationEnabled());
uint32_t myData = 4239; uint32_t myData = 4239;
wgpu::Buffer buffer = BufferMappedAtCreationWithData(wgpu::BufferUsage::CopySrc, {myData}); wgpu::Buffer buffer = BufferMappedAtCreationWithData(wgpu::BufferUsage::CopySrc, {myData});
UnmapBuffer(buffer); UnmapBuffer(buffer);
@ -830,6 +834,10 @@ TEST_P(BufferMappedAtCreationTests, MapReadUsageLarge) {
// Test mappedAtCreation for a large non-mappable buffer // Test mappedAtCreation for a large non-mappable buffer
TEST_P(BufferMappedAtCreationTests, NonMappableUsageLarge) { TEST_P(BufferMappedAtCreationTests, NonMappableUsageLarge) {
// ID3D11DeviceContext::CopySubresourceRegion doesn't allow copying between mapped buffers.
// TODO(dawn:1772): enable this test for D3D11
DAWN_SUPPRESS_TEST_IF(IsD3D11() && IsBackendValidationEnabled());
constexpr uint64_t kDataSize = 1000 * 1000; constexpr uint64_t kDataSize = 1000 * 1000;
std::vector<uint32_t> myData; std::vector<uint32_t> myData;
for (uint32_t i = 0; i < kDataSize; ++i) { for (uint32_t i = 0; i < kDataSize; ++i) {