encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Disable test where FXC emits bad output 

Bug: tint:904
Change-Id: Ibefd0d83914e39b5a2db942153f183e6f334fcc8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/54880
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
This commit is contained in:
Ben Clayton 2021-06-16 20:18:08 +00:00 committed by Dawn LUCI CQ
parent ff7eb1641e
commit cd417bc9a1
3 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/tests/DawnTest.cpp
View File

@ -819,6 +819,10 @@ bool DawnTestBase::RunSuppressedTests() const {
return gTestEnv->RunSuppressedTests(); return gTestEnv->RunSuppressedTests();
} }
bool DawnTestBase::IsDXC() const {
return HasToggleEnabled("use_dxc");
}
bool DawnTestBase::IsAsan() const { bool DawnTestBase::IsAsan() const {
#if defined(ADDRESS_SANITIZER) #if defined(ADDRESS_SANITIZER)
return true; return true;

2
src/tests/DawnTest.h
View File

@ -295,6 +295,8 @@ class DawnTestBase {
bool IsBackendValidationEnabled() const; bool IsBackendValidationEnabled() const;
bool RunSuppressedTests() const; bool RunSuppressedTests() const;
bool IsDXC() const;
bool IsAsan() const; bool IsAsan() const;
bool HasToggleEnabled(const char* workaround) const; bool HasToggleEnabled(const char* workaround) const;

3
src/tests/end2end/VertexFormatTests.cpp
View File

@ -692,6 +692,9 @@ TEST_P(VertexFormatTest, Float16x2) {
// Fails on NVIDIA's Vulkan drivers on CQ but passes locally. // Fails on NVIDIA's Vulkan drivers on CQ but passes locally.
DAWN_SUPPRESS_TEST_IF(IsVulkan() && IsNvidia()); DAWN_SUPPRESS_TEST_IF(IsVulkan() && IsNvidia());
// TODO(crbug.com/tint/904): FXC emits bad output for this test
DAWN_SUPPRESS_TEST_IF(IsD3D12() && !IsDXC());
std::vector<uint16_t> vertexData = std::vector<uint16_t> vertexData =
Float32ToFloat16(std::vector<float>({14.8f, -0.0f, 22.5f, 1.3f, +0.0f, -24.8f})); Float32ToFloat16(std::vector<float>({14.8f, -0.0f, 22.5f, 1.3f, +0.0f, -24.8f}));